From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/i915: Refer to GGTT VM consistently
Date: Thu, 24 Mar 2016 16:37:28 +0200 [thread overview]
Message-ID: <1458830248.7860.19.camel@linux.intel.com> (raw)
In-Reply-To: <20160323132545.GH21717@nuc-i3427.alporthouse.com>
On ke, 2016-03-23 at 13:25 +0000, Chris Wilson wrote:
> On Wed, Mar 23, 2016 at 03:00:23PM +0200, Joonas Lahtinen wrote:
> >
> > Refer to the GGTT VM consistently as "ggtt_vm" instead of just "ggtt",
> > "vm" or indirectly through other variables like "dev_priv->ggtt.base"
> > to avoid confusion with the i915_ggtt object itself and PPGTT VMs.
> On the one hand, yes it seems more fitting to call it ggtt_vm. On the
> other, we've been pretty consistent in calling the address space ggtt!
> And I like the look of ggtt far more than ggtt_vm. Killing off more
> mixed dev_priv->ggtt.base and ggtt pointer usage is definitely good
> though. But I'm ambivalent about the whole.
Right, ppgtt->base is also being used quite some so I guess you're
right. I'll reroll the patches to get rid of ggtt_vm's everywhere and
use ggtt->base. (I myself hate the convention, but lets stick to one
convention).
Regards, Joonas
> -Chris
>
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-24 14:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 13:00 [PATCH 1/2] drm/i915: Rename GGTT init functions Joonas Lahtinen
2016-03-23 13:00 ` [PATCH 2/2] drm/i915: Refer to GGTT VM consistently Joonas Lahtinen
2016-03-23 13:18 ` [PATCH v2] " Joonas Lahtinen
2016-03-23 13:25 ` [PATCH 2/2] " Chris Wilson
2016-03-24 14:37 ` Joonas Lahtinen [this message]
2016-03-30 12:13 ` [PATCH v3] " Joonas Lahtinen
2016-03-30 13:57 ` [PATCH v4] drm/i915: Refer to GGTT {,VM} consistently Joonas Lahtinen
2016-03-30 14:17 ` [PATCH v4] drm/i915: Refer to GGTT {, VM} consistently Chris Wilson
2016-03-23 13:04 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Rename GGTT init functions Patchwork
2016-03-23 13:35 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Rename GGTT init functions (rev2) Patchwork
2016-03-23 15:25 ` [PATCH 1/2] drm/i915: Rename GGTT init functions Mika Kuoppala
2016-03-23 15:41 ` Ville Syrjälä
2016-03-23 15:54 ` Mika Kuoppala
2016-03-23 16:02 ` Ville Syrjälä
2016-03-23 16:06 ` Chris Wilson
2016-03-24 7:40 ` Joonas Lahtinen
2016-03-24 16:01 ` Dave Gordon
2016-03-24 16:22 ` Chris Wilson
2016-03-24 14:40 ` Joonas Lahtinen
2016-03-24 14:47 ` [PATCH v2] " Joonas Lahtinen
2016-03-29 13:15 ` Joonas Lahtinen
2016-03-29 14:25 ` Chris Wilson
2016-03-30 9:12 ` Chris Wilson
2016-03-30 10:54 ` Joonas Lahtinen
2016-03-24 17:02 ` ✗ Fi.CI.BAT: warning for series starting with [v2] drm/i915: Rename GGTT init functions (rev3) Patchwork
2016-03-30 11:12 ` Joonas Lahtinen
2016-03-31 13:44 ` ✗ Fi.CI.BAT: warning for series starting with [v2] drm/i915: Rename GGTT init functions (rev5) Patchwork
2016-03-31 14:32 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458830248.7860.19.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.