All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Intel graphics driver community testing & development
	<intel-gfx@lists.freedesktop.org>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH v2] drm/i915: Rename GGTT init functions
Date: Tue, 29 Mar 2016 16:15:54 +0300	[thread overview]
Message-ID: <1459257354.8043.11.camel@linux.intel.com> (raw)
In-Reply-To: <1458830866-12578-1-git-send-email-joonas.lahtinen@linux.intel.com>

On to, 2016-03-24 at 16:47 +0200, Joonas Lahtinen wrote:
> Rename and document the GGTT init functions to give a better
> idea of the context where they are called from.
> 
> i915_gem_gtt_init => i915_ggtt_init_hw
> i915_gem_init_global_gtt => i915_gem_init_ggtt
> i915_global_gtt_cleanup => i915_ggtt_cleanup_hw
> 
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>

Chris, accidentally did not remove you A-b for v2. You can retake your
position here.

This is the best balance between general naming logic and consistency
with ppgtt I could come up. How about I merge this?

Regards, Joonas

> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_dma.c     | 14 +++++++-------
>  drivers/gpu/drm/i915/i915_gem.c     |  2 +-
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 18 +++++++++++++++---
>  drivers/gpu/drm/i915/i915_gem_gtt.h |  7 +++----
>  4 files changed, 26 insertions(+), 15 deletions(-)
> 
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-03-29 13:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 13:00 [PATCH 1/2] drm/i915: Rename GGTT init functions Joonas Lahtinen
2016-03-23 13:00 ` [PATCH 2/2] drm/i915: Refer to GGTT VM consistently Joonas Lahtinen
2016-03-23 13:18   ` [PATCH v2] " Joonas Lahtinen
2016-03-23 13:25   ` [PATCH 2/2] " Chris Wilson
2016-03-24 14:37     ` Joonas Lahtinen
2016-03-30 12:13     ` [PATCH v3] " Joonas Lahtinen
2016-03-30 13:57     ` [PATCH v4] drm/i915: Refer to GGTT {,VM} consistently Joonas Lahtinen
2016-03-30 14:17       ` [PATCH v4] drm/i915: Refer to GGTT {, VM} consistently Chris Wilson
2016-03-23 13:04 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Rename GGTT init functions Patchwork
2016-03-23 13:35 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Rename GGTT init functions (rev2) Patchwork
2016-03-23 15:25 ` [PATCH 1/2] drm/i915: Rename GGTT init functions Mika Kuoppala
2016-03-23 15:41 ` Ville Syrjälä
2016-03-23 15:54   ` Mika Kuoppala
2016-03-23 16:02     ` Ville Syrjälä
2016-03-23 16:06       ` Chris Wilson
2016-03-24  7:40       ` Joonas Lahtinen
2016-03-24 16:01         ` Dave Gordon
2016-03-24 16:22           ` Chris Wilson
2016-03-24 14:40     ` Joonas Lahtinen
2016-03-24 14:47     ` [PATCH v2] " Joonas Lahtinen
2016-03-29 13:15       ` Joonas Lahtinen [this message]
2016-03-29 14:25         ` Chris Wilson
2016-03-30  9:12           ` Chris Wilson
2016-03-30 10:54             ` Joonas Lahtinen
2016-03-24 17:02 ` ✗ Fi.CI.BAT: warning for series starting with [v2] drm/i915: Rename GGTT init functions (rev3) Patchwork
2016-03-30 11:12   ` Joonas Lahtinen
2016-03-31 13:44 ` ✗ Fi.CI.BAT: warning for series starting with [v2] drm/i915: Rename GGTT init functions (rev5) Patchwork
2016-03-31 14:32   ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459257354.8043.11.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.