From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH] tools/build: remove usage of sed -i
Date: Thu, 24 Mar 2016 18:05:13 +0100 [thread overview]
Message-ID: <1458839113-4354-1-git-send-email-roger.pau@citrix.com> (raw)
The "-i" sed option is not POSIX compatible [0], remove it's usage and
instead create yet another temporary intermediate file.
[0] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/include/xen-foreign/Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/include/xen-foreign/Makefile b/tools/include/xen-foreign/Makefile
index bb09c93..270a975 100644
--- a/tools/include/xen-foreign/Makefile
+++ b/tools/include/xen-foreign/Makefile
@@ -36,8 +36,9 @@ x86_32.h: mkheader.py structs.py $(ROOT)/arch-x86/xen-x86_32.h $(ROOT)/arch-x86/
x86_64.h: mkheader.py structs.py $(ROOT)/arch-x86/xen-x86_64.h $(ROOT)/arch-x86/xen.h $(ROOT)/xen.h
$(PYTHON) $< $* $@.tmp $(filter %.h,$^)
#Avoid mixing an alignment directive with a uint64_t cast or sizeof expression
- sed 's/(__align8__ \(u\?int64_t\))/(\1)/g' -i $@.tmp
- $(call move-if-changed,$@.tmp,$@)
+ sed 's/(__align8__ \(u\?int64_t\))/(\1)/g' < $@.tmp > $@.tmp2
+ rm $@.tmp
+ $(call move-if-changed,$@.tmp2,$@)
checker.c: mkchecker.py structs.py
$(PYTHON) $< $@ $(architectures)
--
2.6.4 (Apple Git-63)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-03-24 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 17:05 Roger Pau Monne [this message]
2016-03-24 17:08 ` [PATCH] tools/build: remove usage of sed -i Andrew Cooper
2016-03-24 17:10 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458839113-4354-1-git-send-email-roger.pau@citrix.com \
--to=roger.pau@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.