From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] tools/build: remove usage of sed -i
Date: Thu, 24 Mar 2016 17:10:10 +0000 [thread overview]
Message-ID: <22260.8050.413541.623579@mariner.uk.xensource.com> (raw)
In-Reply-To: <56F41EFE.9070409@citrix.com>
Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools/build: remove usage of sed -i"):
> On 24/03/16 17:05, Roger Pau Monne wrote:
> > The "-i" sed option is not POSIX compatible [0], remove it's usage and
> > instead create yet another temporary intermediate file.
> >
> > [0] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
>
> Sorry for breaking this.
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-03-24 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 17:05 [PATCH] tools/build: remove usage of sed -i Roger Pau Monne
2016-03-24 17:08 ` Andrew Cooper
2016-03-24 17:10 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22260.8050.413541.623579@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.