All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Baruch Siach <baruch@tkos.co.il>,
	linux-gpio@vger.kernel.org
Subject: [PATCH 6/9] drivers/gpio: make gpio-pl061.c explicitly non-modular
Date: Sun, 27 Mar 2016 11:44:46 -0400	[thread overview]
Message-ID: <1459093489-18314-7-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com>

The Kconfig for this driver is currently:

config GPIO_PL061
        bool "PrimeCell PL061 GPIO support"

...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity, so that when reading the
driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/gpio-pl061.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
index 5cb38212bbc0..9afb415a5d24 100644
--- a/drivers/gpio/gpio-pl061.c
+++ b/drivers/gpio/gpio-pl061.c
@@ -1,6 +1,8 @@
 /*
  * Copyright (C) 2008, 2009 Provigent Ltd.
  *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
@@ -11,7 +13,7 @@
  */
 #include <linux/spinlock.h>
 #include <linux/errno.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/io.h>
 #include <linux/ioport.h>
 #include <linux/interrupt.h>
@@ -429,8 +431,6 @@ static struct amba_id pl061_ids[] = {
 	{ 0, 0 },
 };
 
-MODULE_DEVICE_TABLE(amba, pl061_ids);
-
 static struct amba_driver pl061_gpio_driver = {
 	.drv = {
 		.name	= "pl061_gpio",
@@ -446,8 +446,4 @@ static int __init pl061_gpio_init(void)
 {
 	return amba_driver_register(&pl061_gpio_driver);
 }
-module_init(pl061_gpio_init);
-
-MODULE_AUTHOR("Baruch Siach <baruch@tkos.co.il>");
-MODULE_DESCRIPTION("PL061 GPIO driver");
-MODULE_LICENSE("GPL");
+device_initcall(pl061_gpio_init);
-- 
2.6.1


WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Baruch Siach <baruch@tkos.co.il>, <linux-gpio@vger.kernel.org>
Subject: [PATCH 6/9] drivers/gpio: make gpio-pl061.c explicitly non-modular
Date: Sun, 27 Mar 2016 11:44:46 -0400	[thread overview]
Message-ID: <1459093489-18314-7-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com>

The Kconfig for this driver is currently:

config GPIO_PL061
        bool "PrimeCell PL061 GPIO support"

...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity, so that when reading the
driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Baruch Siach <baruch@tkos.co.il>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/gpio/gpio-pl061.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
index 5cb38212bbc0..9afb415a5d24 100644
--- a/drivers/gpio/gpio-pl061.c
+++ b/drivers/gpio/gpio-pl061.c
@@ -1,6 +1,8 @@
 /*
  * Copyright (C) 2008, 2009 Provigent Ltd.
  *
+ * Author: Baruch Siach <baruch@tkos.co.il>
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
@@ -11,7 +13,7 @@
  */
 #include <linux/spinlock.h>
 #include <linux/errno.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/io.h>
 #include <linux/ioport.h>
 #include <linux/interrupt.h>
@@ -429,8 +431,6 @@ static struct amba_id pl061_ids[] = {
 	{ 0, 0 },
 };
 
-MODULE_DEVICE_TABLE(amba, pl061_ids);
-
 static struct amba_driver pl061_gpio_driver = {
 	.drv = {
 		.name	= "pl061_gpio",
@@ -446,8 +446,4 @@ static int __init pl061_gpio_init(void)
 {
 	return amba_driver_register(&pl061_gpio_driver);
 }
-module_init(pl061_gpio_init);
-
-MODULE_AUTHOR("Baruch Siach <baruch@tkos.co.il>");
-MODULE_DESCRIPTION("PL061 GPIO driver");
-MODULE_LICENSE("GPL");
+device_initcall(pl061_gpio_init);
-- 
2.6.1

  parent reply	other threads:[~2016-03-27 15:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-27 15:44 [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Paul Gortmaker
2016-03-27 15:44 ` Paul Gortmaker
2016-03-27 15:44 ` [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular Paul Gortmaker
2016-03-27 15:44   ` Paul Gortmaker
2016-03-31 10:01   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 2/9] drivers/gpio: make gpio-mb86s7x.c driver " Paul Gortmaker
2016-03-27 15:44   ` Paul Gortmaker
2016-03-31 13:01   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 3/9] drivers/gpio: make gpio-mc9s08dz60.c " Paul Gortmaker
2016-03-27 15:44   ` Paul Gortmaker
2016-03-31 13:02   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 4/9] drivers/gpio: make gpio-moxart.c " Paul Gortmaker
2016-03-27 15:44   ` Paul Gortmaker
2016-03-31 13:03   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 5/9] drivers/gpio: make gpio-mvebu.c " Paul Gortmaker
2016-03-27 15:44   ` Paul Gortmaker
2016-03-31 13:05   ` Linus Walleij
2016-03-27 15:44 ` Paul Gortmaker [this message]
2016-03-27 15:44   ` [PATCH 6/9] drivers/gpio: make gpio-pl061.c " Paul Gortmaker
2016-03-27 17:40   ` Baruch Siach
2016-03-31 13:06   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 7/9] drivers/gpio: make gpio-sta2x11.c " Paul Gortmaker
2016-03-27 15:44   ` Paul Gortmaker
2016-03-31 13:08   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 8/9] drivers/gpio: make gpio-xgene.c " Paul Gortmaker
2016-03-27 15:44   ` Paul Gortmaker
2016-03-31 13:09   ` Linus Walleij
2016-03-27 15:44 ` [PATCH 9/9] drivers/gpio: make gpio-zx.c " Paul Gortmaker
2016-03-27 15:44   ` Paul Gortmaker
2016-03-31 13:11   ` Linus Walleij
2016-03-31 13:12 ` [PATCH 0/9] gpio: batch #1: remove modular usage from non-modular drivers Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459093489-18314-7-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=baruch@tkos.co.il \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.