From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Wim Van Sebroeck <wim@iguana.be>, Wenyou Yang <wenyou.yang@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com,
plagnioj@jcrosoft.com, fabio.porcedda@gmail.com,
JM.Lin@atmel.com, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/8] watchdog/at91sam9_wdt: Adjust the options of watchdog_info
Date: Thu, 14 Feb 2013 09:12:10 +0100 [thread overview]
Message-ID: <1459249.A0040oxoB3@ws-stein> (raw)
In-Reply-To: <20130213231522.GH7867@spo001.leaseweb.com>
Hello,
On Thursday 14 February 2013 00:15:22, Wim Van Sebroeck wrote:
> Hi Wenyou,
>
> > Since the Watchdog Timer Mode Register can be only written only once,
> > so the watchdog_info shall not support WDIOF_SETTIMEOUT
> > and WDIOF_MAGICCLOSE options, remove them.
>
> Ik you keep using the timer, then you don't have to remove this.
Why removing especially WDIOF_MAGICCLOSE (and the timer needed for that)? This is a feature removal. Without there isn't even a need for nowayout option as it is implicitly set anyway.
Nevertheless I would prefere keeping the timer to allow a user to let the kernel triggering the timer upon MAGICCLOSE.
Alexander
WARNING: multiple messages have this Message-ID (diff)
From: alexander.stein@systec-electronic.com (Alexander Stein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/8] watchdog/at91sam9_wdt: Adjust the options of watchdog_info
Date: Thu, 14 Feb 2013 09:12:10 +0100 [thread overview]
Message-ID: <1459249.A0040oxoB3@ws-stein> (raw)
In-Reply-To: <20130213231522.GH7867@spo001.leaseweb.com>
Hello,
On Thursday 14 February 2013 00:15:22, Wim Van Sebroeck wrote:
> Hi Wenyou,
>
> > Since the Watchdog Timer Mode Register can be only written only once,
> > so the watchdog_info shall not support WDIOF_SETTIMEOUT
> > and WDIOF_MAGICCLOSE options, remove them.
>
> Ik you keep using the timer, then you don't have to remove this.
Why removing especially WDIOF_MAGICCLOSE (and the timer needed for that)? This is a feature removal. Without there isn't even a need for nowayout option as it is implicitly set anyway.
Nevertheless I would prefere keeping the timer to allow a user to let the kernel triggering the timer upon MAGICCLOSE.
Alexander
next prev parent reply other threads:[~2013-02-14 8:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 7:06 [PATCH v4 0/8] watchdog/at91sam9_wdt: Convert to use the new framework Wenyou Yang
2013-02-01 7:06 ` [PATCH v4 1/8] watchdog: add the function watchdog_is_open Wenyou Yang
2013-02-01 7:06 ` Wenyou Yang
2013-02-13 22:46 ` Wim Van Sebroeck
2013-02-01 7:06 ` [PATCH v4 2/8] watchdog/at91sam9_wdt: Remove at91wdt_private and add at91wdt_drvdata struct Wenyou Yang
2013-02-01 7:06 ` Wenyou Yang
2013-02-13 22:48 ` Wim Van Sebroeck
2013-02-18 5:33 ` Yang, Wenyou
2013-02-18 5:33 ` Yang, Wenyou
2013-02-18 5:33 ` Yang, Wenyou
2013-02-01 7:06 ` [PATCH v4 3/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework Wenyou Yang
2013-02-01 7:06 ` Wenyou Yang
2013-02-13 23:10 ` Wim Van Sebroeck
2013-02-18 5:27 ` Yang, Wenyou
2013-02-18 5:27 ` Yang, Wenyou
2013-02-18 5:27 ` Yang, Wenyou
2013-02-01 7:06 ` [PATCH v4 4/8] watchdog/at91sam9_wdt: Adjust the options of watchdog_info Wenyou Yang
2013-02-01 7:06 ` Wenyou Yang
2013-02-13 23:15 ` Wim Van Sebroeck
2013-02-14 8:12 ` Alexander Stein [this message]
2013-02-14 8:12 ` Alexander Stein
2013-02-01 7:06 ` [PATCH v4 5/8] watchdog/at91sam9_wdt: Add nowayout helpers to Watchdog Timer Driver Kernel API Wenyou Yang
2013-02-01 7:06 ` Wenyou Yang
2013-02-13 23:11 ` Wim Van Sebroeck
2013-02-01 7:06 ` [PATCH v4 6/8] watchdog/at91sam9_wdt: Remove the __initdata of at91wdt_wdd Wenyou Yang
2013-02-01 7:06 ` Wenyou Yang
2013-02-13 23:13 ` Wim Van Sebroeck
2013-02-01 7:06 ` [PATCH v4 7/8] ARM: dts: add the watchdog nodes for at91sam9x5 and at91sam9n12 SoC Wenyou Yang
2013-02-01 7:06 ` Wenyou Yang
2013-02-01 7:06 ` [PATCH v4 8/8] ARM: dts: add the watchdog nodes for at91sam9g25ek and at91sam9m10g45ek boards Wenyou Yang
2013-02-01 7:06 ` Wenyou Yang
2013-02-07 11:35 ` [PATCH v4 0/8] watchdog/at91sam9_wdt: Convert to use the new framework Nicolas Ferre
2013-02-07 11:35 ` Nicolas Ferre
2013-02-13 23:25 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459249.A0040oxoB3@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=JM.Lin@atmel.com \
--cc=fabio.porcedda@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=wenyou.yang@atmel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.