From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] drivers/bus: make arm-ccn.c driver explicitly non-modular
Date: Tue, 29 Mar 2016 14:11:25 +0100 [thread overview]
Message-ID: <1459257085.2461.2.camel@arm.com> (raw)
In-Reply-To: <20160329123021.GD6745@arm.com>
On Tue, 2016-03-29 at 13:30 +0100, Will Deacon wrote:
> On Tue, Mar 29, 2016 at 12:53:06PM +0100, Pawel Moll wrote:
> > Dnia 2016-03-29, Tue o godzinie 12:45 +0100, Will Deacon pisze:
> > > I'd much rather fix the driver to build as a module, if at all
> > > possible.
> > > Suzuki (CC'd) is taking a look at that, so please drop this patch
> > > for
> > > now.
> >
> > There's no problem with building arm-ccn.c as a module - all it's
> > really doing today is providing a PMU driver. I don't even know why
> > have I made it bool-only in the first place...
>
> Probably because it doesn't compile due to the irq_set_affinity call.
The original arm-ccn.c did not call it at all. My guess is that I
copied ARM_CCI stanza without thinking. But I'm glad Suzuki will
straighten it out :-)
Pawe?
WARNING: multiple messages have this Message-ID (diff)
From: Pawel Moll <pawel.moll@arm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Olof Johansson <olof@lixom.net>,
suzuki.poulose@arm.com, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] drivers/bus: make arm-ccn.c driver explicitly non-modular
Date: Tue, 29 Mar 2016 14:11:25 +0100 [thread overview]
Message-ID: <1459257085.2461.2.camel@arm.com> (raw)
In-Reply-To: <20160329123021.GD6745@arm.com>
On Tue, 2016-03-29 at 13:30 +0100, Will Deacon wrote:
> On Tue, Mar 29, 2016 at 12:53:06PM +0100, Pawel Moll wrote:
> > Dnia 2016-03-29, Tue o godzinie 12:45 +0100, Will Deacon pisze:
> > > I'd much rather fix the driver to build as a module, if at all
> > > possible.
> > > Suzuki (CC'd) is taking a look at that, so please drop this patch
> > > for
> > > now.
> >
> > There's no problem with building arm-ccn.c as a module - all it's
> > really doing today is providing a PMU driver. I don't even know why
> > have I made it bool-only in the first place...
>
> Probably because it doesn't compile due to the irq_set_affinity call.
The original arm-ccn.c did not call it at all. My guess is that I
copied ARM_CCI stanza without thinking. But I'm glad Suzuki will
straighten it out :-)
Paweł
next prev parent reply other threads:[~2016-03-29 13:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 21:10 [PATCH 0/4] drivers/bus: remove unused modular code from non-modular drivers Paul Gortmaker
2016-03-27 21:10 ` Paul Gortmaker
2016-03-27 21:10 ` [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly non-modular Paul Gortmaker
2016-03-27 21:10 ` Paul Gortmaker
2016-04-07 1:26 ` Brian Norris
2016-04-07 1:26 ` Brian Norris
2016-04-12 18:48 ` Florian Fainelli
2016-04-12 18:48 ` Florian Fainelli
2016-03-27 21:10 ` [PATCH 2/4] drivers/bus: make imx-weim.c " Paul Gortmaker
2016-03-27 21:10 ` Paul Gortmaker
2016-04-07 2:58 ` Shawn Guo
2016-04-07 2:58 ` Shawn Guo
2016-03-27 21:10 ` [PATCH 3/4] drivers/bus: make simple-pm-bus.c " Paul Gortmaker
2016-03-27 21:10 ` Paul Gortmaker
2016-03-28 8:28 ` Geert Uytterhoeven
2016-03-28 8:28 ` Geert Uytterhoeven
2016-03-28 14:35 ` Paul Gortmaker
2016-03-28 14:35 ` Paul Gortmaker
2016-03-27 21:10 ` [PATCH 4/4] drivers/bus: make arm-ccn.c driver " Paul Gortmaker
2016-03-27 21:10 ` Paul Gortmaker
2016-03-29 11:45 ` Will Deacon
2016-03-29 11:45 ` Will Deacon
2016-03-29 11:53 ` Pawel Moll
2016-03-29 11:53 ` Pawel Moll
2016-03-29 12:30 ` Will Deacon
2016-03-29 12:30 ` Will Deacon
2016-03-29 13:11 ` Pawel Moll [this message]
2016-03-29 13:11 ` Pawel Moll
2016-03-29 13:14 ` Paul Gortmaker
2016-03-29 13:14 ` Paul Gortmaker
2016-03-29 11:38 ` [PATCH 0/4] drivers/bus: remove unused modular code from non-modular drivers Will Deacon
2016-03-29 11:38 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459257085.2461.2.camel@arm.com \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.