From: Andrey Vagin <avagin@gmail.com>
To: Ian Kent <raven@themaw.net>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrey Vagin <avagin@openvz.org>
Subject: [PATCH] autofs: don't stuck in a loop if vfs_write returns an error
Date: Thu, 31 Mar 2016 22:12:38 -0700 [thread overview]
Message-ID: <1459487558-21258-1-git-send-email-avagin@gmail.com> (raw)
From: Andrey Vagin <avagin@openvz.org>
__vfs_write() returns a negative value in a error case.
Cc: Ian Kent <raven@themaw.net>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
fs/autofs4/waitq.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 0146d91..631f155 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -66,11 +66,12 @@ static int autofs4_write(struct autofs_sb_info *sbi,
set_fs(KERNEL_DS);
mutex_lock(&sbi->pipe_mutex);
- wr = __vfs_write(file, data, bytes, &file->f_pos);
- while (bytes && wr) {
+ while (bytes) {
+ wr = __vfs_write(file, data, bytes, &file->f_pos);
+ if (wr <= 0)
+ break;
data += wr;
bytes -= wr;
- wr = __vfs_write(file, data, bytes, &file->f_pos);
}
mutex_unlock(&sbi->pipe_mutex);
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Vagin <avagin@gmail.com>
To: Ian Kent <raven@themaw.net>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrey Vagin <avagin@openvz.org>
Subject: [PATCH] autofs: don't stuck in a loop if vfs_write returns an error
Date: Thu, 31 Mar 2016 22:12:38 -0700 [thread overview]
Message-ID: <1459487558-21258-1-git-send-email-avagin@gmail.com> (raw)
From: Andrey Vagin <avagin@openvz.org>
__vfs_write() returns a negative value in a error case.
Cc: Ian Kent <raven@themaw.net>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
fs/autofs4/waitq.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 0146d91..631f155 100644
--- a/fs/autofs4/waitq.c
+++ b/fs/autofs4/waitq.c
@@ -66,11 +66,12 @@ static int autofs4_write(struct autofs_sb_info *sbi,
set_fs(KERNEL_DS);
mutex_lock(&sbi->pipe_mutex);
- wr = __vfs_write(file, data, bytes, &file->f_pos);
- while (bytes && wr) {
+ while (bytes) {
+ wr = __vfs_write(file, data, bytes, &file->f_pos);
+ if (wr <= 0)
+ break;
data += wr;
bytes -= wr;
- wr = __vfs_write(file, data, bytes, &file->f_pos);
}
mutex_unlock(&sbi->pipe_mutex);
--
2.5.0
next reply other threads:[~2016-04-01 5:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 5:12 Andrey Vagin [this message]
2016-04-01 5:12 ` [PATCH] autofs: don't stuck in a loop if vfs_write returns an error Andrey Vagin
2016-04-01 7:37 ` Ian Kent
2016-04-01 7:37 ` Ian Kent
2016-05-23 21:50 ` Andrei Vagin
2016-05-23 21:50 ` Andrei Vagin
2016-05-24 1:34 ` Ian Kent
2016-05-24 1:34 ` Ian Kent
2016-05-30 5:52 ` Ian Kent
2016-05-30 5:52 ` Ian Kent
2016-06-09 1:23 ` Ian Kent
2016-06-09 1:23 ` Ian Kent
2016-06-09 17:27 ` Andrei Vagin
2016-06-10 8:45 ` Ian Kent
2016-06-10 19:07 ` Andrew Morton
2016-06-10 19:07 ` Andrew Morton
2016-06-16 7:58 ` Ian Kent
2016-06-16 7:58 ` Ian Kent
-- strict thread matches above, loose matches on Subject: below --
2016-06-16 8:31 Ian Kent
2016-06-16 8:31 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459487558-21258-1-git-send-email-avagin@gmail.com \
--to=avagin@gmail.com \
--cc=autofs@vger.kernel.org \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.