From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Paszkiewicz, Artur" <artur.paszkiewicz@intel.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] badblocks: fix wrong return value when badblocks are disabled
Date: Tue, 5 Apr 2016 17:37:12 +0000 [thread overview]
Message-ID: <1459877821.4741.4.camel@intel.com> (raw)
In-Reply-To: <1459861174-9238-1-git-send-email-artur.paszkiewicz@intel.com>
On Tue, 2016-04-05 at 14:59 +0200, Artur Paszkiewicz wrote:
> The return value of md_set_badblocks() was inverted when the code was
> taken out of md, but the case when badblocks are disabled was left
> unchanged. This causes silent ignoring of I/O errors and other
> unpredictable behavior on md arrays that do not support badblocks (any
> array not using v1.x metadata).
>
> Fixes: 9e0e252a048b ("badblocks: Add core badblock management code")
> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
> ---
> block/badblocks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Good find, thanks!
Acked-by: Vishal Verma <vishal.l.verma@intel.com>
Should this also be tagged for stable?
-Vishal
next prev parent reply other threads:[~2016-04-05 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 12:59 [PATCH] badblocks: fix wrong return value when badblocks are disabled Artur Paszkiewicz
2016-04-05 17:37 ` Verma, Vishal L [this message]
2016-04-06 9:13 ` Artur Paszkiewicz
2016-04-06 9:26 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459877821.4741.4.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=artur.paszkiewicz@intel.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.