Re: [PATCH] badblocks: fix wrong return value when badblocks are disabled

[Artur Paszkiewicz <artur.paszkiewicz@intel.com>]

On 04/05/2016 07:37 PM, Verma, Vishal L wrote:
> On Tue, 2016-04-05 at 14:59 +0200, Artur Paszkiewicz wrote:
>> The return value of md_set_badblocks() was inverted when the code was
>> taken out of md, but the case when badblocks are disabled was left
>> unchanged. This causes silent ignoring of I/O errors and other
>> unpredictable behavior on md arrays that do not support badblocks (any
>> array not using v1.x metadata).
>>
>> Fixes: 9e0e252a048b ("badblocks: Add core badblock management code")
>> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
>> ---
>>  block/badblocks.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Good find, thanks!
> 
> Acked-by: Vishal Verma <vishal.l.verma@intel.com>
> 
> Should this also be tagged for stable?

Yes, I think it should be, since it affects 4.5.

Artur