From: Joe Perches <joe@perches.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-afs@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.
Date: Thu, 07 Apr 2016 13:21:58 -0700 [thread overview]
Message-ID: <1460060518.1800.8.camel@perches.com> (raw)
In-Reply-To: <981.1460058224@warthog.procyon.org.uk>
On Thu, 2016-04-07 at 20:43 +0100, David Howells wrote:
> Joe Perches <joe@perches.com> wrote:
> > > Joe Perches <joe@perches.com> wrote:
> > > > It might be better to remove kenter and _enter
> > > > altogether and use function tracing instead.
> > > Possibly - but not at this time.
> > Swell.
> I didn't say I wouldn't do it - it's just that I'm trying to fix other stuff
> at the moment and don't particularly want to add that to the list just now.
> kenter, _enter and co. are serving me very well.
No worries, I didn't mean to imply you wouldn't.
It's your code, do what and when you want.
> > > Besides, isn't the function tracing log lost
> > > if the machine crashes?
> > I believe yes, but would it matter?
> Let's see... If the machine panics whilst I'm developing stuff (quite likely
> if something goes wrong in BH context), how do I get at the function tracing
> log to find out why it panicked if the log is then lost? With the serial
> console, at least I automatically capture the output of kenter and co..
But you also don't get a bunch of other useful stuff.
btw: there is ftrace_dump_on_oops
https://lwn.net/Articles/366796/
next prev parent reply other threads:[~2016-04-07 20:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 16:22 [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Howells
2016-04-07 16:23 ` [PATCH 1/9] afs: Wait for outstanding async calls before closing rxrpc socket David Howells
2016-04-07 16:23 ` [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled David Howells
2016-04-07 16:31 ` Joe Perches
2016-04-07 17:05 ` David Howells
2016-04-07 17:19 ` Joe Perches
2016-04-07 19:43 ` David Howells
2016-04-07 20:21 ` Joe Perches [this message]
2016-04-07 20:42 ` David Howells
2016-04-07 17:38 ` David Miller
2016-04-07 19:45 ` David Howells
2016-04-07 20:36 ` David Miller
2016-04-07 20:47 ` David Howells
2016-04-07 20:50 ` David Miller
2016-04-07 21:24 ` David Howells
2016-04-07 16:23 ` [PATCH 3/9] rxrpc: Move some miscellaneous bits out into their own file David Howells
2016-04-07 16:23 ` [PATCH 4/9] rxrpc: Static arrays of strings should be const char *const[] David Howells
2016-04-07 16:23 ` [PATCH 5/9] rxrpc: Differentiate local and remote abort codes in structs David Howells
2016-04-07 16:23 ` [PATCH 6/9] rxrpc: Don't pass gfp around in incoming call handling functions David Howells
2016-04-07 16:23 ` [PATCH 7/9] rxrpc: Don't assume transport address family and size when using it David Howells
2016-04-07 16:23 ` [PATCH 8/9] rxrpc: Absorb the rxkad security module David Howells
2016-04-07 16:23 ` [PATCH 9/9] rxrpc: Create a null security type and get rid of conditional calls David Howells
2016-04-11 19:35 ` [PATCH 0/9] RxRPC: 2nd rewrite part 1 David Miller
2016-04-11 20:38 ` David Howells
2016-04-11 22:01 ` David Howells
2016-04-11 22:29 ` David Howells
2016-04-12 1:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460060518.1800.8.camel@perches.com \
--to=joe@perches.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.