From: "Rafał Miłecki" <zajec5@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "Richard Weinberger" <richard@nod.at>,
linux-mtd@lists.infradead.org,
"Egor Martovetsky" <egor@pasemi.com>,
"Olof Johansson" <olof@lixom.net>,
"Joe Perches" <joe@perches.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC PA
SEMI PWRFICIENT), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH V2] mtd: nand: pasemi: switch to pr_* functions
Date: Fri, 8 Apr 2016 13:13:23 +0200 [thread overview]
Message-ID: <1460114003-19926-1-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1460111589-18781-1-git-send-email-zajec5@gmail.com>
1) Use pr_fmt to keep messages consistent
2) Don't warn if kzalloc fails as it dumps stack on its own
3) Use %pR format for displaying whole resource to avoid:
warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘resource_size_t’
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/pasemi_nand.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
index 63fcb8c..e8372b4 100644
--- a/drivers/mtd/nand/pasemi_nand.c
+++ b/drivers/mtd/nand/pasemi_nand.c
@@ -22,6 +22,8 @@
#undef DEBUG
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/mtd/mtd.h>
@@ -112,8 +114,6 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
/* Allocate memory for MTD device structure and private data */
chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
if (!chip) {
- printk(KERN_WARNING
- "Unable to allocate PASEMI NAND MTD device structure\n");
err = -ENOMEM;
goto out;
}
@@ -163,13 +163,12 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
}
if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) {
- printk(KERN_ERR "pasemi_nand: Unable to register MTD device\n");
+ pr_err("Unable to register MTD device\n");
err = -ENODEV;
goto out_lpc;
}
- printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n",
- res.start, lpcctl);
+ pr_info("PA Semi NAND flash at %pR, control at I/O %x\n", &res, lpcctl);
return 0;
--
1.8.4.5
next prev parent reply other threads:[~2016-04-08 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 10:33 [PATCH] mtd: nand: pasemi: switch to pr_* functions Rafał Miłecki
2016-04-08 10:50 ` Joe Perches
2016-04-08 10:52 ` kbuild test robot
2016-04-08 11:13 ` Rafał Miłecki [this message]
2016-04-08 16:49 ` [PATCH V2] " Joe Perches
2016-04-09 9:50 ` Andy Shevchenko
2016-04-09 9:50 ` Andy Shevchenko
2016-04-13 7:44 ` Boris Brezillon
2016-04-13 7:44 ` Boris Brezillon
2016-04-13 9:48 ` [PATCH V3] mtd: nand: pasemi: switch to dev_* printing functions Rafał Miłecki
2016-04-13 11:54 ` Boris Brezillon
2016-04-13 11:54 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460114003-19926-1-git-send-email-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=egor@pasemi.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=olof@lixom.net \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.