All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, Egor Martovetsky <egor@pasemi.com>,
	Olof Johansson <olof@lixom.net>, Joe Perches <joe@perches.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC PA
	SEMI PWRFICIENT), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH V3] mtd: nand: pasemi: switch to dev_* printing functions
Date: Wed, 13 Apr 2016 13:54:44 +0200	[thread overview]
Message-ID: <20160413135444.4ab83cde@bbrezillon> (raw)
In-Reply-To: <1460540885-4506-1-git-send-email-zajec5@gmail.com>

On Wed, 13 Apr 2016 11:48:05 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

> It also contains some minor related changes:
> 1) Don't warn if kzalloc fails as it dumps stack on its own
> 2) Use %pR format for displaying whole resource to avoid:
> warning: format ‘%08llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘resource_size_t’
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>

Applied with a slightly different commit message to avoid "Possible
unwrapped commit description" checkpatch warning.

Thanks,

Boris

> ---
> V3: Switch to dev_* instead of pr_*
> ---
>  drivers/mtd/nand/pasemi_nand.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nand.c
> index 63fcb8c..5de7591 100644
> --- a/drivers/mtd/nand/pasemi_nand.c
> +++ b/drivers/mtd/nand/pasemi_nand.c
> @@ -92,8 +92,9 @@ int pasemi_device_ready(struct mtd_info *mtd)
>  
>  static int pasemi_nand_probe(struct platform_device *ofdev)
>  {
> +	struct device *dev = &ofdev->dev;
>  	struct pci_dev *pdev;
> -	struct device_node *np = ofdev->dev.of_node;
> +	struct device_node *np = dev->of_node;
>  	struct resource res;
>  	struct nand_chip *chip;
>  	int err = 0;
> @@ -107,13 +108,11 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
>  	if (pasemi_nand_mtd)
>  		return -ENODEV;
>  
> -	pr_debug("pasemi_nand at %pR\n", &res);
> +	dev_dbg(dev, "pasemi_nand at %pR\n", &res);
>  
>  	/* Allocate memory for MTD device structure and private data */
>  	chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
>  	if (!chip) {
> -		printk(KERN_WARNING
> -		       "Unable to allocate PASEMI NAND MTD device structure\n");
>  		err = -ENOMEM;
>  		goto out;
>  	}
> @@ -121,7 +120,7 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
>  	pasemi_nand_mtd = nand_to_mtd(chip);
>  
>  	/* Link the private data with the MTD structure */
> -	pasemi_nand_mtd->dev.parent = &ofdev->dev;
> +	pasemi_nand_mtd->dev.parent = dev;
>  
>  	chip->IO_ADDR_R = of_iomap(np, 0);
>  	chip->IO_ADDR_W = chip->IO_ADDR_R;
> @@ -163,13 +162,13 @@ static int pasemi_nand_probe(struct platform_device *ofdev)
>  	}
>  
>  	if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) {
> -		printk(KERN_ERR "pasemi_nand: Unable to register MTD device\n");
> +		dev_err(dev, "Unable to register MTD device\n");
>  		err = -ENODEV;
>  		goto out_lpc;
>  	}
>  
> -	printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n",
> -	       res.start, lpcctl);
> +	dev_info(dev, "PA Semi NAND flash at %pR, control at I/O %x\n", &res,
> +		 lpcctl);
>  
>  	return 0;
>  



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, Egor Martovetsky <egor@pasemi.com>,
	Olof Johansson <olof@lixom.net>, Joe Perches <joe@perches.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC PA
	SEMI PWRFICIENT), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH V3] mtd: nand: pasemi: switch to dev_* printing functions
Date: Wed, 13 Apr 2016 13:54:44 +0200	[thread overview]
Message-ID: <20160413135444.4ab83cde@bbrezillon> (raw)
In-Reply-To: <1460540885-4506-1-git-send-email-zajec5@gmail.com>

On Wed, 13 Apr 2016 11:48:05 +0200
Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> wrote:

> It also contains some minor related changes:
> 1) Don't warn if kzalloc fails as it dumps stack on its own
> 2) Use %pR format for displaying whole resource to avoid:
> warning: format =E2=80=98%08llx=E2=80=99 expects type =E2=80=98long long =
unsigned int=E2=80=99, but argument 2 has type =E2=80=98resource_size_t=E2=
=80=99
>=20
> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com>

Applied with a slightly different commit message to avoid "Possible
unwrapped commit description" checkpatch warning.

Thanks,

Boris

> ---
> V3: Switch to dev_* instead of pr_*
> ---
>  drivers/mtd/nand/pasemi_nand.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/mtd/nand/pasemi_nand.c b/drivers/mtd/nand/pasemi_nan=
d.c
> index 63fcb8c..5de7591 100644
> --- a/drivers/mtd/nand/pasemi_nand.c
> +++ b/drivers/mtd/nand/pasemi_nand.c
> @@ -92,8 +92,9 @@ int pasemi_device_ready(struct mtd_info *mtd)
> =20
>  static int pasemi_nand_probe(struct platform_device *ofdev)
>  {
> +	struct device *dev =3D &ofdev->dev;
>  	struct pci_dev *pdev;
> -	struct device_node *np =3D ofdev->dev.of_node;
> +	struct device_node *np =3D dev->of_node;
>  	struct resource res;
>  	struct nand_chip *chip;
>  	int err =3D 0;
> @@ -107,13 +108,11 @@ static int pasemi_nand_probe(struct platform_device=
 *ofdev)
>  	if (pasemi_nand_mtd)
>  		return -ENODEV;
> =20
> -	pr_debug("pasemi_nand at %pR\n", &res);
> +	dev_dbg(dev, "pasemi_nand at %pR\n", &res);
> =20
>  	/* Allocate memory for MTD device structure and private data */
>  	chip =3D kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
>  	if (!chip) {
> -		printk(KERN_WARNING
> -		       "Unable to allocate PASEMI NAND MTD device structure\n");
>  		err =3D -ENOMEM;
>  		goto out;
>  	}
> @@ -121,7 +120,7 @@ static int pasemi_nand_probe(struct platform_device *=
ofdev)
>  	pasemi_nand_mtd =3D nand_to_mtd(chip);
> =20
>  	/* Link the private data with the MTD structure */
> -	pasemi_nand_mtd->dev.parent =3D &ofdev->dev;
> +	pasemi_nand_mtd->dev.parent =3D dev;
> =20
>  	chip->IO_ADDR_R =3D of_iomap(np, 0);
>  	chip->IO_ADDR_W =3D chip->IO_ADDR_R;
> @@ -163,13 +162,13 @@ static int pasemi_nand_probe(struct platform_device=
 *ofdev)
>  	}
> =20
>  	if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) {
> -		printk(KERN_ERR "pasemi_nand: Unable to register MTD device\n");
> +		dev_err(dev, "Unable to register MTD device\n");
>  		err =3D -ENODEV;
>  		goto out_lpc;
>  	}
> =20
> -	printk(KERN_INFO "PA Semi NAND flash at %08llx, control at I/O %x\n",
> -	       res.start, lpcctl);
> +	dev_info(dev, "PA Semi NAND flash at %pR, control at I/O %x\n", &res,
> +		 lpcctl);
> =20
>  	return 0;
> =20



--=20
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2016-04-13 11:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 10:33 [PATCH] mtd: nand: pasemi: switch to pr_* functions Rafał Miłecki
2016-04-08 10:50 ` Joe Perches
2016-04-08 10:52 ` kbuild test robot
2016-04-08 11:13 ` [PATCH V2] " Rafał Miłecki
2016-04-08 16:49   ` Joe Perches
2016-04-09  9:50   ` Andy Shevchenko
2016-04-09  9:50     ` Andy Shevchenko
2016-04-13  7:44     ` Boris Brezillon
2016-04-13  7:44       ` Boris Brezillon
2016-04-13  9:48   ` [PATCH V3] mtd: nand: pasemi: switch to dev_* printing functions Rafał Miłecki
2016-04-13 11:54     ` Boris Brezillon [this message]
2016-04-13 11:54       ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413135444.4ab83cde@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=egor@pasemi.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=olof@lixom.net \
    --cc=richard@nod.at \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.