* [PATCH] Staging: Fixed coding style warning
@ 2016-04-13 0:10 Panos Vlachos
2016-04-13 0:20 ` Joe Perches
2016-04-13 0:39 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Panos Vlachos @ 2016-04-13 0:10 UTC (permalink / raw)
To: oleg.drokin; +Cc: devel, linux-kernel, Panos Vlachos
Fixed coding style warning
Signed-off-by: Panos Vlachos <panosvlchs@gmail.com>
---
drivers/staging/lustre/lnet/lnet/nidstrings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/nidstrings.c b/drivers/staging/lustre/lnet/lnet/nidstrings.c
index ebf468f..f532e44 100644
--- a/drivers/staging/lustre/lnet/lnet/nidstrings.c
+++ b/drivers/staging/lustre/lnet/lnet/nidstrings.c
@@ -197,7 +197,7 @@ add_nidrange(const struct cfs_lstr *src,
struct netstrfns *nf;
struct nidrange *nr;
int endlen;
- unsigned netnum;
+ int netnum;
if (src->ls_len >= LNET_NIDSTR_SIZE)
return NULL;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: Fixed coding style warning
2016-04-13 0:10 [PATCH] Staging: Fixed coding style warning Panos Vlachos
@ 2016-04-13 0:20 ` Joe Perches
2016-04-13 0:39 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2016-04-13 0:20 UTC (permalink / raw)
To: Panos Vlachos, oleg.drokin; +Cc: devel, linux-kernel
On Wed, 2016-04-13 at 03:10 +0300, Panos Vlachos wrote:
> Fixed coding style warning
[]
> diff --git a/drivers/staging/lustre/lnet/lnet/nidstrings.c b/drivers/staging/lustre/lnet/lnet/nidstrings.c
[]
> @@ -197,7 +197,7 @@ add_nidrange(const struct cfs_lstr *src,
> struct netstrfns *nf;
> struct nidrange *nr;
> int endlen;
> - unsigned netnum;
> + int netnum;
Why change the type from unsigned to signed?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: Fixed coding style warning
2016-04-13 0:10 [PATCH] Staging: Fixed coding style warning Panos Vlachos
2016-04-13 0:20 ` Joe Perches
@ 2016-04-13 0:39 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-04-13 0:39 UTC (permalink / raw)
To: Panos Vlachos; +Cc: oleg.drokin, devel, linux-kernel
On Wed, Apr 13, 2016 at 03:10:45AM +0300, Panos Vlachos wrote:
> Fixed coding style warning
What warning?
And always put the driver name in the subject so we know where to merge
this to.
And finally, use get_maintainer.pl to determine who to send this to.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-13 0:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-13 0:10 [PATCH] Staging: Fixed coding style warning Panos Vlachos
2016-04-13 0:20 ` Joe Perches
2016-04-13 0:39 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.