Re: [PATCH v2 1/2] ARM: rockchip: set correct stabilization thresholds in suspend

["Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>]

Hi Chris,

Am Donnerstag, 23. Juli 2015, 10:29:34 schrieb Heiko Stübner:
> diff --git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c
> index 892bace..04d3028 100644
> --- a/arch/arm/mach-rockchip/pm.c
> +++ b/arch/arm/mach-rockchip/pm.c
> @@ -145,6 +145,10 @@ static void rk3288_slp_mode_set(int level)
> 
>  		mode_set1 |= BIT(PMU_CLR_ALIVE) | BIT(PMU_CLR_BUS) |
>  			     BIT(PMU_CLR_PERI) | BIT(PMU_CLR_DMA);
> +
> +		/* 30ms on a 32kHz clock for osc and pmic stabilization */
> +		regmap_write(pmu_regmap, RK3288_PMU_OSC_CNT, 32 * 30);
> +		regmap_write(pmu_regmap, RK3288_PMU_STABL_CNT, 32 * 30);

The deep suspend mode has two bits handling the 32kHz clock switch (PMU_USE_LF 
and ALIVE_USE_LF). Just for my understanding, are these always supposed to be 
set to the same value or can there be a case when only one of them is set?

Also when deciding the correct stabilization delays on which of the two are 
these dependant?

I.e. something like

  stabl_cnt = PMU_PMU_USE_LF ? 32 : 24000
  osc_cnt = PMU_ALIVE_USE_LF ? 32 : 24000

or are these always to be set similarly?


Thanks
Heiko