All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libnvdimm, btt: add btt startup debug
Date: Fri, 15 Apr 2016 17:00:31 +0000	[thread overview]
Message-ID: <1460739631.3012.5.camel@intel.com> (raw)
In-Reply-To: <146068804238.24085.7095431982077468731.stgit@dwillia2-desk3.jf.intel.com>

On Thu, 2016-04-14 at 19:40 -0700, Dan Williams wrote:
> Report the reason for btt probe failures when debug is enabled.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/nvdimm/btt.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reveiwed-by: Vishal Verma <Vishal.l.verma@intel.com>

> 
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index cc9fafed9362..68a7c3c1eed9 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1383,11 +1383,15 @@ int nvdimm_namespace_attach_btt(struct
> nd_namespace_common *ndns)
>  	struct btt *btt;
>  	size_t rawsize;
>  
> -	if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize)
> +	if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) {
> +		dev_dbg(&nd_btt->dev, "incomplete btt
> configuration\n");
>  		return -ENODEV;
> +	}
>  
>  	rawsize = nvdimm_namespace_capacity(ndns) - SZ_4K;
>  	if (rawsize < ARENA_MIN_SIZE) {
> +		dev_dbg(&nd_btt->dev, "%s must be at least %ld
> bytes\n",
> +				dev_name(&ndns->dev), ARENA_MIN_SIZE
> + SZ_4K);
>  		return -ENXIO;
>  	}
>  	nd_region = to_nd_region(nd_btt->dev.parent);
> 
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libnvdimm, btt: add btt startup debug
Date: Fri, 15 Apr 2016 17:00:31 +0000	[thread overview]
Message-ID: <1460739631.3012.5.camel@intel.com> (raw)
In-Reply-To: <146068804238.24085.7095431982077468731.stgit@dwillia2-desk3.jf.intel.com>

On Thu, 2016-04-14 at 19:40 -0700, Dan Williams wrote:
> Report the reason for btt probe failures when debug is enabled.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/nvdimm/btt.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reveiwed-by: Vishal Verma <Vishal.l.verma@intel.com>

> 
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index cc9fafed9362..68a7c3c1eed9 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1383,11 +1383,15 @@ int nvdimm_namespace_attach_btt(struct
> nd_namespace_common *ndns)
>  	struct btt *btt;
>  	size_t rawsize;
>  
> -	if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize)
> +	if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) {
> +		dev_dbg(&nd_btt->dev, "incomplete btt
> configuration\n");
>  		return -ENODEV;
> +	}
>  
>  	rawsize = nvdimm_namespace_capacity(ndns) - SZ_4K;
>  	if (rawsize < ARENA_MIN_SIZE) {
> +		dev_dbg(&nd_btt->dev, "%s must be at least %ld
> bytes\n",
> +				dev_name(&ndns->dev), ARENA_MIN_SIZE
> + SZ_4K);
>  		return -ENXIO;
>  	}
>  	nd_region = to_nd_region(nd_btt->dev.parent);
> 
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2016-04-15 17:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15  2:40 [PATCH] libnvdimm, btt: add btt startup debug Dan Williams
2016-04-15  2:40 ` Dan Williams
2016-04-15  7:10 ` Johannes Thumshirn
2016-04-15  7:10   ` Johannes Thumshirn
2016-04-15 17:00 ` Verma, Vishal L [this message]
2016-04-15 17:00   ` Verma, Vishal L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460739631.3012.5.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.