All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tina Ruchandani <ruchandani.tina@gmail.com>,
	y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'
Date: Sun, 17 Apr 2016 14:42:33 +0200	[thread overview]
Message-ID: <1460896953.15362.2.camel@sipsolutions.net> (raw)
In-Reply-To: <5521267.mr5HLCdTY6@wuerfel>

On Sun, 2016-04-17 at 01:34 +0200, Arnd Bergmann wrote:
> On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote:
> > 
> > > 
> > > The patch was build-tested / debugged by removing the
> > > "if VERBOSE > SHOW_ERROR_MESSAGES" guards.
> > Stands to reason that we should just remove the (more or less) dead
> > code, since I don't think anyone really ever touches this driver
> > any
> > more or will ever again ...
> Do you mean removing all DEBUG() statements from the driver, or
> removing the entire driver?
> 

We tried removing the driver once, since p54 supposedly drives the same
hardware, but some people had certain use cases that didn't work there,
apparently.

I was thinking more restrictively of just the stuff that can't even be
built without modifying the sources - like the "#if VERBOSE" thing.

johannes

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	Tina Ruchandani <ruchandani.tina@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'
Date: Sun, 17 Apr 2016 14:42:33 +0200	[thread overview]
Message-ID: <1460896953.15362.2.camel@sipsolutions.net> (raw)
In-Reply-To: <5521267.mr5HLCdTY6@wuerfel>

On Sun, 2016-04-17 at 01:34 +0200, Arnd Bergmann wrote:
> On Wednesday 13 April 2016 10:38:26 Johannes Berg wrote:
> > 
> > > 
> > > The patch was build-tested / debugged by removing the
> > > "if VERBOSE > SHOW_ERROR_MESSAGES" guards.
> > Stands to reason that we should just remove the (more or less) dead
> > code, since I don't think anyone really ever touches this driver
> > any
> > more or will ever again ...
> Do you mean removing all DEBUG() statements from the driver, or
> removing the entire driver?
> 

We tried removing the driver once, since p54 supposedly drives the same
hardware, but some people had certain use cases that didn't work there,
apparently.

I was thinking more restrictively of just the stuff that can't even be
built without modifying the sources - like the "#if VERBOSE" thing.

johannes
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038

  reply	other threads:[~2016-04-17 12:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  6:09 [PATCH v3] prism54: isl_38xx: Replace 'struct timeval' Tina Ruchandani
2016-04-13  6:09 ` Tina Ruchandani
2016-04-13  8:38 ` Johannes Berg
2016-04-13  8:38   ` Johannes Berg
2016-04-13  9:45   ` Arend Van Spriel
2016-04-13  9:45     ` Arend Van Spriel
2016-04-16 23:34   ` Arnd Bergmann
2016-04-16 23:34     ` Arnd Bergmann
2016-04-17 12:42     ` Johannes Berg [this message]
2016-04-17 12:42       ` Johannes Berg
2016-04-17 22:10       ` Arnd Bergmann
2016-04-17 22:10         ` Arnd Bergmann
2016-04-19  8:57         ` Johannes Berg
2016-04-19  8:57           ` Johannes Berg
2016-04-22 18:09           ` Kalle Valo
2016-04-22 18:09             ` Kalle Valo
2016-04-23  1:30             ` Luis R. Rodriguez
2016-04-26  9:10 ` [v3] " Kalle Valo
2016-04-26  9:10 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460896953.15362.2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ruchandani.tina@gmail.com \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.