All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "Vlad, Marius C" <marius.c.vlad@intel.com>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"baker.dylan.c@gmail.com" <baker.dylan.c@gmail.com>
Subject: Re: [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates.
Date: Tue, 19 Apr 2016 14:23:02 +0000	[thread overview]
Message-ID: <1461075871.30898.156.camel@intel.com> (raw)
In-Reply-To: <20160419141311.GA10491@mcvlad-wk.rb.intel.com>

Well, I don't see how to do it in a good and safe way for the old
versions that didn't have the version check, so or we do an ugly
version of it or we just ask people to upgrade the piglit when they
start to report this commit is breaking stuff. 

Really up to you. But I believe we need on solution or another so if
you decide to go with this patch feel free to use:

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

On Tue, 2016-04-19 at 17:13 +0300, Marius Vlad wrote:
> There was some discussions about this before:
> 
> https://lists.freedesktop.org/archives/intel-gfx/2016-March/089128.ht
> ml
> and
> https://lists.freedesktop.org/archives/intel-gfx/2016-March/090302.ht
> ml
> 
> There's some concern that his approach might brake with older
> versions
> of piglit. Is this still the case, or we can push this?
> 
> On Tue, Apr 19, 2016 at 03:31:12PM +0200, Maarten Lankhorst wrote:
> > Right now scripts/run-tests.sh fails with the following error
> > message:
> > 
> > Fatal Error: Cannot overwrite existing folder without the -o/-
> > -overwrite option being set.
> > 
> > Fix this by adding -o as required.
> > 
> > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com
> > >
> > ---
> > diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
> > index 99e6124f5279..f33b0ffd342a 100755
> > --- a/scripts/run-tests.sh
> > +++ b/scripts/run-tests.sh
> > @@ -125,7 +125,7 @@ if [ "x$RESUME" != "x" ]; then
> >  	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume
> > "$RESULTS" $NORETRY
> >  else
> >  	mkdir -p "$RESULTS"
> > -	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt
> > "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER
> > +	sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt
> > "$RESULTS" -o -s $VERBOSE $EXCLUDE $FILTER
> >  fi
> >  
> >  if [ "$SUMMARY" == "html" ]; then
> >  
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-04-19 14:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19 13:31 [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates Maarten Lankhorst
2016-04-19 13:38 ` Ville Syrjälä
2016-04-19 13:40   ` Maarten Lankhorst
2016-04-19 13:50     ` Ville Syrjälä
2016-04-19 14:13 ` Marius Vlad
2016-04-19 14:23   ` Vivi, Rodrigo [this message]
2016-04-19 18:16     ` Dylan Baker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461075871.30898.156.camel@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=baker.dylan.c@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marius.c.vlad@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.