* [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates. @ 2016-04-19 13:31 Maarten Lankhorst 2016-04-19 13:38 ` Ville Syrjälä 2016-04-19 14:13 ` Marius Vlad 0 siblings, 2 replies; 7+ messages in thread From: Maarten Lankhorst @ 2016-04-19 13:31 UTC (permalink / raw) To: Intel Graphics Development Right now scripts/run-tests.sh fails with the following error message: Fatal Error: Cannot overwrite existing folder without the -o/--overwrite option being set. Fix this by adding -o as required. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> --- diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh index 99e6124f5279..f33b0ffd342a 100755 --- a/scripts/run-tests.sh +++ b/scripts/run-tests.sh @@ -125,7 +125,7 @@ if [ "x$RESUME" != "x" ]; then sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORETRY else mkdir -p "$RESULTS" - sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER + sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -o -s $VERBOSE $EXCLUDE $FILTER fi if [ "$SUMMARY" == "html" ]; then _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates. 2016-04-19 13:31 [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates Maarten Lankhorst @ 2016-04-19 13:38 ` Ville Syrjälä 2016-04-19 13:40 ` Maarten Lankhorst 2016-04-19 14:13 ` Marius Vlad 1 sibling, 1 reply; 7+ messages in thread From: Ville Syrjälä @ 2016-04-19 13:38 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: Intel Graphics Development On Tue, Apr 19, 2016 at 03:31:12PM +0200, Maarten Lankhorst wrote: > Right now scripts/run-tests.sh fails with the following error message: > > Fatal Error: Cannot overwrite existing folder without the -o/--overwrite option being set. > > Fix this by adding -o as required. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > --- > diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh > index 99e6124f5279..f33b0ffd342a 100755 > --- a/scripts/run-tests.sh > +++ b/scripts/run-tests.sh > @@ -125,7 +125,7 @@ if [ "x$RESUME" != "x" ]; then > sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORETRY > else > mkdir -p "$RESULTS" Just drop the mkdir instead? > - sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER > + sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -o -s $VERBOSE $EXCLUDE $FILTER > fi > > if [ "$SUMMARY" == "html" ]; then > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates. 2016-04-19 13:38 ` Ville Syrjälä @ 2016-04-19 13:40 ` Maarten Lankhorst 2016-04-19 13:50 ` Ville Syrjälä 0 siblings, 1 reply; 7+ messages in thread From: Maarten Lankhorst @ 2016-04-19 13:40 UTC (permalink / raw) To: Ville Syrjälä; +Cc: Intel Graphics Development Op 19-04-16 om 15:38 schreef Ville Syrjälä: > On Tue, Apr 19, 2016 at 03:31:12PM +0200, Maarten Lankhorst wrote: >> Right now scripts/run-tests.sh fails with the following error message: >> >> Fatal Error: Cannot overwrite existing folder without the -o/--overwrite option being set. >> >> Fix this by adding -o as required. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> --- >> diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh >> index 99e6124f5279..f33b0ffd342a 100755 >> --- a/scripts/run-tests.sh >> +++ b/scripts/run-tests.sh >> @@ -125,7 +125,7 @@ if [ "x$RESUME" != "x" ]; then >> sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORETRY >> else >> mkdir -p "$RESULTS" > Just drop the mkdir instead? > In that case I wouldn't be able to retry in an existing directory. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates. 2016-04-19 13:40 ` Maarten Lankhorst @ 2016-04-19 13:50 ` Ville Syrjälä 0 siblings, 0 replies; 7+ messages in thread From: Ville Syrjälä @ 2016-04-19 13:50 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: Intel Graphics Development On Tue, Apr 19, 2016 at 03:40:46PM +0200, Maarten Lankhorst wrote: > Op 19-04-16 om 15:38 schreef Ville Syrjälä: > > On Tue, Apr 19, 2016 at 03:31:12PM +0200, Maarten Lankhorst wrote: > >> Right now scripts/run-tests.sh fails with the following error message: > >> > >> Fatal Error: Cannot overwrite existing folder without the -o/--overwrite option being set. > >> > >> Fix this by adding -o as required. > >> > >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > >> --- > >> diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh > >> index 99e6124f5279..f33b0ffd342a 100755 > >> --- a/scripts/run-tests.sh > >> +++ b/scripts/run-tests.sh > >> @@ -125,7 +125,7 @@ if [ "x$RESUME" != "x" ]; then > >> sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORETRY > >> else > >> mkdir -p "$RESULTS" > > Just drop the mkdir instead? > > > In that case I wouldn't be able to retry in an existing directory. Which some people may consider a good thing. -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates. 2016-04-19 13:31 [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates Maarten Lankhorst 2016-04-19 13:38 ` Ville Syrjälä @ 2016-04-19 14:13 ` Marius Vlad 2016-04-19 14:23 ` Vivi, Rodrigo 1 sibling, 1 reply; 7+ messages in thread From: Marius Vlad @ 2016-04-19 14:13 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: Intel Graphics Development, baker.dylan.c, rodrigo.vivi [-- Attachment #1.1: Type: text/plain, Size: 1459 bytes --] There was some discussions about this before: https://lists.freedesktop.org/archives/intel-gfx/2016-March/089128.html and https://lists.freedesktop.org/archives/intel-gfx/2016-March/090302.html There's some concern that his approach might brake with older versions of piglit. Is this still the case, or we can push this? On Tue, Apr 19, 2016 at 03:31:12PM +0200, Maarten Lankhorst wrote: > Right now scripts/run-tests.sh fails with the following error message: > > Fatal Error: Cannot overwrite existing folder without the -o/--overwrite option being set. > > Fix this by adding -o as required. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > --- > diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh > index 99e6124f5279..f33b0ffd342a 100755 > --- a/scripts/run-tests.sh > +++ b/scripts/run-tests.sh > @@ -125,7 +125,7 @@ if [ "x$RESUME" != "x" ]; then > sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume "$RESULTS" $NORETRY > else > mkdir -p "$RESULTS" > - sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER > + sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt "$RESULTS" -o -s $VERBOSE $EXCLUDE $FILTER > fi > > if [ "$SUMMARY" == "html" ]; then > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates. 2016-04-19 14:13 ` Marius Vlad @ 2016-04-19 14:23 ` Vivi, Rodrigo 2016-04-19 18:16 ` Dylan Baker 0 siblings, 1 reply; 7+ messages in thread From: Vivi, Rodrigo @ 2016-04-19 14:23 UTC (permalink / raw) To: Vlad, Marius C, maarten.lankhorst@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, baker.dylan.c@gmail.com Well, I don't see how to do it in a good and safe way for the old versions that didn't have the version check, so or we do an ugly version of it or we just ask people to upgrade the piglit when they start to report this commit is breaking stuff. Really up to you. But I believe we need on solution or another so if you decide to go with this patch feel free to use: Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> On Tue, 2016-04-19 at 17:13 +0300, Marius Vlad wrote: > There was some discussions about this before: > > https://lists.freedesktop.org/archives/intel-gfx/2016-March/089128.ht > ml > and > https://lists.freedesktop.org/archives/intel-gfx/2016-March/090302.ht > ml > > There's some concern that his approach might brake with older > versions > of piglit. Is this still the case, or we can push this? > > On Tue, Apr 19, 2016 at 03:31:12PM +0200, Maarten Lankhorst wrote: > > Right now scripts/run-tests.sh fails with the following error > > message: > > > > Fatal Error: Cannot overwrite existing folder without the -o/- > > -overwrite option being set. > > > > Fix this by adding -o as required. > > > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com > > > > > --- > > diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh > > index 99e6124f5279..f33b0ffd342a 100755 > > --- a/scripts/run-tests.sh > > +++ b/scripts/run-tests.sh > > @@ -125,7 +125,7 @@ if [ "x$RESUME" != "x" ]; then > > sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume > > "$RESULTS" $NORETRY > > else > > mkdir -p "$RESULTS" > > - sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt > > "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER > > + sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt > > "$RESULTS" -o -s $VERBOSE $EXCLUDE $FILTER > > fi > > > > if [ "$SUMMARY" == "html" ]; then > > > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates. 2016-04-19 14:23 ` Vivi, Rodrigo @ 2016-04-19 18:16 ` Dylan Baker 0 siblings, 0 replies; 7+ messages in thread From: Dylan Baker @ 2016-04-19 18:16 UTC (permalink / raw) To: Vivi, Rodrigo, Vlad, Marius C, maarten.lankhorst@linux.intel.com Cc: intel-gfx@lists.freedesktop.org [-- Attachment #1.1: Type: text/plain, Size: 2458 bytes --] Quoting Vivi, Rodrigo (2016-04-19 07:23:02) > Well, I don't see how to do it in a good and safe way for the old > versions that didn't have the version check, so or we do an ugly > version of it or we just ask people to upgrade the piglit when they > start to report this commit is breaking stuff. > > Really up to you. But I believe we need on solution or another so if > you decide to go with this patch feel free to use: > > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > On Tue, 2016-04-19 at 17:13 +0300, Marius Vlad wrote: > > There was some discussions about this before: > > > > https://lists.freedesktop.org/archives/intel-gfx/2016-March/089128.ht > > ml > > and > > https://lists.freedesktop.org/archives/intel-gfx/2016-March/090302.ht > > ml > > > > There's some concern that his approach might brake with older > > versions > > of piglit. Is this still the case, or we can push this? > > > > On Tue, Apr 19, 2016 at 03:31:12PM +0200, Maarten Lankhorst wrote: > > > Right now scripts/run-tests.sh fails with the following error > > > message: > > > > > > Fatal Error: Cannot overwrite existing folder without the -o/- > > > -overwrite option being set. > > > > > > Fix this by adding -o as required. > > > > > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com > > > > > > > --- > > > diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh > > > index 99e6124f5279..f33b0ffd342a 100755 > > > --- a/scripts/run-tests.sh > > > +++ b/scripts/run-tests.sh > > > @@ -125,7 +125,7 @@ if [ "x$RESUME" != "x" ]; then > > > sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" resume > > > "$RESULTS" $NORETRY > > > else > > > mkdir -p "$RESULTS" > > > - sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt > > > "$RESULTS" -s $VERBOSE $EXCLUDE $FILTER > > > + sudo IGT_TEST_ROOT="$IGT_TEST_ROOT" "$PIGLIT" run igt > > > "$RESULTS" -o -s $VERBOSE $EXCLUDE $FILTER > > > fi > > > > > > if [ "$SUMMARY" == "html" ]; then > > > > > > > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx I think removing the mkdir call will fix piglit before the -o and after the -o switch. But if you're willing to ask people to upgrade piglit using the -o will be more robust. Acked-by: Dylan Baker <dylanx.c.baker@intel.com> [-- Attachment #1.2: signature --] [-- Type: application/pgp-signature, Size: 473 bytes --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJXFnX8AAoJEAieFpYUBojveb4H/A8ed/j447g/riLxhS5mXbtr lPpR6kfrEg2Ojz7s6xoOvuOOeVQwCDU7jqhQew16+6uGUli4rCgEWuMST4GHqesS CHRodin6Pj7LwXhhH3ilyWd6upQJZadcRhvhPTsz/8UTych/Ml//OPpd9TrxKqQJ 7Dn8BcguQsU21E0Z/BQOSNjDob6QlGSHJllOX1Bsmash6Laeq0mKXTA4e/OSTMWf K26PV7NOLgWVzB4pInPmN27jd3npADyS2sQAl0wqWrs38x83sl2YqFqoNFs8XwHH ry1PZgZHofoTjjvPq/lhYWYN881MC70Zy8Tgsl+9KQQYSFN+YQM7LSy+C9HXkdg= =fPgS -----END PGP SIGNATURE----- [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-04-19 18:14 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-04-19 13:31 [PATCH i-g-t] scripts/run_tests.sh: Fix breakage after piglit updates Maarten Lankhorst 2016-04-19 13:38 ` Ville Syrjälä 2016-04-19 13:40 ` Maarten Lankhorst 2016-04-19 13:50 ` Ville Syrjälä 2016-04-19 14:13 ` Marius Vlad 2016-04-19 14:23 ` Vivi, Rodrigo 2016-04-19 18:16 ` Dylan Baker
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.