All of lore.kernel.org
 help / color / mirror / Atom feed
From: van.freenix@gmail.com (Peng Fan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock
Date: Thu, 21 Apr 2016 01:26:17 +0800	[thread overview]
Message-ID: <1461173177-11930-3-git-send-email-van.freenix@gmail.com> (raw)
In-Reply-To: <1461173177-11930-1-git-send-email-van.freenix@gmail.com>

Before access ocotp nvmem area, the clock should be enabled.
Or, `hexdump nvmem` will hang the system. So, use such flow:
"
  1. clock_enable_prepare
  2. read nvmem ocotp area
  3. clock_disable_unprepare
"

Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Shawn Guo <shawnguo@kernel.org>
---

V2:
 Follow Fabio's comments, check return value of clk_prepare_enable

 drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
index d7796eb..3f1dd9f 100644
--- a/drivers/nvmem/imx-ocotp.c
+++ b/drivers/nvmem/imx-ocotp.c
@@ -15,6 +15,7 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
+#include <linux/clk.h>
 #include <linux/device.h>
 #include <linux/io.h>
 #include <linux/module.h>
@@ -27,6 +28,7 @@
 
 struct ocotp_priv {
 	struct device *dev;
+	struct clk *clk;
 	void __iomem *base;
 	unsigned int nregs;
 };
@@ -37,7 +39,7 @@ static int imx_ocotp_read(void *context, const void *reg, size_t reg_size,
 	struct ocotp_priv *priv = context;
 	unsigned int offset = *(u32 *)reg;
 	unsigned int count;
-	int i;
+	int i, ret;
 	u32 index;
 
 	index = offset >> 2;
@@ -46,11 +48,19 @@ static int imx_ocotp_read(void *context, const void *reg, size_t reg_size,
 	if (count > (priv->nregs - index))
 		count = priv->nregs - index;
 
+	ret = clk_prepare_enable(priv->clk);
+	if (ret < 0) {
+		dev_err(priv->dev, "failed to prepare/enable ocotp clk\n");
+		return ret;
+	}
+
 	for (i = index; i < (index + count); i++) {
 		*(u32 *)val = readl(priv->base + 0x400 + i * 0x10);
 		val += 4;
 	}
 
+	clk_disable_unprepare(priv->clk);
+
 	return 0;
 }
 
@@ -112,6 +122,10 @@ static int imx_ocotp_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
 
+	priv->clk = devm_clk_get(&pdev->dev, NULL);
+	if (IS_ERR(priv->clk))
+		return PTR_ERR(priv->clk);
+
 	of_id = of_match_device(imx_ocotp_dt_ids, dev);
 	priv->nregs = (unsigned int)of_id->data;
 	imx_ocotp_regmap_config.max_register = 4 * priv->nregs - 4;
-- 
2.6.6

WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <van.freenix@gmail.com>
To: shawnguo@kernel.org, srinivas.kandagatla@linaro.org,
	maxime.ripard@free-electrons.com
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, van.freenix@gmail.com
Subject: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock
Date: Thu, 21 Apr 2016 01:26:17 +0800	[thread overview]
Message-ID: <1461173177-11930-3-git-send-email-van.freenix@gmail.com> (raw)
In-Reply-To: <1461173177-11930-1-git-send-email-van.freenix@gmail.com>

Before access ocotp nvmem area, the clock should be enabled.
Or, `hexdump nvmem` will hang the system. So, use such flow:
"
  1. clock_enable_prepare
  2. read nvmem ocotp area
  3. clock_disable_unprepare
"

Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Shawn Guo <shawnguo@kernel.org>
---

V2:
 Follow Fabio's comments, check return value of clk_prepare_enable

 drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
index d7796eb..3f1dd9f 100644
--- a/drivers/nvmem/imx-ocotp.c
+++ b/drivers/nvmem/imx-ocotp.c
@@ -15,6 +15,7 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
+#include <linux/clk.h>
 #include <linux/device.h>
 #include <linux/io.h>
 #include <linux/module.h>
@@ -27,6 +28,7 @@
 
 struct ocotp_priv {
 	struct device *dev;
+	struct clk *clk;
 	void __iomem *base;
 	unsigned int nregs;
 };
@@ -37,7 +39,7 @@ static int imx_ocotp_read(void *context, const void *reg, size_t reg_size,
 	struct ocotp_priv *priv = context;
 	unsigned int offset = *(u32 *)reg;
 	unsigned int count;
-	int i;
+	int i, ret;
 	u32 index;
 
 	index = offset >> 2;
@@ -46,11 +48,19 @@ static int imx_ocotp_read(void *context, const void *reg, size_t reg_size,
 	if (count > (priv->nregs - index))
 		count = priv->nregs - index;
 
+	ret = clk_prepare_enable(priv->clk);
+	if (ret < 0) {
+		dev_err(priv->dev, "failed to prepare/enable ocotp clk\n");
+		return ret;
+	}
+
 	for (i = index; i < (index + count); i++) {
 		*(u32 *)val = readl(priv->base + 0x400 + i * 0x10);
 		val += 4;
 	}
 
+	clk_disable_unprepare(priv->clk);
+
 	return 0;
 }
 
@@ -112,6 +122,10 @@ static int imx_ocotp_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
 
+	priv->clk = devm_clk_get(&pdev->dev, NULL);
+	if (IS_ERR(priv->clk))
+		return PTR_ERR(priv->clk);
+
 	of_id = of_match_device(imx_ocotp_dt_ids, dev);
 	priv->nregs = (unsigned int)of_id->data;
 	imx_ocotp_regmap_config.max_register = 4 * priv->nregs - 4;
-- 
2.6.6

  parent reply	other threads:[~2016-04-20 17:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 17:26 [PATCH V2 1/3] arm: dts: imx6qdl: add clocks property for ocotp node Peng Fan
2016-04-20 17:26 ` Peng Fan
2016-04-20 17:26 ` [PATCH V2 2/3] arm: dts: imx6sl: " Peng Fan
2016-04-20 17:26   ` Peng Fan
2016-04-20 17:26 ` Peng Fan [this message]
2016-04-20 17:26   ` [PATCH V2 3/3] nvmem: imx-ocotp: handling clock Peng Fan
2016-05-09 12:20   ` Peng Fan
2016-05-09 12:20     ` Peng Fan
2016-05-09 12:20     ` Peng Fan
2016-05-09 12:28   ` Srinivas Kandagatla
2016-05-09 12:28     ` Srinivas Kandagatla
2016-05-09 12:28     ` Srinivas Kandagatla
2016-05-09 12:41     ` Peng Fan
2016-05-09 12:41       ` Peng Fan
2016-05-10 10:31       ` Srinivas Kandagatla
2016-05-10 10:31         ` Srinivas Kandagatla
2016-05-10 10:31         ` Srinivas Kandagatla
2016-05-10 12:04         ` Peng Fan
2016-05-10 12:04           ` Peng Fan
2016-05-10 12:04           ` Peng Fan
2016-06-06  8:07 ` [PATCH V2 1/3] arm: dts: imx6qdl: add clocks property for ocotp node Shawn Guo
2016-06-06  8:07   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461173177-11930-3-git-send-email-van.freenix@gmail.com \
    --to=van.freenix@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.