From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jisheng Zhang <jszhang@marvell.com>,
jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
wsa@the-dreams.de
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable and prepare
Date: Thu, 21 Apr 2016 14:03:34 +0300 [thread overview]
Message-ID: <1461236614.6620.312.camel@linux.intel.com> (raw)
In-Reply-To: <1461230811-7495-1-git-send-email-jszhang@marvell.com>
On Thu, 2016-04-21 at 17:26 +0800, Jisheng Zhang wrote:
> If i2c_dw_probe() fail, we should disable and unprepare the clk,
clk -> clock, or use function name explicitly.
> otherwise the clk enable and prepare is left unbalanced.
>
Ditto.
> In dw_i2c_plat_remove(), we'd better to not rely on rpm to disable
> and unprepare the clk since CONFIG_PM may be disabled when configuring
Ditto.
> the kernel. So we explicitly disable and unprepare the clk in
Ditto.
> dw_i2c_plat_remove().
> + pm_runtime_put_noidle(&pdev->dev);
>
> - pm_runtime_put_sync(&pdev->dev);
>
This change also needs to be described in the commit message.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable and prepare
Date: Thu, 21 Apr 2016 14:03:34 +0300 [thread overview]
Message-ID: <1461236614.6620.312.camel@linux.intel.com> (raw)
In-Reply-To: <1461230811-7495-1-git-send-email-jszhang@marvell.com>
On Thu, 2016-04-21 at 17:26 +0800, Jisheng Zhang wrote:
> If i2c_dw_probe() fail, we should disable and unprepare the clk,
clk -> clock, or use function name explicitly.
> otherwise the clk enable and prepare is left unbalanced.
>
Ditto.
> In dw_i2c_plat_remove(), we'd better to not rely on rpm to disable
> and unprepare the clk since CONFIG_PM may be disabled when configuring
Ditto.
> the kernel. So we explicitly disable and unprepare the clk in
Ditto.
> dw_i2c_plat_remove().
> + pm_runtime_put_noidle(&pdev->dev);
> ?
> - pm_runtime_put_sync(&pdev->dev);
>
This change also needs to be described in the commit message.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-04-21 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 9:26 [PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable and prepare Jisheng Zhang
2016-04-21 9:26 ` Jisheng Zhang
2016-04-21 9:26 ` Jisheng Zhang
2016-04-21 11:03 ` Andy Shevchenko [this message]
2016-04-21 11:03 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461236614.6620.312.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.