[PATCH] drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request

[PATCH] drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request

[Imre Deak]

In commit 5f304c873634 ("drm/i915/kbl: Reset secondary power well requests
left on by DMC/KVMR") I forgot about the fact that SKL==KBL most of the
time and that a secondary MISC IO power well request left on by the DMC is
"expected". Tune down the corresponding WARN to be a debug message. This
was caught by CI suspend tests.

CC: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 0ed3ec8..56df7ff 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -635,7 +635,8 @@ gen9_sanitize_power_well_requests(struct drm_i915_private *dev_priv,
 	 * other request bits to be set, so WARN for those.
 	 */
 	if (power_well_id == SKL_DISP_PW_1 ||
-	    (IS_SKYLAKE(dev_priv) && power_well_id == SKL_DISP_PW_MISC_IO))
+	    ((IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) &&
+	     power_well_id == SKL_DISP_PW_MISC_IO))
 		DRM_DEBUG_DRIVER("Clearing auxiliary requests for %s forced on "
 				 "by DMC\n", power_well->name);
 	else
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request

[Patchwork]

== Series Details ==

Series: drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request
URL   : https://patchwork.freedesktop.org/series/5917/
State : failure

== Summary ==

Series 5917v1 drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request
http://patchwork.freedesktop.org/api/1.0/series/5917/revisions/1/mbox/

Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                pass       -> DMESG-WARN (skl-i7k-2)
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (hsw-brixbox)
                pass       -> FAIL       (byt-nuc)
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-a-frame-sequence:
                fail       -> PASS       (ivb-t430s)

bdw-nuci7        total:192  pass:180  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:127  pass:105  dwarn:0   dfail:0   fail:0   skip:22 
byt-nuc          total:191  pass:152  dwarn:0   dfail:0   fail:1   skip:38 
hsw-brixbox      total:192  pass:167  dwarn:0   dfail:0   fail:1   skip:24 
hsw-gt2          total:192  pass:173  dwarn:0   dfail:0   fail:0   skip:19 
ivb-t430s        total:192  pass:164  dwarn:0   dfail:0   fail:0   skip:28 
skl-i7k-2        total:192  pass:166  dwarn:1   dfail:0   fail:0   skip:25 
skl-nuci5        total:192  pass:181  dwarn:0   dfail:0   fail:0   skip:11 
snb-dellxps      total:192  pass:154  dwarn:0   dfail:0   fail:0   skip:38 
snb-x220t        total:192  pass:154  dwarn:0   dfail:0   fail:1   skip:37 
BOOT FAILED for bsw-nuc-2

Results at /archive/results/CI_IGT_test/Patchwork_1938/

c438a31de88e7dc6bfe17ed0e094f9a1b08bcb94 drm-intel-nightly: 2016y-04m-19d-09h-36m-00s UTC integration manifest
a0ddc6e drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.BAT: failure for drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request

[Imre Deak]

On ti, 2016-04-19 at 10:56 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/kbl: Don't WARN for expected secondary MISC IO power
> well request
> URL   : https://patchwork.freedesktop.org/series/5917/
> State : failure
> 
> == Summary ==
> 
> Series 5917v1 drm/i915/kbl: Don't WARN for expected secondary MISC IO
> power well request
> http://patchwork.freedesktop.org/api/1.0/series/5917/revisions/1/mbox
> /
> 
> Test kms_flip:
>         Subgroup basic-flip-vs-modeset:
>                 pass       -> DMESG-WARN (skl-i7k-2)

Pre-existing issue: set CRTC IOCTL->intel_atomic_commit() followed by
vlank wait timeout and "Removing stuck page" WARN:
https://bugs.freedesktop.org/show_bug.cgi?id=94572

>         Subgroup basic-flip-vs-wf_vblank:
>                 pass       -> FAIL       (hsw-brixbox)

Pre-existing:
(kms_flip:6669) CRITICAL: Test assertion failure function check_state, file kms_flip.c:692:
(kms_flip:6669) CRITICAL: Failed assertion: fabs((((double) diff.tv_usec) - usec_interflip) / usec_interflip) <= 0.005
(kms_flip:6669) CRITICAL: Last errno: 25, Inappropriate ioctl for device
(kms_flip:6669) CRITICAL: inter-vblank ts jitter: 0s, 183345usec

>                 pass       -> FAIL       (byt-nuc)

Pre-existing:
(kms_flip:7293) CRITICAL: Test assertion failure function check_state, file kms_flip.c:692:
(kms_flip:7293) CRITICAL: Failed assertion: fabs((((double) diff.tv_usec) - usec_interflip) / usec_interflip) <= 0.005
(kms_flip:7293) CRITICAL: Last errno: 25, Inappropriate ioctl for device
(kms_flip:7293) CRITICAL: inter-vblank ts jitter: 0s, 183237usec
Subtest basic-flip-vs-wf_vblank failed.

> Test kms_pipe_crc_basic:
>         Subgroup read-crc-pipe-a-frame-sequence:
>                 fail       -> PASS       (ivb-t430s)
> 
> bdw-
> nuci7        total:192  pass:180  dwarn:0   dfail:0   fail:0   skip:1
> 2 
> bdw-
> ultra        total:127  pass:105  dwarn:0   dfail:0   fail:0   skip:2
> 2 
> byt-
> nuc          total:191  pass:152  dwarn:0   dfail:0   fail:1   skip:3
> 8 
> hsw-
> brixbox      total:192  pass:167  dwarn:0   dfail:0   fail:1   skip:2
> 4 
> hsw-
> gt2          total:192  pass:173  dwarn:0   dfail:0   fail:0   skip:1
> 9 
> ivb-
> t430s        total:192  pass:164  dwarn:0   dfail:0   fail:0   skip:2
> 8 
> skl-i7k-
> 2        total:192  pass:166  dwarn:1   dfail:0   fail:0   skip:25 
> skl-
> nuci5        total:192  pass:181  dwarn:0   dfail:0   fail:0   skip:1
> 1 
> snb-
> dellxps      total:192  pass:154  dwarn:0   dfail:0   fail:0   skip:3
> 8 
> snb-
> x220t        total:192  pass:154  dwarn:0   dfail:0   fail:1   skip:3
> 7 
> BOOT FAILED for bsw-nuc-2
> 
> Results at /archive/results/CI_IGT_test/Patchwork_1938/
> 
> c438a31de88e7dc6bfe17ed0e094f9a1b08bcb94 drm-intel-nightly: 2016y-
> 04m-19d-09h-36m-00s UTC integration manifest
> a0ddc6e drm/i915/kbl: Don't WARN for expected secondary MISC IO power
> well request
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request

[Patrik Jakobsson]

On Tue, Apr 19, 2016 at 01:00:36PM +0300, Imre Deak wrote:
> In commit 5f304c873634 ("drm/i915/kbl: Reset secondary power well requests
> left on by DMC/KVMR") I forgot about the fact that SKL==KBL most of the
> time and that a secondary MISC IO power well request left on by the DMC is
> "expected". Tune down the corresponding WARN to be a debug message. This
> was caught by CI suspend tests.
> 
> CC: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Was just about to bug you about this. You're one step ahead of me :)

Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 0ed3ec8..56df7ff 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -635,7 +635,8 @@ gen9_sanitize_power_well_requests(struct drm_i915_private *dev_priv,
>  	 * other request bits to be set, so WARN for those.
>  	 */
>  	if (power_well_id == SKL_DISP_PW_1 ||
> -	    (IS_SKYLAKE(dev_priv) && power_well_id == SKL_DISP_PW_MISC_IO))
> +	    ((IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) &&
> +	     power_well_id == SKL_DISP_PW_MISC_IO))
>  		DRM_DEBUG_DRIVER("Clearing auxiliary requests for %s forced on "
>  				 "by DMC\n", power_well->name);
>  	else
> -- 
> 2.5.0
> 

-- 
Intel Sweden AB Registered Office: Knarrarnasgatan 15, 164 40 Kista, Stockholm, Sweden Registration Number: 556189-6027 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/kbl: Don't WARN for expected secondary MISC IO power well request

[Imre Deak]

On to, 2016-04-21 at 10:12 +0200, Patrik Jakobsson wrote:
> On Tue, Apr 19, 2016 at 01:00:36PM +0300, Imre Deak wrote:
> > In commit 5f304c873634 ("drm/i915/kbl: Reset secondary power well
> > requests
> > left on by DMC/KVMR") I forgot about the fact that SKL==KBL most of
> > the
> > time and that a secondary MISC IO power well request left on by the
> > DMC is
> > "expected". Tune down the corresponding WARN to be a debug message.
> > This
> > was caught by CI suspend tests.
> > 
> > CC: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> Was just about to bug you about this. You're one step ahead of me :)
> 
> Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>

Thanks for the review, I pushed it to -dinq.

Yes, CI caught it for me. It would've been a clear case of reject for
the SKL patch, but KBL errors don't show up in PW/CI results yet, I
guess because it's still preliminary HW.

--Imre

> > ---
> >  drivers/gpu/drm/i915/intel_runtime_pm.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > index 0ed3ec8..56df7ff 100644
> > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > @@ -635,7 +635,8 @@ gen9_sanitize_power_well_requests(struct
> > drm_i915_private *dev_priv,
> >  	 * other request bits to be set, so WARN for those.
> >  	 */
> >  	if (power_well_id == SKL_DISP_PW_1 ||
> > -	    (IS_SKYLAKE(dev_priv) && power_well_id ==
> > SKL_DISP_PW_MISC_IO))
> > +	    ((IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) &&
> > +	     power_well_id == SKL_DISP_PW_MISC_IO))
> >  		DRM_DEBUG_DRIVER("Clearing auxiliary requests for
> > %s forced on "
> >  				 "by DMC\n", power_well->name);
> >  	else
> > -- 
> > 2.5.0
> > 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx