All of lore.kernel.org
 help / color / mirror / Atom feed
From: mlin@kernel.org (Ming Lin)
Subject: [PATCH v2 RFC] nvme: improve performance for virtual NVMe devices
Date: Thu, 21 Apr 2016 11:11:35 -0700	[thread overview]
Message-ID: <1461262295.4797.11.camel@ssi> (raw)
In-Reply-To: <20160421133823.GA13563@infradead.org>

On Thu, 2016-04-21@06:38 -0700, Christoph Hellwig wrote:
> I've not spent much time at it due to a busy conference week, but there
> are two main comments on why I don't think this is suitable as is
> despite really liking the general idea.
> 
>  - I'd really like this to be proposed as an official extension to the
>    NVMe technical workgroup.  I'm also happy to help with making that
>    happen.  I really don't like to merge it until we have some basic

That'd be great help. Thanks.

>    agreement on it, although once the basic agreement is there it
>    shouldn't be too hard to also support the older google specific
>    version.  And this is no new feedback, a couple of people including
>    me said that a long time ago, and we've seen zero action on it.

For "action", did you mean the "agreement" or the spec extension
proposal?

I think you'll make the proposal, right?

>  - the code is a mess in this version.  I really don't see the need for
>    all the ifdefs, but if you really want to keep them they should move
>    out of the main code path and just stub out helpers that would
>    otherwise do work.

I made the mess :)

I thought this before.
Probably add a new file ext.c and move these code into it.

Then add a nvme_ext_ops ...

  reply	other threads:[~2016-04-21 18:11 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 18:04 [PATCH v2 RFC] nvme: improve performance for virtual NVMe devices Helen Mae Koike Fornazier
2016-04-21 13:33 ` Helen Koike
2016-04-21 13:38   ` Christoph Hellwig
2016-04-21 18:11     ` Ming Lin [this message]
2016-04-27 15:26       ` Helen Koike
2016-05-03  8:05       ` Christoph Hellwig
2016-05-04 16:48         ` Helen Koike
2016-05-05 14:17           ` Christoph Hellwig
2016-05-11 16:50     ` Helen Koike
2016-05-11 17:43       ` Keith Busch
2016-05-12  4:05         ` Helen Koike
2016-05-12  7:05           ` Christoph Hellwig
     [not found]             ` <CALu-fzt8=kmzZDqKsRYE42Q+F+Zu3U_s6XErpd9izXdxG1cUMA@mail.gmail.com>
     [not found]               ` <CAPst7KAAymUqbNwzxNAczduF6iLXQAMm5-auEdXZ_zHwhHtbWQ@mail.gmail.com>
2016-05-12 17:29                 ` Mike Waychison
2016-05-05 15:15 ` Helen Koike
2016-05-05 15:24 ` Helen Koike
2016-08-16  1:41 ` [PATCH v3 RFC 0/2] Virtual NVMe device optimization Helen Koike
2016-08-16  1:41   ` Helen Koike
2016-08-16  1:41   ` [PATCH v3 RFC 1/2] PCI: Add Google device ID Helen Koike
2016-08-18 21:59     ` Bjorn Helgaas
2016-08-16  1:41   ` [PATCH v3 RFC 2/2] nvme: improve performance for virtual NVMe devices Helen Koike
2016-08-16  1:41     ` Helen Koike
2016-08-16 20:45     ` J Freyensee
2016-08-16 20:45       ` J Freyensee
2016-08-16 23:45       ` Keith Busch
2016-08-16 23:45         ` Keith Busch
2017-03-17 21:44     ` [PATCH v4 RFC] " Helen Koike
2017-03-17 22:28       ` Keith Busch
2017-03-17 22:26         ` Helen Koike
2017-03-24  4:23         ` [PATCH v5 " Helen Koike
2017-03-27  9:49           ` Christoph Hellwig
2017-03-27 16:04             ` Helen Koike
2017-03-27 16:25               ` Helen Koike
2017-03-27 14:43           ` Keith Busch
2017-03-27 16:50           ` [PATCH v6 " Helen Koike
2017-03-30 17:33             ` Keith Busch
2017-03-30 17:46               ` [PATCH v7 " Helen Koike
2017-03-31  7:01                 ` Christoph Hellwig
2017-04-01 21:50                   ` Helen Koike
2017-04-10 15:31                     ` Helen Koike
2017-04-10 15:37                     ` Christoph Hellwig
2017-04-10 15:51                   ` [PATCH v8] " Helen Koike
2017-04-14 18:10                     ` Helen Koike
2017-04-14 18:10                       ` Helen Koike
2017-04-17 23:01                       ` Keith Busch
2017-04-17 23:01                         ` Keith Busch
2017-04-17 23:20                         ` Helen Koike
2017-04-17 23:20                           ` Helen Koike
2017-04-20 10:22                         ` Sagi Grimberg
2017-04-20 10:22                           ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461262295.4797.11.camel@ssi \
    --to=mlin@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.