All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Kiarie <davidkiarie4@gmail.com>
To: qemu-devel@nongnu.org
Cc: valentine.sinitsyn@gmail.com, marcel@redhat.com, mst@redhat.com,
	jan.kizska@web.de, imammedo@redhat.com,
	David Kiarie <davidkiarie4@gmail.com>
Subject: [Qemu-devel] [V9 4/4] hw/pci-host: Emulate AMD IOMMU
Date: Mon, 25 Apr 2016 01:12:57 +0300	[thread overview]
Message-ID: <1461535977-331-5-git-send-email-davidkiarie4@gmail.com> (raw)
In-Reply-To: <1461535977-331-1-git-send-email-davidkiarie4@gmail.com>

Add AMD IOMMU emulation support to q35 chipset

Signed-off-by: David Kiarie <davidkiarie4@gmail.com>
---
 hw/pci-host/q35.c             | 21 +++++++++++++++++++--
 include/hw/i386/intel_iommu.h |  2 +-
 2 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index 70f897e..37f8a84 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -32,6 +32,7 @@
 #include "hw/pci-host/q35.h"
 #include "qapi/error.h"
 #include "qapi/visitor.h"
+#include "hw/i386/amd_iommu.h"
 
 /****************************************************************************
  * Q35 host
@@ -448,6 +449,19 @@ static void mch_init_dmar(MCHPCIState *mch)
     pci_setup_iommu(pci_bus, q35_host_dma_iommu, mch->iommu);
 }
 
+static void mch_init_amdvi(MCHPCIState *mch)
+{
+    AMDIOMMUState *iommu_state;
+    PCIBus *bus = PCI_BUS(qdev_get_parent_bus(DEVICE(mch)));
+    PCIDevice *iommu;
+
+    iommu = pci_create_simple(bus, 0x20, TYPE_AMD_IOMMU_DEVICE);
+
+    iommu_state = AMD_IOMMU_DEVICE(iommu);
+
+    pci_setup_iommu(bus, bridge_host_amd_iommu, iommu_state);
+}
+
 static void mch_realize(PCIDevice *d, Error **errp)
 {
     int i;
@@ -506,8 +520,11 @@ static void mch_realize(PCIDevice *d, Error **errp)
                  mch->pci_address_space, &mch->pam_regions[i+1],
                  PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE, PAM_EXPAN_SIZE);
     }
-    /* Intel IOMMU (VT-d) */
-    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
+
+    if (object_property_get_bool(qdev_get_machine(), "iommu", NULL) &&
+        MACHINE(qdev_get_machine())->x_iommu_type) {
+        mch_init_amdvi(mch);
+    } else if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
         mch_init_dmar(mch);
     }
 }
diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
index 7e511e1..539530c 100644
--- a/include/hw/i386/intel_iommu.h
+++ b/include/hw/i386/intel_iommu.h
@@ -24,10 +24,10 @@
 #include "hw/qdev.h"
 #include "sysemu/dma.h"
 
-#define INTEL_IOMMU_STR "intel"
 #define TYPE_INTEL_IOMMU_DEVICE "intel-iommu"
 #define INTEL_IOMMU_DEVICE(obj) \
      OBJECT_CHECK(IntelIOMMUState, (obj), TYPE_INTEL_IOMMU_DEVICE)
+#define INTEL_IOMMU_STR "intel"
 
 /* DMAR Hardware Unit Definition address (IOMMU unit) */
 #define Q35_HOST_BRIDGE_IOMMU_ADDR  0xfed90000ULL
-- 
2.1.4

  parent reply	other threads:[~2016-04-24 22:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24 22:12 [Qemu-devel] [V9 0/4] AMD IOMMU David Kiarie
2016-04-24 22:12 ` [Qemu-devel] [V9 1/4] hw/i386: Introduce " David Kiarie
2016-04-24 22:12 ` [Qemu-devel] [V9 2/4] hw/i386: ACPI table for " David Kiarie
2016-04-29  6:09   ` Jan Kiszka
2016-04-29  8:28     ` David Kiarie
2016-05-04  7:50       ` Valentine Sinitsyn
2016-05-04  7:45     ` Valentine Sinitsyn
2016-04-24 22:12 ` [Qemu-devel] [V9 3/4] hw/core: Add AMD IOMMU to machine properties David Kiarie
2016-04-25  3:00   ` Peter Xu
2016-04-24 22:12 ` David Kiarie [this message]
2016-04-25  3:06   ` [Qemu-devel] [V9 4/4] hw/pci-host: Emulate AMD IOMMU Peter Xu
2016-04-24 22:16 ` [Qemu-devel] [V9 0/4] " David Kiarie
2016-04-25  7:13   ` Jan Kiszka
2016-04-25 12:53 ` Marcel Apfelbaum
  -- strict thread matches above, loose matches on Subject: below --
2016-04-29 22:42 David Kiarie
     [not found] ` <1461969763-5193-5-git-send-email-davidkiarie4@gmail.com>
2016-05-01  9:15   ` [Qemu-devel] [V9 4/4] hw/pci-host: Emulate " Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461535977-331-5-git-send-email-davidkiarie4@gmail.com \
    --to=davidkiarie4@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kizska@web.de \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=valentine.sinitsyn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.