All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: David Kiarie <davidkiarie4@gmail.com>, qemu-devel@nongnu.org
Cc: valentine.sinitsyn@gmail.com, mst@redhat.com, jan.kizska@web.de,
	imammedo@redhat.com
Subject: Re: [Qemu-devel] [V9 0/4] AMD IOMMU
Date: Mon, 25 Apr 2016 15:53:31 +0300	[thread overview]
Message-ID: <571E134B.1090002@redhat.com> (raw)
In-Reply-To: <1461535977-331-1-git-send-email-davidkiarie4@gmail.com>

On 04/25/2016 01:12 AM, David Kiarie wrote:
> Hi all,
>
> The current AMD IOMMU patches that fixes Igor's comments. I got rid of structs and instead
> added individual integer fields into the table data directly, as suggested.
>
> I have also got rid of some un-used macros and fixed a few other miscellaneous things.

My comments for V8 still stand. I don't see them addressed in this version.
Thanks,
Marcel

>
> David Kiarie (4):
>    hw/i386: Introduce AMD IOMMU
>    hw/i386: ACPI table for AMD IOMMU
>    hw/core: Add AMD IOMMU to machine properties
>    hw/pci-host: Emulate AMD IOMMU
>
>   hw/acpi/aml-build.c           |    2 +-
>   hw/acpi/core.c                |   13 -
>   hw/core/machine.c             |   32 +-
>   hw/i386/Makefile.objs         |    1 +
>   hw/i386/acpi-build.c          |  101 ++-
>   hw/i386/amd_iommu.c           | 1426 +++++++++++++++++++++++++++++++++++++++++
>   hw/i386/amd_iommu.h           |  398 ++++++++++++
>   hw/pci-host/q35.c             |   21 +-
>   include/hw/acpi/acpi-defs.h   |   14 +
>   include/hw/acpi/acpi.h        |   16 +
>   include/hw/acpi/aml-build.h   |    1 +
>   include/hw/boards.h           |    1 +
>   include/hw/i386/intel_iommu.h |    1 +
>   include/hw/pci/pci.h          |    2 +
>   qemu-options.hx               |    7 +-
>   util/qemu-config.c            |    8 +-
>   16 files changed, 2010 insertions(+), 34 deletions(-)
>   create mode 100644 hw/i386/amd_iommu.c
>   create mode 100644 hw/i386/amd_iommu.h
>

  parent reply	other threads:[~2016-04-25 12:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24 22:12 [Qemu-devel] [V9 0/4] AMD IOMMU David Kiarie
2016-04-24 22:12 ` [Qemu-devel] [V9 1/4] hw/i386: Introduce " David Kiarie
2016-04-24 22:12 ` [Qemu-devel] [V9 2/4] hw/i386: ACPI table for " David Kiarie
2016-04-29  6:09   ` Jan Kiszka
2016-04-29  8:28     ` David Kiarie
2016-05-04  7:50       ` Valentine Sinitsyn
2016-05-04  7:45     ` Valentine Sinitsyn
2016-04-24 22:12 ` [Qemu-devel] [V9 3/4] hw/core: Add AMD IOMMU to machine properties David Kiarie
2016-04-25  3:00   ` Peter Xu
2016-04-24 22:12 ` [Qemu-devel] [V9 4/4] hw/pci-host: Emulate AMD IOMMU David Kiarie
2016-04-25  3:06   ` Peter Xu
2016-04-24 22:16 ` [Qemu-devel] [V9 0/4] " David Kiarie
2016-04-25  7:13   ` Jan Kiszka
2016-04-25 12:53 ` Marcel Apfelbaum [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-04-29 22:42 David Kiarie
2016-05-01 13:47 ` Michael S. Tsirkin
2016-05-01 14:00   ` Michael S. Tsirkin
2016-05-02  8:33     ` David Kiarie
2016-05-04  6:12 ` Jan Kiszka
2016-05-04  7:05   ` David Kiarie
2016-05-04  7:26     ` Jan Kiszka
2016-05-04  7:39     ` Valentine Sinitsyn
2016-05-04 10:51       ` David Kiarie
2016-05-04 10:58         ` Valentine Sinitsyn
2016-05-04 11:02           ` David Kiarie
2016-05-04 11:05             ` Valentine Sinitsyn
2016-05-05 14:20               ` David Kiarie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571E134B.1090002@redhat.com \
    --to=marcel@redhat.com \
    --cc=davidkiarie4@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kizska@web.de \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=valentine.sinitsyn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.