From: slemieux.tyco@gmail.com (Sylvain Lemieux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] ARM: dts: lpc32xx: ea3250: add NAND partitions device node
Date: Tue, 26 Apr 2016 12:58:45 -0400 [thread overview]
Message-ID: <1461689925.9433.14.camel@localhost> (raw)
In-Reply-To: <1461631050-10479-3-git-send-email-vz@mleia.com>
Hi Vladimir,
On Tue, 2016-04-26 at 03:37 +0300, Vladimir Zapolskiy wrote:
> To declare MTD OF partitions NAND controller device node should have
> a special 'partitions' subnode, the change removes a debug message
> from mtd/ofpart on boot:
>
> nxp_lpc3220_slc: 'partitions' subnode not found on /ahb/flash at 20020000.
> Trying to parse direct subnodes as partitions.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
> arch/arm/boot/dts/ea3250.dts | 41 ++++++++++++++++++++++-------------------
> 1 file changed, 22 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ea3250.dts b/arch/arm/boot/dts/ea3250.dts
> index 7cf815a..58bcda9 100644
> --- a/arch/arm/boot/dts/ea3250.dts
> +++ b/arch/arm/boot/dts/ea3250.dts
> @@ -213,8 +213,6 @@
>
> /* 128MB Flash via SLC NAND controller */
> &slc {
> - #address-cells = <1>;
> - #size-cells = <1>;
> status = "okay";
>
> nxp,wdr-clks = <14>;
> @@ -228,26 +226,31 @@
> nand-on-flash-bbt;
> gpios = <&gpio 5 19 1>; /* GPO_P3 19, active low */
>
> - mtd0 at 00000000 {
> - label = "ea3250-boot";
> - reg = <0x00000000 0x00080000>;
> - read-only;
> - };
> + partitions {
You may want to add the compatible property to the partitions here:
+ compatible = "fixed-partitions";
Refer to commit e488ca9f8d4f62c2dc36bfa5c32f68e7f05ab381 for details.
This suggestion is also valid for patch #6.
Note:
This change was required to use the "partitions" subnode
on my custom LPC3250 board definition.
> + #address-cells = <1>;
> + #size-cells = <1>;
>
...
Sylvain
WARNING: multiple messages have this Message-ID (diff)
From: Sylvain Lemieux <slemieux.tyco-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Roland Stigge <stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/7] ARM: dts: lpc32xx: ea3250: add NAND partitions device node
Date: Tue, 26 Apr 2016 12:58:45 -0400 [thread overview]
Message-ID: <1461689925.9433.14.camel@localhost> (raw)
In-Reply-To: <1461631050-10479-3-git-send-email-vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
Hi Vladimir,
On Tue, 2016-04-26 at 03:37 +0300, Vladimir Zapolskiy wrote:
> To declare MTD OF partitions NAND controller device node should have
> a special 'partitions' subnode, the change removes a debug message
> from mtd/ofpart on boot:
>
> nxp_lpc3220_slc: 'partitions' subnode not found on /ahb/flash@20020000.
> Trying to parse direct subnodes as partitions.
>
> Signed-off-by: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm/boot/dts/ea3250.dts | 41 ++++++++++++++++++++++-------------------
> 1 file changed, 22 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ea3250.dts b/arch/arm/boot/dts/ea3250.dts
> index 7cf815a..58bcda9 100644
> --- a/arch/arm/boot/dts/ea3250.dts
> +++ b/arch/arm/boot/dts/ea3250.dts
> @@ -213,8 +213,6 @@
>
> /* 128MB Flash via SLC NAND controller */
> &slc {
> - #address-cells = <1>;
> - #size-cells = <1>;
> status = "okay";
>
> nxp,wdr-clks = <14>;
> @@ -228,26 +226,31 @@
> nand-on-flash-bbt;
> gpios = <&gpio 5 19 1>; /* GPO_P3 19, active low */
>
> - mtd0@00000000 {
> - label = "ea3250-boot";
> - reg = <0x00000000 0x00080000>;
> - read-only;
> - };
> + partitions {
You may want to add the compatible property to the partitions here:
+ compatible = "fixed-partitions";
Refer to commit e488ca9f8d4f62c2dc36bfa5c32f68e7f05ab381 for details.
This suggestion is also valid for patch #6.
Note:
This change was required to use the "partitions" subnode
on my custom LPC3250 board definition.
> + #address-cells = <1>;
> + #size-cells = <1>;
>
...
Sylvain
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-26 16:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 0:37 [PATCH 0/7] ARM: dts: lpc32xx: nonfunctional updates to ea3250 and phy3250 dts Vladimir Zapolskiy
2016-04-26 0:37 ` Vladimir Zapolskiy
2016-04-26 0:37 ` [PATCH 1/7] ARM: dts: lpc32xx: ea3250: avoid extension of device nodes by absolute path Vladimir Zapolskiy
2016-04-26 0:37 ` Vladimir Zapolskiy
2016-04-26 15:45 ` Sylvain Lemieux
2016-04-26 15:45 ` Sylvain Lemieux
2016-04-26 0:37 ` [PATCH 2/7] ARM: dts: lpc32xx: ea3250: add NAND partitions device node Vladimir Zapolskiy
2016-04-26 0:37 ` Vladimir Zapolskiy
2016-04-26 16:58 ` Sylvain Lemieux [this message]
2016-04-26 16:58 ` Sylvain Lemieux
2016-04-26 18:36 ` Vladimir Zapolskiy
2016-04-26 18:36 ` Vladimir Zapolskiy
2016-04-26 0:37 ` [PATCH 3/7] ARM: dts: lpc32xx: ea3250: fix Atmel at24 eeprom vendor Vladimir Zapolskiy
2016-04-26 0:37 ` Vladimir Zapolskiy
2016-04-26 15:41 ` Sylvain Lemieux
2016-04-26 15:41 ` Sylvain Lemieux
2016-04-26 0:37 ` [PATCH 4/7] ARM: dts: lpc32xx: ea3250: add SoC name prefix to board dts file Vladimir Zapolskiy
2016-04-26 0:37 ` Vladimir Zapolskiy
2016-04-26 15:36 ` Sylvain Lemieux
2016-04-26 15:36 ` Sylvain Lemieux
2016-04-26 0:37 ` [PATCH 5/7] ARM: dts: lpc32xx: phy3250: avoid extension of device nodes by absolute path Vladimir Zapolskiy
2016-04-26 0:37 ` Vladimir Zapolskiy
2016-04-26 15:46 ` Sylvain Lemieux
2016-04-26 15:46 ` Sylvain Lemieux
2016-04-26 0:37 ` [PATCH 6/7] ARM: dts: lpc32xx: phy3250: add NAND partitions device node Vladimir Zapolskiy
2016-04-26 0:37 ` Vladimir Zapolskiy
2016-04-26 0:37 ` [PATCH 7/7] ARM: dts: lpc32xx: phy3250: add SoC name prefix to board dts file Vladimir Zapolskiy
2016-04-26 0:37 ` Vladimir Zapolskiy
2016-04-26 15:37 ` Sylvain Lemieux
2016-04-26 15:37 ` Sylvain Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461689925.9433.14.camel@localhost \
--to=slemieux.tyco@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.