Re: [PATCH] nfit: fix format interface code byte order per ACPI6.1

From: Toshi Kani <toshi.kani@hpe.com>
To: Dan Williams <dan.j.williams@intel.com>,
	Linda Knippers <linda.knippers@hpe.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] nfit: fix format interface code byte order per ACPI6.1
Date: Fri, 29 Apr 2016 12:39:25 -0600	[thread overview]
Message-ID: <1461955165.27137.0.camel@hpe.com> (raw)
In-Reply-To: <CAPcyv4jUkr-h+Wor9Pda35CS17VAKC8pAm4xkO7A0eRQWUSd2A@mail.gmail.com>

On Fri, 2016-04-29 at 08:18 -0700, Dan Williams wrote:
> On Fri, Apr 29, 2016 at 6:53 AM, Linda Knippers <linda.knippers@hpe.com>
> wrote:
> > 
> > On 4/28/2016 10:11 PM, Dan Williams wrote:
> > > 
> > > ACPI6.1 clarifies that DCR fields are stored as an array of bytes,
> > > update the format interface code constants to match.
> > > 
> > > Cc: Toshi Kani <toshi.kani@hpe.com>
> > > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > > ---
> > >  drivers/acpi/nfit.h |   12 +++++++-----
> > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/drivers/acpi/nfit.h b/drivers/acpi/nfit.h
> > > index c75576b2d50e..92ea5d06c7fe 100644
> > > --- a/drivers/acpi/nfit.h
> > > +++ b/drivers/acpi/nfit.h
> > > @@ -41,11 +41,13 @@ enum nfit_uuids {
> > >       NFIT_UUID_MAX,
> > >  };
> > > 
> > > -enum nfit_fic {
> > > -     NFIT_FIC_BYTE = 0x101, /* byte-addressable energy backed */
> > > -     NFIT_FIC_BLK = 0x201, /* block-addressable non-energy backed */
> > > -     NFIT_FIC_BYTEN = 0x301, /* byte-addressable non-energy backed
> > > */
> > > -};
> > > +/*
> > > + * Region format interface codes are stored as an array of bytes in
> > > the
> > > + * NFIT DIMM Control Region structure
> > > + */
> > > +#define NFIT_FIC_BYTE cpu_to_be16(0x101) /* byte-addressable energy
> > > */
> > energy backed?
>
> Yup, will fix.

With that change:

Reviewed-by: Toshi Kani <toshi.kani@hpe.com>

Thanks,
-Toshi

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm