From: Linda Knippers <linda.knippers@hpe.com>
To: linux-nvdimm@lists.01.org
Subject: Re: [PATCH] nfit: fix format interface code byte order per ACPI6.1
Date: Fri, 29 Apr 2016 09:53:51 -0400 [thread overview]
Message-ID: <5723676F.9000006@hpe.com> (raw)
In-Reply-To: <146189587309.28821.2994135280775533869.stgit@dwillia2-desk3.amr.corp.intel.com>
On 4/28/2016 10:11 PM, Dan Williams wrote:
> ACPI6.1 clarifies that DCR fields are stored as an array of bytes,
> update the format interface code constants to match.
>
> Cc: Toshi Kani <toshi.kani@hpe.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/acpi/nfit.h | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/nfit.h b/drivers/acpi/nfit.h
> index c75576b2d50e..92ea5d06c7fe 100644
> --- a/drivers/acpi/nfit.h
> +++ b/drivers/acpi/nfit.h
> @@ -41,11 +41,13 @@ enum nfit_uuids {
> NFIT_UUID_MAX,
> };
>
> -enum nfit_fic {
> - NFIT_FIC_BYTE = 0x101, /* byte-addressable energy backed */
> - NFIT_FIC_BLK = 0x201, /* block-addressable non-energy backed */
> - NFIT_FIC_BYTEN = 0x301, /* byte-addressable non-energy backed */
> -};
> +/*
> + * Region format interface codes are stored as an array of bytes in the
> + * NFIT DIMM Control Region structure
> + */
> +#define NFIT_FIC_BYTE cpu_to_be16(0x101) /* byte-addressable energy */
energy backed?
> +#define NFIT_FIC_BLK cpu_to_be16(0x201) /* block-addressable non-energy backed */
> +#define NFIT_FIC_BYTEN cpu_to_be16(0x301) /* byte-addressable non-energy backed */
>
> enum {
> NFIT_BLK_READ_FLUSH = 1,
>
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2016-04-29 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 2:11 [PATCH] nfit: fix format interface code byte order per ACPI6.1 Dan Williams
2016-04-29 13:53 ` Linda Knippers [this message]
2016-04-29 15:18 ` Dan Williams
2016-04-29 18:39 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5723676F.9000006@hpe.com \
--to=linda.knippers@hpe.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.