From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Peter Hurley <peter@hurleysoftware.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Vinod Koul <vinod.koul@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dmaengine <dmaengine@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Puustinen, Ismo" <ismo.puustinen@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v3 09/11] serial: 8250_lpss: move Quark code from PCI driver
Date: Wed, 04 May 2016 14:20:35 +0300 [thread overview]
Message-ID: <1462360835.17131.224.camel@linux.intel.com> (raw)
In-Reply-To: <1462359696.27858.184.camel@nexus-software.ie>
On Wed, 2016-05-04 at 12:01 +0100, Bryan O'Donoghue wrote:
> On Wed, 2016-05-04 at 13:03 +0300, Andy Shevchenko wrote:
> >
> > On Wed, May 4, 2016 at 12:51 PM, Bryan O'Donoghue
> > <pure.logic@nexus-software.ie> wrote:
> > >
> > > The default may be set to SERIAL_8250 but, without the QRK
> > > specific
> > > entry in 8250_pci.c you won't get console output.
That's, by the way, not true.
> > >
> > > So if you are going to remove the QRK entry from 8250_pci.c and
> > > stuff
> > > it into 8250_lpss.c then 8250_lpss needs to be selected by
> > > CONFIG_SERIAL_8250_PCI.
> > Why?!
> >
> > Now it should be enough to have SERIAL_8250 set to non-n to have
> > 8250_lpss compiled.
> > Can you check it?
> I'm sure that's true.
>
> My point to you is that - its a highly non-intuitive thing to do on a
> reading of the datasheet for this part.
>
> LPSS is, ostensibly at least, for passing processor resources via
> APCI.
>
> If you look at a QRK datasheet it says "enumerate all this stuff via
> PCI" - there's not a single mention of LPSS. Its reasonable, correct
> and currently required for QRK to set CONFIG_8250_PCI.
User has no such item even visible until enable CONFIG_EXPERT.
Heikki sent an answer to you (and to the list, but by some reason it's
not yet there) an hour ago.
>
> To move away from a valid/standard PCI probe routine into a new
> special
> LPSS/PCI shim (which the hardware doesn't actually mandate) I do think
> you should to setup the dependency CONFIG_8250_PCI =>
> CONFIG_8250_LPSS.
No, this is what we try avoiding, thus it will not happen.
If user selects CONFIG_SERIAL_8250_PCI, the CONFIG_SERIAL_8250_LPSS will
be selected as well since it has same dependencies.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-05-04 11:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 13:48 [PATCH v3 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 01/11] dmaengine: dw: keep copy of custom slave config in dwc Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 02/11] dmaengine: dw: provide probe(), remove() stubs for users Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface Andy Shevchenko
2016-05-05 17:54 ` Bryan O'Donoghue
2016-05-06 10:42 ` Andy Shevchenko
2016-05-06 11:10 ` Bryan O'Donoghue
2016-04-27 13:48 ` [PATCH v3 04/11] dmaengine: dw: override LLP support if asked in platform data Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 05/11] serial: 8250_dma: switch to new dmaengine_terminate_* API Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 06/11] serial: 8250_dma: adjust DMA address of the UART Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 07/11] serial: 8250: enable AFE on ports where FIFO is 16 bytes Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 08/11] serial: 8250_lpss: split LPSS driver to separate module Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 09/11] serial: 8250_lpss: move Quark code from PCI driver Andy Shevchenko
2016-05-04 9:31 ` Bryan O'Donoghue
2016-05-04 9:42 ` Andy Shevchenko
2016-05-04 9:51 ` Bryan O'Donoghue
2016-05-04 10:03 ` Andy Shevchenko
2016-05-04 11:01 ` Bryan O'Donoghue
2016-05-04 11:20 ` Andy Shevchenko [this message]
2016-05-04 14:37 ` Bryan O'Donoghue
2016-05-04 14:55 ` Andy Shevchenko
2016-05-04 14:51 ` Bryan O'Donoghue
2016-05-04 17:43 ` Andy Shevchenko
2016-05-05 17:49 ` Bryan O'Donoghue
2016-05-06 10:39 ` Andy Shevchenko
2016-05-04 10:04 ` Heikki Krogerus
2016-04-27 13:48 ` [PATCH v3 10/11] serial: 8250_lpss: enable MSI for Intel Quark Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 11/11] serial: 8250_lpss: enable DMA on Intel Quark UART Andy Shevchenko
2016-04-28 17:35 ` [PATCH v3 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Bryan O'Donoghue
2016-05-03 22:55 ` Greg Kroah-Hartman
2016-05-04 9:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462360835.17131.224.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=pure.logic@nexus-software.ie \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.