From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Peter Hurley <peter@hurleysoftware.com>,
linux-serial@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ismo.puustinen@intel.com,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface
Date: Fri, 06 May 2016 13:42:00 +0300 [thread overview]
Message-ID: <1462531320.17131.277.camel@linux.intel.com> (raw)
In-Reply-To: <1462470851.2404.6.camel@nexus-software.ie>
On Thu, 2016-05-05 at 18:54 +0100, Bryan O'Donoghue wrote:
> On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote:
> >
> > + bool polarity;
> So this variable is not very intuitively named.
There is a help above. This is a property of the Synopsys DesignWare DMA
engine. Anyone familiar with datasheet easily understands this.
>
> You end up setting somepointer->polarity = true; in a later patch.
>
> Since you're respining a V4 I'd suggest a name that describes a little
> bit better than polarity. Setting polarity = true is a little bit
> liked
> being asked "you you like ice-cream or apple pie" and then saying "yes
> please".
It's about handshake interface polarity, so, what about hs_polarity?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2016-05-06 10:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 13:48 [PATCH v3 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 01/11] dmaengine: dw: keep copy of custom slave config in dwc Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 02/11] dmaengine: dw: provide probe(), remove() stubs for users Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface Andy Shevchenko
2016-05-05 17:54 ` Bryan O'Donoghue
2016-05-06 10:42 ` Andy Shevchenko [this message]
2016-05-06 11:10 ` Bryan O'Donoghue
2016-04-27 13:48 ` [PATCH v3 04/11] dmaengine: dw: override LLP support if asked in platform data Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 05/11] serial: 8250_dma: switch to new dmaengine_terminate_* API Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 06/11] serial: 8250_dma: adjust DMA address of the UART Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 07/11] serial: 8250: enable AFE on ports where FIFO is 16 bytes Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 08/11] serial: 8250_lpss: split LPSS driver to separate module Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 09/11] serial: 8250_lpss: move Quark code from PCI driver Andy Shevchenko
2016-05-04 9:31 ` Bryan O'Donoghue
2016-05-04 9:42 ` Andy Shevchenko
2016-05-04 9:51 ` Bryan O'Donoghue
2016-05-04 10:03 ` Andy Shevchenko
2016-05-04 11:01 ` Bryan O'Donoghue
2016-05-04 11:20 ` Andy Shevchenko
2016-05-04 14:37 ` Bryan O'Donoghue
2016-05-04 14:55 ` Andy Shevchenko
2016-05-04 14:51 ` Bryan O'Donoghue
2016-05-04 17:43 ` Andy Shevchenko
2016-05-05 17:49 ` Bryan O'Donoghue
2016-05-06 10:39 ` Andy Shevchenko
2016-05-04 10:04 ` Heikki Krogerus
2016-04-27 13:48 ` [PATCH v3 10/11] serial: 8250_lpss: enable MSI for Intel Quark Andy Shevchenko
2016-04-27 13:48 ` [PATCH v3 11/11] serial: 8250_lpss: enable DMA on Intel Quark UART Andy Shevchenko
2016-04-28 17:35 ` [PATCH v3 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark Bryan O'Donoghue
2016-05-03 22:55 ` Greg Kroah-Hartman
2016-05-04 9:48 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2016-05-06 11:20 [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface Maarten Brock
2016-05-06 11:38 ` Andy Shevchenko
2016-05-06 15:48 Maarten Brock
2016-05-06 18:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462531320.17131.277.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=pure.logic@nexus-software.ie \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.