All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hpe.com>
To: Dave Chinner <david@fromorbit.com>
Cc: jack@suse.cz, linux-nvdimm@lists.01.org,
	linux-kernel@vger.kernel.org, micah.parrish@hpe.com,
	hch@infradead.org, adilger.kernel@dilger.ca,
	linux-fsdevel@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount
Date: Wed, 04 May 2016 17:41:26 -0600	[thread overview]
Message-ID: <1462405286.27137.88.camel@hpe.com> (raw)
In-Reply-To: <20160504231855.GA26977@dastard>

On Thu, 2016-05-05 at 09:18 +1000, Dave Chinner wrote:
> On Mon, May 02, 2016 at 12:42:58PM -0600, Toshi Kani wrote:
> > 
:
> Please write a helper along the lines of:
> 
> 	error = blkdev_supports_dax(sb->s_bdev, sb->s_blocksize);
> 
> and encapsulate all this, including the specific error messages in the
> helper (i.e. "Block device %s does not support DAX."). Then the rest
> of the filesystem code looks something like this:
> 
> 	if (mp->m_flags & XFS_MOUNT_DAX) {
> 		error = blkdev_supports_dax(sb->s_bdev, sb->s_blocksize);
> 		if (error) {
> 			xfs_alert(mp,
> 		"DAX unsupported by block device. Turning off DAX.");
> 			mp->m_flags &= ~XFS_MOUNT_DAX;
> 		}
> 	}
> 
> And each filesystem can choose to do what it wants with the error
> without having to care exactly why DAX is not supported.

Yes, I had this change in mind and was wondering if you are OK with it
since I am incline to keep the ext2/4 message style as majority rule. :)
https://lkml.org/lkml/2016/5/3/543

Assuming that's OK, I will make this change.

Thanks!
-Toshi

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: Dave Chinner <david@fromorbit.com>
Cc: dan.j.williams@intel.com, jack@suse.cz, hch@infradead.org,
	boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca,
	ross.zwisler@linux.intel.com, micah.parrish@hpe.com,
	linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount
Date: Wed, 04 May 2016 17:41:26 -0600	[thread overview]
Message-ID: <1462405286.27137.88.camel@hpe.com> (raw)
In-Reply-To: <20160504231855.GA26977@dastard>

On Thu, 2016-05-05 at 09:18 +1000, Dave Chinner wrote:
> On Mon, May 02, 2016 at 12:42:58PM -0600, Toshi Kani wrote:
> > 
:
> Please write a helper along the lines of:
> 
> 	error = blkdev_supports_dax(sb->s_bdev, sb->s_blocksize);
> 
> and encapsulate all this, including the specific error messages in the
> helper (i.e. "Block device %s does not support DAX."). Then the rest
> of the filesystem code looks something like this:
> 
> 	if (mp->m_flags & XFS_MOUNT_DAX) {
> 		error = blkdev_supports_dax(sb->s_bdev, sb->s_blocksize);
> 		if (error) {
> 			xfs_alert(mp,
> 		"DAX unsupported by block device. Turning off DAX.");
> 			mp->m_flags &= ~XFS_MOUNT_DAX;
> 		}
> 	}
> 
> And each filesystem can choose to do what it wants with the error
> without having to care exactly why DAX is not supported.

Yes, I had this change in mind and was wondering if you are OK with it
since I am incline to keep the ext2/4 message style as majority rule. :)
https://lkml.org/lkml/2016/5/3/543

Assuming that's OK, I will make this change.

Thanks!
-Toshi


WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: Dave Chinner <david@fromorbit.com>
Cc: dan.j.williams@intel.com, jack@suse.cz, hch@infradead.org,
	boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca,
	ross.zwisler@linux.intel.com, micah.parrish@hpe.com,
	linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] xfs: Add alignment check for DAX mount
Date: Wed, 04 May 2016 17:41:26 -0600	[thread overview]
Message-ID: <1462405286.27137.88.camel@hpe.com> (raw)
In-Reply-To: <20160504231855.GA26977@dastard>

On Thu, 2016-05-05 at 09:18 +1000, Dave Chinner wrote:
> On Mon, May 02, 2016 at 12:42:58PM -0600, Toshi Kani wrote:
> > 
:
> Please write a helper along the lines of:
> 
> 	error = blkdev_supports_dax(sb->s_bdev, sb->s_blocksize);
> 
> and encapsulate all this, including the specific error messages in the
> helper (i.e. "Block device %s does not support DAX."). Then the rest
> of the filesystem code looks something like this:
> 
> 	if (mp->m_flags & XFS_MOUNT_DAX) {
> 		error = blkdev_supports_dax(sb->s_bdev, sb->s_blocksize);
> 		if (error) {
> 			xfs_alert(mp,
> 		"DAX unsupported by block device. Turning off DAX.");
> 			mp->m_flags &= ~XFS_MOUNT_DAX;
> 		}
> 	}
> 
> And each filesystem can choose to do what it wants with the error
> without having to care exactly why DAX is not supported.

Yes, I had this change in mind and was wondering if you are OK with it
since I am incline to keep the ext2/4 message style as majority rule. :)
https://lkml.org/lkml/2016/5/3/543

Assuming that's OK, I will make this change.

Thanks!
-Toshi

  reply	other threads:[~2016-05-04 23:50 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02 18:42 [PATCH v2 0/3] Add alignment check for DAX mount Toshi Kani
2016-05-02 18:42 ` Toshi Kani
2016-05-02 18:42 ` Toshi Kani
2016-05-02 18:42 ` [PATCH v2 1/3] ext4: " Toshi Kani
2016-05-02 18:42   ` Toshi Kani
2016-05-02 18:42   ` Toshi Kani
2016-05-03  7:58   ` Jan Kara
2016-05-03  7:58     ` Jan Kara
2016-05-03  7:58     ` Jan Kara
2016-05-03  8:44   ` Christoph Hellwig
2016-05-03  9:00     ` Jan Kara
2016-05-03 14:43       ` Ross Zwisler
2016-05-03 15:41         ` Toshi Kani
2016-05-04 15:42           ` Toshi Kani
2016-05-02 18:42 ` [PATCH v2 2/3] ext2: " Toshi Kani
2016-05-02 18:42   ` Toshi Kani
2016-05-02 18:42   ` Toshi Kani
2016-05-03  8:01   ` Jan Kara
2016-05-03  8:01     ` Jan Kara
2016-05-03  8:01     ` Jan Kara
2016-05-02 18:42 ` [PATCH v2 3/3] xfs: " Toshi Kani
2016-05-02 18:42   ` Toshi Kani
2016-05-02 18:42   ` Toshi Kani
2016-05-02 19:50   ` Ross Zwisler
2016-05-02 19:50     ` Ross Zwisler
2016-05-02 19:50     ` Ross Zwisler
2016-05-02 19:54     ` Toshi Kani
2016-05-02 19:54       ` Toshi Kani
2016-05-02 19:54       ` Toshi Kani
2016-05-04 23:18   ` Dave Chinner
2016-05-04 23:18     ` Dave Chinner
2016-05-04 23:18     ` Dave Chinner
2016-05-04 23:41     ` Toshi Kani [this message]
2016-05-04 23:41       ` Toshi Kani
2016-05-04 23:41       ` Toshi Kani
2016-05-05  8:03       ` Jan Kara
2016-05-05  8:03         ` Jan Kara
2016-05-05  8:03         ` Jan Kara
2016-05-02 19:20 ` [PATCH v2 0/3] " Boaz Harrosh
2016-05-02 19:20   ` Boaz Harrosh
2016-05-02 19:20   ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462405286.27137.88.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=micah.parrish@hpe.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.