All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test" has been added to the 4.5-stable tree
@ 2016-05-06 16:30 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-05-06 16:30 UTC (permalink / raw)
  To: daniel.lezcano, gregkh, marc_gonzalez; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test

to the 4.5-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     clocksource-drivers-tango-xtal-fix-boot-hang-due-to-incorrect-test.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 16eeed7e5558a3dcf30f75526a896b2632f299f9 Mon Sep 17 00:00:00 2001
From: Daniel Lezcano <daniel.lezcano@linaro.org>
Date: Tue, 19 Apr 2016 15:43:02 +0200
Subject: clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test

From: Daniel Lezcano <daniel.lezcano@linaro.org>

commit 16eeed7e5558a3dcf30f75526a896b2632f299f9 upstream.

Commit 0881841f7e78 introduced a regression by inverting a test check
after calling clocksource_mmio_init(). That results on the system to
hang at boot time.

Fix it by inverting the test again.

Fixes: 0881841f7e78 ("Replace code by clocksource_mmio_init")
Reported-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/clocksource/tango_xtal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/clocksource/tango_xtal.c
+++ b/drivers/clocksource/tango_xtal.c
@@ -42,7 +42,7 @@ static void __init tango_clocksource_ini
 
 	ret = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350,
 				    32, clocksource_mmio_readl_up);
-	if (!ret) {
+	if (ret) {
 		pr_err("%s: registration failed\n", np->full_name);
 		return;
 	}


Patches currently in stable-queue which might be from daniel.lezcano@linaro.org are

queue-4.5/clocksource-drivers-tango-xtal-fix-boot-hang-due-to-incorrect-test.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-05-06 17:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-06 16:30 Patch "clocksource/drivers/tango-xtal: Fix boot hang due to incorrect test" has been added to the 4.5-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.