From: Garlic Tseng <garlic.tseng@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
alsa-devel@alsa-project.org, ir.lian@mediatek.com,
srv_heupstream@mediatek.com, tiwai@suse.de,
linux-kernel@vger.kernel.org, koro.chen@mediatek.com,
linux-mediatek@lists.infradead.org, PC.Liao@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 1/7] ASoC: mediatek: Refine mt8173 driver and change config option
Date: Sat, 7 May 2016 02:33:56 +0800 [thread overview]
Message-ID: <1462559636.11805.6.camel@mtksdaap41> (raw)
In-Reply-To: <20160506122046.GR6292@sirena.org.uk>
On Fri, 2016-05-06 at 13:20 +0100, Mark Brown wrote:
> On Thu, May 05, 2016 at 06:39:32PM +0800, Garlic Tseng wrote:
>
> > As mentioned above, the difference of the ASoCs between the two chips
> > are too large that we have a hard time sharing the driver code.
>
> The things you're describing all sound like scaling differences rather
> than fundamental changes. I'd expect to see at least some shared code
> here, we don't want to be just duplicating the entire driver every time
> there's a new hardware revision.
Oh ok, I'll do it in the next version. Thanks for comment.
WARNING: multiple messages have this Message-ID (diff)
From: garlic.tseng@mediatek.com (Garlic Tseng)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/7] ASoC: mediatek: Refine mt8173 driver and change config option
Date: Sat, 7 May 2016 02:33:56 +0800 [thread overview]
Message-ID: <1462559636.11805.6.camel@mtksdaap41> (raw)
In-Reply-To: <20160506122046.GR6292@sirena.org.uk>
On Fri, 2016-05-06 at 13:20 +0100, Mark Brown wrote:
> On Thu, May 05, 2016 at 06:39:32PM +0800, Garlic Tseng wrote:
>
> > As mentioned above, the difference of the ASoCs between the two chips
> > are too large that we have a hard time sharing the driver code.
>
> The things you're describing all sound like scaling differences rather
> than fundamental changes. I'd expect to see at least some shared code
> here, we don't want to be just duplicating the entire driver every time
> there's a new hardware revision.
Oh ok, I'll do it in the next version. Thanks for comment.
WARNING: multiple messages have this Message-ID (diff)
From: Garlic Tseng <garlic.tseng@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
<alsa-devel@alsa-project.org>, <ir.lian@mediatek.com>,
<srv_heupstream@mediatek.com>, <tiwai@suse.de>,
<linux-kernel@vger.kernel.org>, <koro.chen@mediatek.com>,
<linux-mediatek@lists.infradead.org>, <PC.Liao@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH 1/7] ASoC: mediatek: Refine mt8173 driver and change config option
Date: Sat, 7 May 2016 02:33:56 +0800 [thread overview]
Message-ID: <1462559636.11805.6.camel@mtksdaap41> (raw)
In-Reply-To: <20160506122046.GR6292@sirena.org.uk>
On Fri, 2016-05-06 at 13:20 +0100, Mark Brown wrote:
> On Thu, May 05, 2016 at 06:39:32PM +0800, Garlic Tseng wrote:
>
> > As mentioned above, the difference of the ASoCs between the two chips
> > are too large that we have a hard time sharing the driver code.
>
> The things you're describing all sound like scaling differences rather
> than fundamental changes. I'd expect to see at least some shared code
> here, we don't want to be just duplicating the entire driver every time
> there's a new hardware revision.
Oh ok, I'll do it in the next version. Thanks for comment.
next prev parent reply other threads:[~2016-05-06 18:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 13:00 [alsa-devel] [PATCH 0/7] ASoC: Mediatek: Add support for MT2701 SOC Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` [alsa-devel] [PATCH 1/7] ASoC: mediatek: Refine mt8173 driver and change config option Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-05-04 16:43 ` Mark Brown
2016-05-04 16:43 ` Mark Brown
2016-05-05 2:45 ` Garlic Tseng
2016-05-05 2:45 ` [alsa-devel] " Garlic Tseng
2016-05-05 2:45 ` Garlic Tseng
2016-05-05 8:32 ` Matthias Brugger
2016-05-05 8:32 ` [alsa-devel] " Matthias Brugger
2016-05-05 8:32 ` Matthias Brugger
2016-05-05 10:39 ` Garlic Tseng
2016-05-05 10:39 ` Garlic Tseng
2016-05-05 10:39 ` Garlic Tseng
2016-05-06 12:20 ` Mark Brown
2016-05-06 12:20 ` Mark Brown
2016-05-06 18:33 ` Garlic Tseng [this message]
2016-05-06 18:33 ` Garlic Tseng
2016-05-06 18:33 ` Garlic Tseng
2016-04-29 13:00 ` [alsa-devel] [PATCH 2/7] ASoC: mediatek: add documents for mt2701 Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` [alsa-devel] [PATCH 3/7] ASoC: mediatek: add clock and irq control for 2701 platform driver Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` [PATCH 4/7] ASoC: mediatek: add mt2701 platform driver implementation Garlic Tseng
2016-04-29 13:00 ` [alsa-devel] " Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` [alsa-devel] [PATCH 5/7] ASoC: bt-sco: extend rate and add a general compatible string Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
[not found] ` <1461934848-60011-1-git-send-email-garlic.tseng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-04-29 13:00 ` [alsa-devel] [PATCH 6/7] ASoC: mediatek: add BT implementation Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` [alsa-devel] [PATCH 7/7] ASoC: mediatek: Add mt2701-cs42448 driver and config option Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
2016-04-29 13:00 ` Garlic Tseng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462559636.11805.6.camel@mtksdaap41 \
--to=garlic.tseng@mediatek.com \
--cc=PC.Liao@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ir.lian@mediatek.com \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.