From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"axboe@fb.com" <axboe@fb.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"boaz@plexistor.com" <boaz@plexistor.com>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
"david@fromorbit.com" <david@fromorbit.com>,
"jack@suse.cz" <jack@suse.cz>
Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
Date: Sun, 8 May 2016 18:46:13 +0000 [thread overview]
Message-ID: <1462733173.3006.7.camel@intel.com> (raw)
In-Reply-To: <20160508085203.GA10160@infradead.org>
T24gU3VuLCAyMDE2LTA1LTA4IGF0IDAxOjUyIC0wNzAwLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90
ZToNCj4gT24gRnJpLCBNYXkgMDYsIDIwMTYgYXQgMDM6NTM6MDlQTSAtMDYwMCwgVmlzaGFsIFZl
cm1hIHdyb3RlOg0KPiA+IA0KPiA+IEZyb206IE1hdHRoZXcgV2lsY294IDxtYXR0aGV3LnIud2ls
Y294QGludGVsLmNvbT4NCj4gPiANCj4gPiBkYXhfY2xlYXJfc2VjdG9ycygpIGNhbm5vdCBoYW5k
bGUgcG9pc29uZWQgYmxvY2tzLsKgwqBUaGVzZSBtdXN0IGJlDQo+ID4gemVyb2VkIHVzaW5nIHRo
ZSBCSU8gaW50ZXJmYWNlIGluc3RlYWQuwqDCoENvbnZlcnQgZXh0MiBhbmQgWEZTIHRvDQo+ID4g
dXNlDQo+ID4gb25seSBzYl9pc3N1ZV96ZXJvdXQoKS4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5
OiBNYXR0aGV3IFdpbGNveCA8bWF0dGhldy5yLndpbGNveEBpbnRlbC5jb20+DQo+ID4gW3Zpc2hh
bDogQWxzbyByZW1vdmUgdGhlIGRheF9jbGVhcl9zZWN0b3JzIGZ1bmN0aW9uIGVudGlyZWx5XQ0K
PiA+IFNpZ25lZC1vZmYtYnk6IFZpc2hhbCBWZXJtYSA8dmlzaGFsLmwudmVybWFAaW50ZWwuY29t
Pg0KPiBKdXN0IHRvIG1ha2Ugc3VyZTrCoMKgdGhlIGV4aXN0aW5nIHNiX2lzc3VlX3plcm91dCBh
cyBpbiA0LjYtcmMNCj4gaXMgYWxyZWFkeSBkb2luZyB0aGUgcmlnaHQgdGhpbmcgZm9yIERBWD/C
oMKgSSd2ZSBnb3QgYSBwZW5kaW5nDQo+IHBhdGNoc2V0DQo+IGZvciBYRlMgdGhhdCBpbnRyb2R1
Y2VzIGFub3RoZXIgZGF4X2NsZWFyX3NlY3RvcnMgdXNlcnMsIGJ1dCBpZiBpdCdzDQo+IGFscmVh
ZHkgc2FmZSB0byB1c2UgYmxrZGV2X2lzc3VlX3plcm9vdXQgSSBjYW4gc3dpdGNoIHRvIHRoYXQg
YW5kDQo+IGF2b2lkDQo+IHRoZSBtZXJnZSBjb25mbGljdC4NCg0KSSBiZWxpZXZlIHNvIC0gSmFu
IGhhcyBtb3ZlZCBhbGwgdW53cml0dGVuIGV4dGVudCBjb252ZXJzaW9ucyBvdXQgb2YNCkRBWCB3
aXRoIGhpcyBwYXRjaCBzZXQsIGFuZCBJIGJlbGlldmUgemVyb2luZyB0aHJvdWdoIHRoZSBkcml2
ZXIgaXMNCmFsd2F5cyBmaW5lLiBSb3NzIG9yIEphbiBjb3VsZCBjb25maXJtIHRob3VnaC7CoA==
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "axboe@fb.com" <axboe@fb.com>, "jack@suse.cz" <jack@suse.cz>,
"boaz@plexistor.com" <boaz@plexistor.com>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
Date: Sun, 8 May 2016 18:46:13 +0000 [thread overview]
Message-ID: <1462733173.3006.7.camel@intel.com> (raw)
In-Reply-To: <20160508085203.GA10160@infradead.org>
On Sun, 2016-05-08 at 01:52 -0700, Christoph Hellwig wrote:
> On Fri, May 06, 2016 at 03:53:09PM -0600, Vishal Verma wrote:
> >
> > From: Matthew Wilcox <matthew.r.wilcox@intel.com>
> >
> > dax_clear_sectors() cannot handle poisoned blocks. These must be
> > zeroed using the BIO interface instead. Convert ext2 and XFS to
> > use
> > only sb_issue_zerout().
> >
> > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> > [vishal: Also remove the dax_clear_sectors function entirely]
> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> Just to make sure: the existing sb_issue_zerout as in 4.6-rc
> is already doing the right thing for DAX? I've got a pending
> patchset
> for XFS that introduces another dax_clear_sectors users, but if it's
> already safe to use blkdev_issue_zeroout I can switch to that and
> avoid
> the merge conflict.
I believe so - Jan has moved all unwritten extent conversions out of
DAX with his patch set, and I believe zeroing through the driver is
always fine. Ross or Jan could confirm though.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"axboe@fb.com" <axboe@fb.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"boaz@plexistor.com" <boaz@plexistor.com>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>,
"david@fromorbit.com" <david@fromorbit.com>,
"jack@suse.cz" <jack@suse.cz>
Subject: Re: [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors
Date: Sun, 8 May 2016 18:46:13 +0000 [thread overview]
Message-ID: <1462733173.3006.7.camel@intel.com> (raw)
In-Reply-To: <20160508085203.GA10160@infradead.org>
On Sun, 2016-05-08 at 01:52 -0700, Christoph Hellwig wrote:
> On Fri, May 06, 2016 at 03:53:09PM -0600, Vishal Verma wrote:
> >
> > From: Matthew Wilcox <matthew.r.wilcox@intel.com>
> >
> > dax_clear_sectors() cannot handle poisoned blocks. These must be
> > zeroed using the BIO interface instead. Convert ext2 and XFS to
> > use
> > only sb_issue_zerout().
> >
> > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> > [vishal: Also remove the dax_clear_sectors function entirely]
> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> Just to make sure: the existing sb_issue_zerout as in 4.6-rc
> is already doing the right thing for DAX? I've got a pending
> patchset
> for XFS that introduces another dax_clear_sectors users, but if it's
> already safe to use blkdev_issue_zeroout I can switch to that and
> avoid
> the merge conflict.
I believe so - Jan has moved all unwritten extent conversions out of
DAX with his patch set, and I believe zeroing through the driver is
always fine. Ross or Jan could confirm though.
next prev parent reply other threads:[~2016-05-08 18:46 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 21:53 [PATCH v5 0/5] dax: handling media errors (clear-on-zero only) Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` [PATCH v5 1/5] dax: fallback from pmd to pte on error Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-10 14:15 ` Jan Kara
2016-05-10 14:15 ` Jan Kara
2016-05-10 14:15 ` Jan Kara
2016-05-10 14:15 ` Jan Kara
2016-05-10 14:15 ` Jan Kara
2016-05-06 21:53 ` [PATCH v5 2/5] dax: enable dax in the presence of known media errors (badblocks) Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` [PATCH v5 3/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-08 8:52 ` Christoph Hellwig
2016-05-08 8:52 ` Christoph Hellwig
2016-05-08 8:52 ` Christoph Hellwig
2016-05-08 18:46 ` Verma, Vishal L [this message]
2016-05-08 18:46 ` Verma, Vishal L
2016-05-08 18:46 ` Verma, Vishal L
2016-05-09 14:55 ` Ross Zwisler
2016-05-09 14:55 ` Ross Zwisler
2016-05-09 14:55 ` Ross Zwisler
2016-05-09 14:55 ` Ross Zwisler
2016-05-09 14:55 ` Ross Zwisler
2016-05-10 14:16 ` Jan Kara
2016-05-10 14:16 ` Jan Kara
2016-05-10 14:16 ` Jan Kara
2016-05-10 14:16 ` Jan Kara
2016-05-10 14:16 ` Jan Kara
2016-05-06 21:53 ` [PATCH v5 4/5] dax: for truncate/hole-punch, do zeroing through the driver if possible Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-10 14:21 ` Jan Kara
2016-05-10 14:21 ` Jan Kara
2016-05-10 14:21 ` Jan Kara
2016-05-10 14:21 ` Jan Kara
2016-05-10 14:21 ` Jan Kara
2016-05-06 21:53 ` [PATCH v5 5/5] dax: fix a comment in dax_zero_page_range and dax_truncate_page Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-06 21:53 ` Vishal Verma
2016-05-10 14:29 ` Jan Kara
2016-05-10 14:29 ` Jan Kara
2016-05-10 14:29 ` Jan Kara
2016-05-10 14:29 ` Jan Kara
2016-05-10 14:29 ` Jan Kara
2016-05-08 8:55 ` [PATCH v5 0/5] dax: handling media errors (clear-on-zero only) Christoph Hellwig
2016-05-08 8:55 ` Christoph Hellwig
2016-05-08 8:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462733173.3006.7.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=boaz@plexistor.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=ross.zwisler@linux.intel.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.