[PATCH] runqueue: Fix missing fakeworker under dry run

[PATCH] runqueue: Fix missing fakeworker under dry run

[Richard Purdie]

We shouldn't try and use fakeworker when performing a dry_run. This
makes the core match the other fakeworker execution points.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 0af4678..8d2aa7b 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -2095,7 +2095,7 @@ class RunQueueExecuteScenequeue(RunQueueExecute):
             bb.event.fire(startevent, self.cfgData)
 
             taskdep = self.rqdata.dataCache.task_deps[fn]
-            if 'fakeroot' in taskdep and taskname in taskdep['fakeroot']:
+            if 'fakeroot' in taskdep and taskname in taskdep['fakeroot'] and not self.cooker.configuration.dry_run:
                 if not self.rq.fakeworker:
                     self.rq.start_fakeworker(self)
                 self.rq.fakeworker.stdin.write("<runtask>" + pickle.dumps((fn, realtask, taskname, True, self.cooker.collection.get_file_appends(fn), None)) + "</runtask>")

Re: [PATCH] runqueue: Fix missing fakeworker under dry run

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

On Mon, May 9, 2016 at 6:15 AM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> We shouldn't try and use fakeworker when performing a dry_run. This
> makes the core match the other fakeworker execution points.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>

Looks good.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 938 bytes --]