[PATCH 0/2] check-git-log fix and enhancement

[PATCH 0/2] check-git-log fix and enhancement

[Yuanhan Liu]

Patch 1 fix a false positive warning; patch 2 helps to spot bad content
clearly.

---
Yuanhan Liu (2):
  scripts: fix false positive warning
  scripts: high light bad patterns

 scripts/check-git-log.sh | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
1.9.0

[PATCH 1/2] scripts: fix false positive warning

[Yuanhan Liu]

It reports an false positive warning when the commit subject includes
the word "ctx", as it matches following regexp:

     -e 'rx\|tx\|RX\|TX'

Fixes: edbeb7d962e9 ("scripts: check commit formatting")

Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
 scripts/check-git-log.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index ce6c15e..b7ea1be 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -86,8 +86,8 @@ bad=$(echo "$headlines" | grep \
 [ -z "$bad" ] || printf "Wrong headline uppercase:\n$bad\n"
 
 # check headline uppercase (Rx/Tx, VF, L2, MAC, Linux, ARM...)
-bad=$(echo "$headlines" | grep \
-	-e 'rx\|tx\|RX\|TX' \
+bad=$(echo "$headlines" | grep -E \
+	-e '\<(rx|tx|RX|TX)\>' \
 	-e '\<[pv]f\>' \
 	-e '\<l[234]\>' \
 	-e ':.*\<dma\>' \
-- 
1.9.0

[PATCH 2/2 RFC] scripts: high light bad patterns

[Yuanhan Liu]

I got a report like following:

    Wrong headline lowercase:
            xxx: move vhost device ctx to cuse

It takes a bit while (by checking the code) that it's "ctx" triggers
the warning. It could be spotted very quickly if "tx" is high lighted.
This patch adds such support.

Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
 scripts/check-git-log.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
index b7ea1be..153f378 100755
--- a/scripts/check-git-log.sh
+++ b/scripts/check-git-log.sh
@@ -55,7 +55,7 @@ tags=$(git log --format='%b' $range | grep -i -e 'by *:' -e 'fix.*:')
 fixes=$(git log --format='%h %s' $range | grep -i ': *fix' | cut -d' ' -f1)
 
 # check headline format (spacing, no punctuation, no code)
-bad=$(echo "$headlines" | grep \
+bad=$(echo "$headlines" | grep --color=always \
 	-e '	' \
 	-e '^ ' \
 	-e ' $' \
@@ -69,7 +69,7 @@ bad=$(echo "$headlines" | grep \
 [ -z "$bad" ] || printf "Wrong headline format:\n$bad\n"
 
 # check headline label for common typos
-bad=$(echo "$headlines" | grep \
+bad=$(echo "$headlines" | grep --color=always \
 	-e '^example[:/]' \
 	-e '^apps/' \
 	-e '^testpmd' \
@@ -79,14 +79,14 @@ bad=$(echo "$headlines" | grep \
 [ -z "$bad" ] || printf "Wrong headline label:\n$bad\n"
 
 # check headline lowercase for first words
-bad=$(echo "$headlines" | grep \
+bad=$(echo "$headlines" | grep --color=always \
 	-e '^.*[A-Z].*:' \
 	-e ': *[A-Z]' \
 	| sed 's,^,\t,')
 [ -z "$bad" ] || printf "Wrong headline uppercase:\n$bad\n"
 
 # check headline uppercase (Rx/Tx, VF, L2, MAC, Linux, ARM...)
-bad=$(echo "$headlines" | grep -E \
+bad=$(echo "$headlines" | grep -E --color=always \
 	-e '\<(rx|tx|RX|TX)\>' \
 	-e '\<[pv]f\>' \
 	-e '\<l[234]\>' \
-- 
1.9.0

Re: [PATCH 0/2] check-git-log fix and enhancement

[Thomas Monjalon]

2016-05-10 21:08, Yuanhan Liu:
> Patch 1 fix a false positive warning; patch 2 helps to spot bad content
> clearly.
> 
> ---
> Yuanhan Liu (2):
>   scripts: fix false positive warning
>   scripts: high light bad patterns

The justification of these patches is the word "ctx".
It should be written "context" (full spelling) ;)

Anyway, series applied, thanks