All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <a@unstable.cc>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>
Subject: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header
Date: Wed, 11 May 2016 18:29:16 +0800	[thread overview]
Message-ID: <1462962557-23950-1-git-send-email-a@unstable.cc> (raw)

If main.h is included, the forward declaration for struct batadv_priv
is not required.

Cc: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---

Sven, is there any special region for not having the include in this file ?
It seems to be compiling just fine.

Cheers,


 net/batman-adv/bat_algo.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/batman-adv/bat_algo.h b/net/batman-adv/bat_algo.h
index 03dafd3..b727762 100644
--- a/net/batman-adv/bat_algo.h
+++ b/net/batman-adv/bat_algo.h
@@ -18,7 +18,7 @@
 #ifndef _NET_BATMAN_ADV_BAT_ALGO_H_
 #define _NET_BATMAN_ADV_BAT_ALGO_H_
 
-struct batadv_priv;
+#include "main.h"
 
 int batadv_iv_init(void);
 
-- 
2.8.2


             reply	other threads:[~2016-05-11 10:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 10:29 Antonio Quartulli [this message]
2016-05-11 10:29 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: B.A.T.M.A.N. V - implement hard-iface init function Antonio Quartulli
2016-05-11 13:11   ` Sven Eckelmann
2016-05-11 21:14     ` Antonio Quartulli
2016-05-11 10:38 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header Sven Eckelmann
2016-05-11 10:47   ` Antonio Quartulli
2016-05-11 12:24     ` Sven Eckelmann
2016-05-12 21:07       ` Antonio Quartulli
2016-05-12 22:45         ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462962557-23950-1-git-send-email-a@unstable.cc \
    --to=a@unstable.cc \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.