From: Antonio Quartulli <a@unstable.cc>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header
Date: Fri, 13 May 2016 05:07:18 +0800 [thread overview]
Message-ID: <20160512210718.GG21549@prodigo.lan> (raw)
In-Reply-To: <5284085.o6G6OjSAFN@bentobox>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Wed, May 11, 2016 at 02:24:04PM +0200, Sven Eckelmann wrote:
> On Wednesday 11 May 2016 18:47:30 Antonio Quartulli wrote:
> [...]
> > Maybe I could include it only when really needed, i.e.
> > * net/batman-adv/bat_algo.h
> > * net/batman-adv/bat_v_ogm.h
> >
> > (netlink.h does not seem to be requiring it)
>
> This is rather vague and hard to detect automatically. Potentially all
> files may require it because it has things like:
>
> /* Debug Messages */
> #ifdef pr_fmt
> #undef pr_fmt
> #endif
> /* Append 'batman-adv: ' before kernel messages */
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
ok, how about adding it to any header file than (which is probably what you were
suggesting in the first place)?
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-12 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 10:29 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header Antonio Quartulli
2016-05-11 10:29 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: B.A.T.M.A.N. V - implement hard-iface init function Antonio Quartulli
2016-05-11 13:11 ` Sven Eckelmann
2016-05-11 21:14 ` Antonio Quartulli
2016-05-11 10:38 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header Sven Eckelmann
2016-05-11 10:47 ` Antonio Quartulli
2016-05-11 12:24 ` Sven Eckelmann
2016-05-12 21:07 ` Antonio Quartulli [this message]
2016-05-12 22:45 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512210718.GG21549@prodigo.lan \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.