From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igb: properly start/stop PTP during suspend/resume
Date: Wed, 11 May 2016 21:12:33 +0000 [thread overview]
Message-ID: <1463001153.15592.0.camel@intel.com> (raw)
In-Reply-To: <20160511182335.12453-1-jacob.e.keller@intel.com>
On Wed, 2016-05-11 at 11:23 -0700, Jacob Keller wrote:
> Reported-by: Vidya Sagar <sagar.tv@gmail.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> ?drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++
> ?1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
> b/drivers/net/ethernet/intel/igb/igb_main.c
> index 21727692bef6..8f740bc69fc3 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -7527,6 +7527,8 @@ static int __igb_shutdown(struct pci_dev *pdev,
> bool *enable_wake,
> ? if (netif_running(netdev))
> ? __igb_close(netdev, true);
> ?
> + igb_ptp_stop(adapter);
> +
> ? igb_clear_interrupt_scheme(adapter);
> ?
> ?#ifdef CONFIG_PM
> @@ -7637,6 +7639,8 @@ static int igb_resume(struct device *dev)
> ? return -ENOMEM;
> ? }
> ?
> + igb_ptp_init(adapter);
> +
> ? igb_reset(adapter);
> ?
> ? /* let the f/w know that the h/w is now under the control of
> the
Unfortunately I think this patch is wrong, my first pass at fixing was
to do igb_ptp_stop and igb_ptp_init, but this seems like it won't work
because we'll actually remove the PHC device, which we don't want to
do. I'm going to rework this patch and send a v2.
Thanks,
Jake
prev parent reply other threads:[~2016-05-11 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 18:23 [Intel-wired-lan] [PATCH] igb: properly start/stop PTP during suspend/resume Jacob Keller
2016-05-11 21:12 ` Keller, Jacob E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463001153.15592.0.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.