From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Emmanuel Grumbach <egrumbach@gmail.com>,
"backports@vger.kernel.org" <backports@vger.kernel.org>
Subject: Re: wireless_nlevent_flush backported to stable kernels
Date: Mon, 16 May 2016 21:26:08 +0200 [thread overview]
Message-ID: <1463426768.2179.3.camel@sipsolutions.net> (raw)
In-Reply-To: <5738467E.4020005@broadcom.com> (sfid-20160515_115109_089094_3A0AC8CB)
On Sun, 2016-05-15 at 11:50 +0200, Arend Van Spriel wrote:
>
> > On my system, I fixed it with the patch below, but it is surely not
> > good enough.
> In general this is avoided by preceeding the stub function with:
>
> #define wireless_nlevent_flush LINUX_BACKPORT(wireless_nlevent_flush)
>
> This way you will use the stub and not the in-kernel function.
That's normally fine, but not a good idea here because this really is a
*stub*, and thus using the stub instead of the real function removes
the ability to actually get the bugfix. So in this case, where it's a
stub and not a full backport, it's better to try to get the original
function in as many situations as possible.
> There has
> been discussions about adding a mechanism to avoid backport if kernel
> has the function available. No actual work in that area has been done
> yet.
Oh, I've done that - but it was so terribly slow that it was
essentially unusable...
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2016-05-16 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 6:25 wireless_nlevent_flush backported to stable kernels Emmanuel Grumbach
2016-05-15 9:50 ` Arend Van Spriel
2016-05-16 19:26 ` Johannes Berg [this message]
2016-05-17 9:05 ` Arend Van Spriel
2016-05-17 9:08 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463426768.2179.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=backports@vger.kernel.org \
--cc=egrumbach@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.