Re: wireless_nlevent_flush backported to stable kernels

[Arend Van Spriel <arend.vanspriel@broadcom.com>]

On 15-5-2016 8:25, Emmanuel Grumbach wrote:
> Hi,
> 
> Johanne's patch:
> 
> commit cb150b9d23be6ee7f3a0fff29784f1c5b5ac514d
> Author: Johannes Berg <johannes.berg@intel.com>
> Date:   Wed Jan 27 13:29:34 2016 +0100
> 
>     cfg80211/wext: fix message ordering
> 
> 
> has been backported to more stable kernels and hence backport needs to
> take that into account.
> I am using Ubuntu's wily kernel (4.2 based) and apparently, they
> backported Johanne's fix as well.
> 
> On my system, I fixed it with the patch below, but it is surely not good enough.

In general this is avoided by preceeding the stub function with:

#define wireless_nlevent_flush LINUX_BACKPORT(wireless_nlevent_flush)

This way you will use the stub and not the in-kernel function. There has
been discussions about adding a mechanism to avoid backport if kernel
has the function available. No actual work in that area has been done yet.

Regards,
Arend

> diff --git a/backport-include/net/iw_handler.h
> b/backport-include/net/iw_handler.h
> index e205d1e..b9c0144 100644
> --- a/backport-include/net/iw_handler.h
> +++ b/backport-include/net/iw_handler.h
> @@ -25,7 +25,8 @@ iwe_stream_add_point_check(struct iw_request_info
> *info, char *stream,
>         return res;
>  }
>  #endif /* LINUX_VERSION_CODE < KERNEL_VERSION(4,1,0) */
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(4,4,6)
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,4,6) &&      \
> +    LINUX_VERSION_CODE < KERNEL_VERSION(4,1,21)
>  static inline void wireless_nlevent_flush(void) {}
>  #endif
>  #endif /* __BACKPORT_IW_HANDLER_H */
> 
> 
> Emmanuel Grumbach
> egrumbach@gmail.com
> --
> To unsubscribe from this list: send the line "unsubscribe backports" in
> 
--
To unsubscribe from this list: send the line "unsubscribe backports" in