All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org, allen.m.kay@intel.com,
	kvm@vger.kernel.org, "Zhao, Xinda" <xinda.zhao@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH v6 6/8] vfio/pci: Intel graphics legacy mode assignment
Date: Wed, 18 May 2016 16:21:58 +0200	[thread overview]
Message-ID: <1463581318.30045.66.camel@redhat.com> (raw)
In-Reply-To: <20160517201955.6175.97671.stgit@gimli.home>

On Di, 2016-05-17 at 14:19 -0600, Alex Williamson wrote:
> +static int igd_gen(VFIOPCIDevice *vdev)
> +{
> +    if ((vdev->device_id & 0xfff) == 0xa84) {
> +        return 8; /* Broxton */
> +    }
> +
> +    switch (vdev->device_id & 0xff00) {
> +    /* Old, untested, unavailable, unknown */
> +    case 0x0000:
> +    case 0x2500:
> +    case 0x2700:
> +    case 0x2900:
> +    case 0x2a00:
> +    case 0x2e00:
> +    case 0x3500:
> +    case 0xa000:
> +        return -1;
> +    /* SandyBridge, IvyBridge, ValleyView, Haswell */
> +    case 0x0100:
> +    case 0x0400:
> +    case 0x0a00:
> +    case 0x0c00:
> +    case 0x0d00:
> +    case 0x0f00:
> +        return 6;
> +    /* BroadWell, CherryView, SkyLake, KabyLake */
> +    case 0x1600:
> +    case 0x1900:
> +    case 0x2200:
> +    case 0x5900:
> +        return 8;
> +    }
> +
> +    return 8; /* Assume newer is compatible */
> +}
> +

This link:
https://github.com/01org/Igvtg-qemu/commit/ea32e6769004d6eb98d2dbd859d81bf1885c6ad2#diff-9d4d99332b83a7de33cbeed489d60448R920

happened to land in my inbox these days.  It provides a bunch of
functions called is_$codename() and intel_gen_version().  Looks more
complete to me.  Maybe we should pick up them and find a place in the
qemu source tree where both vfio and intel-vgpu (and maybe xen device
assignment too) can share those functions?

cheers,
  Gerd


WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org, allen.m.kay@intel.com,
	kvm@vger.kernel.org, "Zhao, Xinda" <xinda.zhao@intel.com>,
	Kevin Tian <kevin.tian@intel.com>
Subject: Re: [Qemu-devel] [PATCH v6 6/8] vfio/pci: Intel graphics legacy mode assignment
Date: Wed, 18 May 2016 16:21:58 +0200	[thread overview]
Message-ID: <1463581318.30045.66.camel@redhat.com> (raw)
In-Reply-To: <20160517201955.6175.97671.stgit@gimli.home>

On Di, 2016-05-17 at 14:19 -0600, Alex Williamson wrote:
> +static int igd_gen(VFIOPCIDevice *vdev)
> +{
> +    if ((vdev->device_id & 0xfff) == 0xa84) {
> +        return 8; /* Broxton */
> +    }
> +
> +    switch (vdev->device_id & 0xff00) {
> +    /* Old, untested, unavailable, unknown */
> +    case 0x0000:
> +    case 0x2500:
> +    case 0x2700:
> +    case 0x2900:
> +    case 0x2a00:
> +    case 0x2e00:
> +    case 0x3500:
> +    case 0xa000:
> +        return -1;
> +    /* SandyBridge, IvyBridge, ValleyView, Haswell */
> +    case 0x0100:
> +    case 0x0400:
> +    case 0x0a00:
> +    case 0x0c00:
> +    case 0x0d00:
> +    case 0x0f00:
> +        return 6;
> +    /* BroadWell, CherryView, SkyLake, KabyLake */
> +    case 0x1600:
> +    case 0x1900:
> +    case 0x2200:
> +    case 0x5900:
> +        return 8;
> +    }
> +
> +    return 8; /* Assume newer is compatible */
> +}
> +

This link:
https://github.com/01org/Igvtg-qemu/commit/ea32e6769004d6eb98d2dbd859d81bf1885c6ad2#diff-9d4d99332b83a7de33cbeed489d60448R920

happened to land in my inbox these days.  It provides a bunch of
functions called is_$codename() and intel_gen_version().  Looks more
complete to me.  Maybe we should pick up them and find a place in the
qemu source tree where both vfio and intel-vgpu (and maybe xen device
assignment too) can share those functions?

cheers,
  Gerd

  reply	other threads:[~2016-05-18 14:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 20:19 [PATCH v6 0/8] Series short description Alex Williamson
2016-05-17 20:19 ` [Qemu-devel] " Alex Williamson
2016-05-17 20:19 ` [PATCH v6 1/8] vfio: Enable sparse mmap capability Alex Williamson
2016-05-17 20:19   ` [Qemu-devel] " Alex Williamson
2016-05-17 20:19 ` [PATCH v6 2/8] vfio: Create device specific region info helper Alex Williamson
2016-05-17 20:19   ` [Qemu-devel] " Alex Williamson
2016-05-17 20:19 ` [PATCH v6 3/8] vfio/pci: Fix return of vfio_populate_vga() Alex Williamson
2016-05-17 20:19   ` [Qemu-devel] " Alex Williamson
2016-05-17 20:19 ` [PATCH v6 4/8] vfio/pci: Consolidate VGA setup Alex Williamson
2016-05-17 20:19   ` [Qemu-devel] " Alex Williamson
2016-05-17 20:19 ` [PATCH v6 5/8] vfio/pci: Setup BAR quirks after capabilities probing Alex Williamson
2016-05-17 20:19   ` [Qemu-devel] " Alex Williamson
2016-05-17 20:19 ` [PATCH v6 6/8] vfio/pci: Intel graphics legacy mode assignment Alex Williamson
2016-05-17 20:19   ` [Qemu-devel] " Alex Williamson
2016-05-18 14:21   ` Gerd Hoffmann [this message]
2016-05-18 14:21     ` Gerd Hoffmann
2016-05-18 16:50     ` Alex Williamson
2016-05-18 16:50       ` [Qemu-devel] " Alex Williamson
2016-05-17 20:20 ` [PATCH v6 7/8] vfio/pci: Add a separate option for IGD OpRegion support Alex Williamson
2016-05-17 20:20   ` [Qemu-devel] " Alex Williamson
2016-05-17 20:20 ` [PATCH v6 8/8] vfio/pci: Add IGD documentation Alex Williamson
2016-05-17 20:20   ` [Qemu-devel] " Alex Williamson
2016-05-18  2:23   ` Eric Blake
2016-05-18 18:35     ` Alex Williamson
2016-05-18 19:28       ` Eric Blake
2016-05-17 20:42 ` vfio IGD assignment (was Re: [PATCH v6 0/8] Series short description) Alex Williamson
2016-05-17 20:42   ` [Qemu-devel] " Alex Williamson
2016-05-18 14:24   ` Gerd Hoffmann
2016-05-18 14:24     ` [Qemu-devel] " Gerd Hoffmann
2016-05-18 18:45     ` Alex Williamson
2016-05-19  9:00       ` Gerd Hoffmann
2016-05-20 12:19       ` Gerd Hoffmann
2016-05-20 15:08         ` Alex Williamson
2016-05-23 13:34           ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463581318.30045.66.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=allen.m.kay@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=xinda.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.