From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"jack@suse.cz" <jack@suse.cz>,
"david@fromorbit.com" <david@fromorbit.com>,
"sandeen@sandeen.net" <sandeen@sandeen.net>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Cc: "Parrish, Micah (HP Servers Linux R&D)" <micah.parrish@hpe.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"axboe@fb.com" <axboe@fb.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"tytso@mit.edu" <tytso@mit.edu>,
"boaz@plexistor.com" <boaz@plexistor.com>
Subject: Re: [PATCH v4 0/6] Add alignment check for DAX mount
Date: Fri, 20 May 2016 17:49:51 +0000 [thread overview]
Message-ID: <1463766042.32042.34.camel@hpe.com> (raw)
In-Reply-To: <1463765696.3005.2.camel@intel.com>
T24gRnJpLCAyMDE2LTA1LTIwIGF0IDE3OjM0ICswMDAwLCBWZXJtYSwgVmlzaGFsIEwgd3JvdGU6
DQo+IE9uIEZyaSwgMjAxNi0wNS0yMCBhdCAxNDo1MCArMDAwMCwgS2FuaSwgVG9zaGltaXRzdSB3
cm90ZToNCj4gPiBPbiBUaHUsIDIwMTYtMDUtMTkgYXQgMTg6MzcgLTA1MDAsIEVyaWMgU2FuZGVl
biB3cm90ZToNCj4gPiA+IE9uIDUvMTAvMTYgMTE6MjMgQU0sIFRvc2hpIEthbmkgd3JvdGU6DQo+
ID4gPiA+wqANCj4gPiA+ID4gV2hlbiBhIHBhcnRpdGlvbiBpcyBub3QgYWxpZ25lZCBieSA0S0Is
IG1vdW50IC1vIGRheCBzdWNjZWVkcywNCj4gPiA+DQo+ID4gPiBTb3JyeSBmb3IgYmVpbmcgbGF0
ZSwgYnV0IC0NCj4gPiA+IA0KPiA+ID4gU2hvdWxkbid0IHRoaXMgYW5kIGFsbCBzdWJzZXF1ZW50
IHBhdGNoIGNvbW1pdHMgcmVmZXIgdG8NCj4gPiA+IFBBR0VfU0laRSwgcmF0aGVyIHRoYW4gIjRr
Qj8iDQo+ID4NCj4gPiBSaWdodCwgdGhlIHBhdGNoIGNvbW1pdHMgc2hvdWxkIHJlZmVyIHRvIFBB
R0VfU0laRSB0byBtYXRjaCB3aXRoIHRoZQ0KPiA+IGNvZGUgY2hhbmdlcy7CoMKgSSBhbSBhZnJh
aWQgaXQgbWF5IGJlIGEgYml0IHRvbyBsYXRlIHRvIHVwZGF0ZSwNCj4gPiB0aG91Z2guLi4NCj4g
PiANCj4gPiBWaXNoYWwsIGRvIHlvdSB0aGluayB5b3UgY2FuIHR3ZWFrIHRoZSBsb2dzLCAiNEtC
IiB0byAiUEFHRV9TSVpFIj8NCj4gPiANCj4gPiBUaGFua3MsDQo+ID4gLVRvc2hpDQo+DQo+IEhp
IFRvc2hpLA0KPiANCj4gSXMgaXQganVzdCBjb21taXQgbWVzc2FnZSBjaGFuZ2VzPyBJZiBzbyBJ
J20gbm90IHN1cmUgaXQgaXMgd29ydGh3aGlsZQ0KPiB0byByZWJhc2UgZXZlcnl0aGluZyBmb3Ig
dGhhdCAtIGkuZS4gbXkgZGF4IGVycm9yIGhhbmRsaW5nIHNlcmllcyBhbmQNCj4gUm9zcycgZGF4
LWxvY2tpbmcgYnJhbmNoIHdvdWxkIGJvdGggaGF2ZSB0byBiZSByZWJhc2VkLi4NCj4gDQo+IElm
IHRoZXJlIGFyZSBhbmQgZml4ZXMgZm9yIGNvZGUsIHdlIGNhbiBkbyB0aGVtIGFzIGFuIGFkZC1v
biBwYXRjaA0KPiB0aG91Z2guDQoNCkhpIFZpc2hhbCwNCg0KWWVzLCBpdCBpcyBqdXN0IGNvbW1p
dCBtZXNzYWdlcywgYW5kIGl0J3MgT0sgbm90IHRvIG1ha2UgdGhpcyBjaGFuZ2UuDQoNClRoYW5r
cywNCi1Ub3NoaQ==
WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"jack@suse.cz" <jack@suse.cz>,
"david@fromorbit.com" <david@fromorbit.com>,
"sandeen@sandeen.net" <sandeen@sandeen.net>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"tytso@mit.edu" <tytso@mit.edu>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"axboe@fb.com" <axboe@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Parrish,
Micah \\ linux-block@vger.kernel.org (HP Servers Linux R&D)\"
<micah.parrish@hpe.com>,)" <linux-block@vger.kernel.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v4 0/6] Add alignment check for DAX mount
Date: Fri, 20 May 2016 17:49:51 +0000 [thread overview]
Message-ID: <1463766042.32042.34.camel@hpe.com> (raw)
In-Reply-To: <1463765696.3005.2.camel@intel.com>
On Fri, 2016-05-20 at 17:34 +0000, Verma, Vishal L wrote:
> On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote:
> > On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote:
> > > On 5/10/16 11:23 AM, Toshi Kani wrote:
> > > >
> > > > When a partition is not aligned by 4KB, mount -o dax succeeds,
> > >
> > > Sorry for being late, but -
> > >
> > > Shouldn't this and all subsequent patch commits refer to
> > > PAGE_SIZE, rather than "4kB?"
> >
> > Right, the patch commits should refer to PAGE_SIZE to match with the
> > code changes. I am afraid it may be a bit too late to update,
> > though...
> >
> > Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"?
> >
> > Thanks,
> > -Toshi
>
> Hi Toshi,
>
> Is it just commit message changes? If so I'm not sure it is worthwhile
> to rebase everything for that - i.e. my dax error handling series and
> Ross' dax-locking branch would both have to be rebased..
>
> If there are and fixes for code, we can do them as an add-on patch
> though.
Hi Vishal,
Yes, it is just commit messages, and it's OK not to make this change.
Thanks,
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"jack@suse.cz" <jack@suse.cz>,
"david@fromorbit.com" <david@fromorbit.com>,
"sandeen@sandeen.net" <sandeen@sandeen.net>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Cc: "Parrish, Micah (HP Servers Linux R&D)" <micah.parrish@hpe.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"axboe@fb.com" <axboe@fb.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"tytso@mit.edu" <tytso@mit.edu>,
"boaz@plexistor.com" <boaz@plexistor.com>
Subject: Re: [PATCH v4 0/6] Add alignment check for DAX mount
Date: Fri, 20 May 2016 17:49:51 +0000 [thread overview]
Message-ID: <1463766042.32042.34.camel@hpe.com> (raw)
In-Reply-To: <1463765696.3005.2.camel@intel.com>
On Fri, 2016-05-20 at 17:34 +0000, Verma, Vishal L wrote:
> On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote:
> > On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote:
> > > On 5/10/16 11:23 AM, Toshi Kani wrote:
> > > >
> > > > When a partition is not aligned by 4KB, mount -o dax succeeds,
> > >
> > > Sorry for being late, but -
> > >
> > > Shouldn't this and all subsequent patch commits refer to
> > > PAGE_SIZE, rather than "4kB?"
> >
> > Right, the patch commits should refer to PAGE_SIZE to match with the
> > code changes. I am afraid it may be a bit too late to update,
> > though...
> >
> > Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"?
> >
> > Thanks,
> > -Toshi
>
> Hi Toshi,
>
> Is it just commit message changes? If so I'm not sure it is worthwhile
> to rebase everything for that - i.e. my dax error handling series and
> Ross' dax-locking branch would both have to be rebased..
>
> If there are and fixes for code, we can do them as an add-on patch
> though.
Hi Vishal,
Yes, it is just commit messages, and it's OK not to make this change.
Thanks,
-Toshi
WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"jack@suse.cz" <jack@suse.cz>,
"david@fromorbit.com" <david@fromorbit.com>,
"sandeen@sandeen.net" <sandeen@sandeen.net>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Cc: "Parrish, Micah (HP Servers Linux R&D)" <micah.parrish@hpe.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"axboe@fb.com" <axboe@fb.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
"tytso@mit.edu" <tytso@mit.edu>,
"boaz@plexistor.com" <boaz@plexistor.com>
Subject: Re: [PATCH v4 0/6] Add alignment check for DAX mount
Date: Fri, 20 May 2016 17:49:51 +0000 [thread overview]
Message-ID: <1463766042.32042.34.camel@hpe.com> (raw)
In-Reply-To: <1463765696.3005.2.camel@intel.com>
On Fri, 2016-05-20 at 17:34 +0000, Verma, Vishal L wrote:
> On Fri, 2016-05-20 at 14:50 +0000, Kani, Toshimitsu wrote:
> > On Thu, 2016-05-19 at 18:37 -0500, Eric Sandeen wrote:
> > > On 5/10/16 11:23 AM, Toshi Kani wrote:
> > > >
> > > > When a partition is not aligned by 4KB, mount -o dax succeeds,
> > >
> > > Sorry for being late, but -
> > >
> > > Shouldn't this and all subsequent patch commits refer to
> > > PAGE_SIZE, rather than "4kB?"
> >
> > Right, the patch commits should refer to PAGE_SIZE to match with the
> > code changes. I am afraid it may be a bit too late to update,
> > though...
> >
> > Vishal, do you think you can tweak the logs, "4KB" to "PAGE_SIZE"?
> >
> > Thanks,
> > -Toshi
>
> Hi Toshi,
>
> Is it just commit message changes? If so I'm not sure it is worthwhile
> to rebase everything for that - i.e. my dax error handling series and
> Ross' dax-locking branch would both have to be rebased..
>
> If there are and fixes for code, we can do them as an add-on patch
> though.
Hi Vishal,
Yes, it is just commit messages, and it's OK not to make this change.
Thanks,
-Toshi
next prev parent reply other threads:[~2016-05-20 17:49 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 16:23 [PATCH v4 0/6] Add alignment check for DAX mount Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 1/6] block: Add vfs_msg() interface Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 2/6] block: Add bdev_dax_supported() for dax mount checks Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 3/6] ext4: Add alignment check for DAX mount Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 4/6] ext2: " Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 5/6] xfs: " Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` [PATCH v4 6/6] block: Update blkdev_dax_capable() for consistency Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 16:23 ` Toshi Kani
2016-05-10 19:49 ` Dan Williams
2016-05-10 19:49 ` Dan Williams
2016-05-10 19:49 ` Dan Williams
2016-05-10 21:36 ` Toshi Kani
2016-05-10 21:36 ` Toshi Kani
2016-05-10 21:36 ` Toshi Kani
2016-05-11 8:05 ` Jan Kara
2016-05-11 8:05 ` Jan Kara
2016-05-11 8:05 ` Jan Kara
2016-05-11 14:25 ` Toshi Kani
2016-05-11 14:25 ` Toshi Kani
2016-05-11 14:25 ` Toshi Kani
2016-05-11 15:26 ` Jan Kara
2016-05-11 15:26 ` Jan Kara
2016-05-11 15:26 ` Jan Kara
2016-05-17 22:07 ` Dan Williams
2016-05-17 22:07 ` Dan Williams
2016-05-17 22:07 ` Dan Williams
2016-05-17 23:02 ` Toshi Kani
2016-05-18 7:54 ` [PATCH] remove unused blkdev_dax_capable() function Arnd Bergmann
2016-05-18 7:54 ` Arnd Bergmann
2016-05-18 14:01 ` Toshi Kani
2016-05-18 14:01 ` Toshi Kani
2016-05-18 14:01 ` Toshi Kani
2016-05-18 19:30 ` Vishal Verma
2016-05-18 19:30 ` Vishal Verma
2016-05-18 19:30 ` Vishal Verma
2016-05-20 11:32 ` kbuild test robot
2016-05-20 11:32 ` kbuild test robot
2016-05-20 11:32 ` kbuild test robot
2016-05-20 15:48 ` Kani, Toshimitsu
2016-05-20 15:48 ` Kani, Toshimitsu
2016-05-20 15:48 ` Kani, Toshimitsu
2016-05-20 15:48 ` Kani, Toshimitsu
2016-05-11 13:20 ` [PATCH v4 0/6] Add alignment check for DAX mount Carlos Maiolino
2016-05-19 23:37 ` Eric Sandeen
2016-05-19 23:37 ` Eric Sandeen
2016-05-19 23:37 ` Eric Sandeen
2016-05-20 14:50 ` Kani, Toshimitsu
2016-05-20 14:50 ` Kani, Toshimitsu
2016-05-20 14:50 ` Kani, Toshimitsu
2016-05-20 14:50 ` Kani, Toshimitsu
2016-05-20 17:34 ` Verma, Vishal L
2016-05-20 17:34 ` Verma, Vishal L
2016-05-20 17:34 ` Verma, Vishal L
2016-05-20 17:34 ` Verma, Vishal L
2016-05-20 17:49 ` Kani, Toshimitsu [this message]
2016-05-20 17:49 ` Kani, Toshimitsu
2016-05-20 17:49 ` Kani, Toshimitsu
2016-05-20 17:49 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463766042.32042.34.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@fb.com \
--cc=boaz@plexistor.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=micah.parrish@hpe.com \
--cc=ross.zwisler@linux.intel.com \
--cc=sandeen@sandeen.net \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.