All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shajakhan, Mohammed Shafi (Mohammed Shafi)" <mohammed@qti.qualcomm.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>,
	Sven Eckelmann <sven.eckelmann@open-mesh.com>
Cc: "Valo, Kalle" <kvalo@qca.qualcomm.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update
Date: Tue, 31 May 2016 06:36:48 +0000	[thread overview]
Message-ID: <1464676666571.16234@qti.qualcomm.com> (raw)
In-Reply-To: <20160527090649.GA14846@atheros-ThinkPad-T61>

Hi Sven / Kalle,

seems the change got merged in pending branch
https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=2a872321e07506e339fc1b3ca81aa3e88628cd6e

Request if you can send the patch to address this(incase the patch cannot be dropped)
and the v2 version cannot be picked

regards,
shafi
________________________________________
From: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Sent: 27 May 2016 14:36
To: Sven Eckelmann
Cc: Shajakhan, Mohammed Shafi (Mohammed Shafi); ath10k@lists.infradead.org; linux-wireless@vger.kernel.org; Valo, Kalle
Subject: Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update

On Fri, May 27, 2016 at 10:12:45AM +0200, Sven Eckelmann wrote:
> On Wednesday 11 May 2016 11:54:30 Mohammed Shafi Shajakhan wrote:
> >  #else
> > -static inline void ath10k_sta_update_rx_duration(struct ath10k *ar,
> > -                                            struct list_head *peer)
> > +static inline
> > +void ath10k_sta_update_rx_duration(struct ath10k *ar,
> > +                              struct ath10k_fw_stats *stats);
> >  {
> >  }
>
> Please remove the ";" for the "static inline" version. I can also
> submit a patch in case patches in ath.git/pending cannot be dropped
> anymore.

[shafi] thanks a lot fixed it ! sorry for the typo, sent a v2 for
the same, kindly review the same.

>
> Kind regards,
>       Sven



_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: "Shajakhan, Mohammed Shafi (Mohammed Shafi)" <mohammed@qti.qualcomm.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>,
	Sven Eckelmann <sven.eckelmann@open-mesh.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Valo, Kalle" <kvalo@qca.qualcomm.com>
Subject: Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update
Date: Tue, 31 May 2016 06:36:48 +0000	[thread overview]
Message-ID: <1464676666571.16234@qti.qualcomm.com> (raw)
In-Reply-To: <20160527090649.GA14846@atheros-ThinkPad-T61>

Hi Sven / Kalle,

seems the change got merged in pending branch
https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=2a872321e07506e339fc1b3ca81aa3e88628cd6e

Request if you can send the patch to address this(incase the patch cannot be dropped)
and the v2 version cannot be picked

regards,
shafi
________________________________________
From: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Sent: 27 May 2016 14:36
To: Sven Eckelmann
Cc: Shajakhan, Mohammed Shafi (Mohammed Shafi); ath10k@lists.infradead.org; linux-wireless@vger.kernel.org; Valo, Kalle
Subject: Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update

On Fri, May 27, 2016 at 10:12:45AM +0200, Sven Eckelmann wrote:
> On Wednesday 11 May 2016 11:54:30 Mohammed Shafi Shajakhan wrote:
> >  #else
> > -static inline void ath10k_sta_update_rx_duration(struct ath10k *ar,
> > -                                            struct list_head *peer)
> > +static inline
> > +void ath10k_sta_update_rx_duration(struct ath10k *ar,
> > +                              struct ath10k_fw_stats *stats);
> >  {
> >  }
>
> Please remove the ";" for the "static inline" version. I can also
> submit a patch in case patches in ath.git/pending cannot be dropped
> anymore.

[shafi] thanks a lot fixed it ! sorry for the typo, sent a v2 for
the same, kindly review the same.

>
> Kind regards,
>       Sven



  reply	other threads:[~2016-05-31  6:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11  6:24 [PATCH v1] ath10k: Fix 10.4 extended peer stats update Mohammed Shafi Shajakhan
2016-05-11  6:24 ` Mohammed Shafi Shajakhan
2016-05-27  8:12 ` Sven Eckelmann
2016-05-27  8:12   ` Sven Eckelmann
2016-05-27  9:06   ` Mohammed Shafi Shajakhan
2016-05-27  9:06     ` Mohammed Shafi Shajakhan
2016-05-31  6:36     ` Shajakhan, Mohammed Shafi (Mohammed Shafi) [this message]
2016-05-31  6:36       ` Shajakhan, Mohammed Shafi (Mohammed Shafi)
2016-05-31 11:09       ` Valo, Kalle
2016-05-31 11:09         ` Valo, Kalle
2016-05-31 12:53         ` Mohammed Shafi Shajakhan
2016-05-31 12:53           ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464676666571.16234@qti.qualcomm.com \
    --to=mohammed@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mohammed@codeaurora.org \
    --cc=sven.eckelmann@open-mesh.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.