Re: [RFC 0/4] Intel Integrated Sensor Hub Support (ISH)

[Atri Bhattacharya <badshah400@aim.com>]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Thu, 2016-06-02 at 13:00 -0700, Srinivas Pandruvada wrote:
> 
> I see. Can you add the following change and try?
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index e4d00d2..f241e1f 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -199,6 +199,7 @@ static int ish_resume(struct device *device)
>         struct ishtp_device *dev = pci_get_drvdata(pdev);
>  
>         disable_irq_wake(pdev->irq);
> +       ish_hw_start(dev);
>         ishtp_send_resume(dev);
>         dev->suspend_flag = 0;
> 
> 
> 

This patch causes a kernel crash reliably when trying to wakeup from
suspending laptop a second time during a single boot session. Journal
logs attached. 

-- 
Atri Bhattacharya
Fri  3 Jun 05:01:36 CEST 2016

Sent from openSUSE Tumbleweed (20160531) (x86_64) on my laptop.

[-- Attachment #2: journal_suspend_bad2.log.tar.gz --]
[-- Type: application/x-compressed-tar, Size: 25906 bytes --]