From: roy.qing.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
To: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
vdavydov-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org
Subject: [PATCH] mm: memcontrol: remove BUG_ON in uncharge_list
Date: Wed, 8 Jun 2016 15:00:48 +0800 [thread overview]
Message-ID: <1465369248-13865-1-git-send-email-roy.qing.li@gmail.com> (raw)
From: Li RongQing <roy.qing.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
when call uncharge_list, if a page is transparent huge, and not need to
BUG_ON about non-transparent huge, since nobody should be be seeing the
page at this stage and this page cannot be raced with a THP split up
Signed-off-by: Li RongQing <roy.qing.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
mm/memcontrol.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 4d9a215..d7a56f1 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -5457,7 +5457,6 @@ static void uncharge_list(struct list_head *page_list)
if (PageTransHuge(page)) {
nr_pages <<= compound_order(page);
- VM_BUG_ON_PAGE(!PageTransHuge(page), page);
nr_huge += nr_pages;
}
--
2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: roy.qing.li@gmail.com
To: cgroups@vger.kernel.org, linux-mm@kvack.org
Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov@virtuozzo.com
Subject: [PATCH] mm: memcontrol: remove BUG_ON in uncharge_list
Date: Wed, 8 Jun 2016 15:00:48 +0800 [thread overview]
Message-ID: <1465369248-13865-1-git-send-email-roy.qing.li@gmail.com> (raw)
From: Li RongQing <roy.qing.li@gmail.com>
when call uncharge_list, if a page is transparent huge, and not need to
BUG_ON about non-transparent huge, since nobody should be be seeing the
page at this stage and this page cannot be raced with a THP split up
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
mm/memcontrol.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 4d9a215..d7a56f1 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -5457,7 +5457,6 @@ static void uncharge_list(struct list_head *page_list)
if (PageTransHuge(page)) {
nr_pages <<= compound_order(page);
- VM_BUG_ON_PAGE(!PageTransHuge(page), page);
nr_huge += nr_pages;
}
--
2.1.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-06-08 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 7:00 roy.qing.li-Re5JQEeQqe8AvxtiuMwx3w [this message]
2016-06-08 7:00 ` [PATCH] mm: memcontrol: remove BUG_ON in uncharge_list roy.qing.li
[not found] ` <1465369248-13865-1-git-send-email-roy.qing.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-08 7:25 ` Michal Hocko
2016-06-08 7:25 ` Michal Hocko
2016-06-08 14:58 ` Johannes Weiner
[not found] ` <20160608145833.GA6727-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2016-06-08 15:06 ` Michal Hocko
2016-06-08 15:06 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465369248-13865-1-git-send-email-roy.qing.li@gmail.com \
--to=roy.qing.li-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vdavydov-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.