From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] fm10k: restore D0 power state upon probe
Date: Thu, 9 Jun 2016 18:57:18 +0000 [thread overview]
Message-ID: <1465498638.11216.1.camel@intel.com> (raw)
In-Reply-To: <CAKgT0UdFekv7wKshpuq-VqO6YZR-98aG1FB2oS-4Vz3OrV3m8Q@mail.gmail.com>
On Thu, 2016-06-09 at 10:54 -0700, Alexander Duyck wrote:
> No, it will but you have to actually be re-enabling the device to
> trigger it.
>
> You might try replacing the call to pci_enable_device_mem with
> pci_reenable_device and see if that works for you.??I suspect this is
> probably a bug that is common in many of the drivers out there.
>
> - Alex
Changing the pci_enable_device_mem() to a pci_reenable_device() inside
the .io_slot_reset seems to have worked, and is much cleaner than my
alternative approach. I think this is the right way since we aren't
really wanting to disable the device in this section and matches up
with what the .slot_reset wants without breaking other flows.
I'll have a patch for that in a bit.
Thanks,
Jake
prev parent reply other threads:[~2016-06-09 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 0:20 [Intel-wired-lan] [PATCH] fm10k: restore D0 power state upon probe Jacob Keller
2016-06-08 3:54 ` Alexander Duyck
2016-06-08 19:11 ` Keller, Jacob E
2016-06-08 21:02 ` Alexander Duyck
2016-06-08 21:18 ` Keller, Jacob E
2016-06-08 21:22 ` Alexander Duyck
2016-06-08 21:23 ` Keller, Jacob E
2016-06-08 21:33 ` Alexander Duyck
2016-06-08 21:46 ` Keller, Jacob E
2016-06-09 17:24 ` Keller, Jacob E
2016-06-09 17:31 ` Keller, Jacob E
2016-06-09 17:38 ` Keller, Jacob E
2016-06-09 17:54 ` Alexander Duyck
2016-06-09 18:30 ` Keller, Jacob E
2016-06-09 18:57 ` Keller, Jacob E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465498638.11216.1.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.