All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Eric Biederman <ebiederm@xmission.com>
Subject: [PATCH 1/8] kexec_file: Remove unused members from struct kexec_buf.
Date: Sun, 12 Jun 2016 00:10:15 -0300	[thread overview]
Message-ID: <1465701022-11601-2-git-send-email-bauerman@linux.vnet.ibm.com> (raw)
In-Reply-To: <1465701022-11601-1-git-send-email-bauerman@linux.vnet.ibm.com>

kexec_add_buffer uses kexec_buf.buffer and kexec_buf.bufsz to pass along
its own arguments buffer and bufsz, but since they aren't used anywhere
else, it's pointless.

Cc: Eric Biederman <ebiederm@xmission.com>
Cc: kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 kernel/kexec_file.c     | 6 ++----
 kernel/kexec_internal.h | 2 --
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index 01ab82a40d22..b6eec7527e9f 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -464,8 +464,6 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz,
 	memset(&buf, 0, sizeof(struct kexec_buf));
 	kbuf = &buf;
 	kbuf->image = image;
-	kbuf->buffer = buffer;
-	kbuf->bufsz = bufsz;
 
 	kbuf->memsz = ALIGN(memsz, PAGE_SIZE);
 	kbuf->buf_align = max(buf_align, PAGE_SIZE);
@@ -489,8 +487,8 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz,
 
 	/* Found a suitable memory range */
 	ksegment = &image->segment[image->nr_segments];
-	ksegment->kbuf = kbuf->buffer;
-	ksegment->bufsz = kbuf->bufsz;
+	ksegment->kbuf = buffer;
+	ksegment->bufsz = bufsz;
 	ksegment->mem = kbuf->mem;
 	ksegment->memsz = kbuf->memsz;
 	image->nr_segments++;
diff --git a/kernel/kexec_internal.h b/kernel/kexec_internal.h
index 0a52315d9c62..eefd5bf960c2 100644
--- a/kernel/kexec_internal.h
+++ b/kernel/kexec_internal.h
@@ -26,8 +26,6 @@ struct kexec_sha_region {
  */
 struct kexec_buf {
 	struct kimage *image;
-	char *buffer;
-	unsigned long bufsz;
 	unsigned long mem;
 	unsigned long memsz;
 	unsigned long buf_align;
-- 
1.9.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
	Eric Biederman <ebiederm@xmission.com>
Subject: [PATCH 1/8] kexec_file: Remove unused members from struct kexec_buf.
Date: Sun, 12 Jun 2016 00:10:15 -0300	[thread overview]
Message-ID: <1465701022-11601-2-git-send-email-bauerman@linux.vnet.ibm.com> (raw)
In-Reply-To: <1465701022-11601-1-git-send-email-bauerman@linux.vnet.ibm.com>

kexec_add_buffer uses kexec_buf.buffer and kexec_buf.bufsz to pass along
its own arguments buffer and bufsz, but since they aren't used anywhere
else, it's pointless.

Cc: Eric Biederman <ebiederm@xmission.com>
Cc: kexec@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 kernel/kexec_file.c     | 6 ++----
 kernel/kexec_internal.h | 2 --
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index 01ab82a40d22..b6eec7527e9f 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -464,8 +464,6 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz,
 	memset(&buf, 0, sizeof(struct kexec_buf));
 	kbuf = &buf;
 	kbuf->image = image;
-	kbuf->buffer = buffer;
-	kbuf->bufsz = bufsz;
 
 	kbuf->memsz = ALIGN(memsz, PAGE_SIZE);
 	kbuf->buf_align = max(buf_align, PAGE_SIZE);
@@ -489,8 +487,8 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz,
 
 	/* Found a suitable memory range */
 	ksegment = &image->segment[image->nr_segments];
-	ksegment->kbuf = kbuf->buffer;
-	ksegment->bufsz = kbuf->bufsz;
+	ksegment->kbuf = buffer;
+	ksegment->bufsz = bufsz;
 	ksegment->mem = kbuf->mem;
 	ksegment->memsz = kbuf->memsz;
 	image->nr_segments++;
diff --git a/kernel/kexec_internal.h b/kernel/kexec_internal.h
index 0a52315d9c62..eefd5bf960c2 100644
--- a/kernel/kexec_internal.h
+++ b/kernel/kexec_internal.h
@@ -26,8 +26,6 @@ struct kexec_sha_region {
  */
 struct kexec_buf {
 	struct kimage *image;
-	char *buffer;
-	unsigned long bufsz;
 	unsigned long mem;
 	unsigned long memsz;
 	unsigned long buf_align;
-- 
1.9.1

  reply	other threads:[~2016-06-12  3:11 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12  3:10 [PATCH 0/8] kexec_file_load implementation for PowerPC Thiago Jung Bauermann
2016-06-12  3:10 ` Thiago Jung Bauermann
2016-06-12  3:10 ` Thiago Jung Bauermann [this message]
2016-06-12  3:10   ` [PATCH 1/8] kexec_file: Remove unused members from struct kexec_buf Thiago Jung Bauermann
2016-06-13  7:05   ` Dave Young
2016-06-13  7:05     ` Dave Young
2016-06-12  3:10 ` [PATCH 2/8] kexec_file: Generalize kexec_add_buffer Thiago Jung Bauermann
2016-06-12  3:10   ` Thiago Jung Bauermann
2016-06-13  7:12   ` Dave Young
2016-06-13  7:12     ` Dave Young
2016-06-13  7:29   ` Dave Young
2016-06-13  7:29     ` Dave Young
2016-06-13 19:08     ` Thiago Jung Bauermann
2016-06-13 19:08       ` Thiago Jung Bauermann
2016-06-13 20:40       ` Thiago Jung Bauermann
2016-06-13 20:40         ` Thiago Jung Bauermann
2016-06-14  1:22       ` Dave Young
2016-06-14  1:22         ` Dave Young
2016-06-12  3:10 ` [PATCH 3/8] powerpc: Factor out relocation code from module_64.c to elf_util_64.c Thiago Jung Bauermann
2016-06-12  3:10   ` Thiago Jung Bauermann
2016-06-12  3:10 ` [PATCH 4/8] powerpc: Generalize elf64_apply_relocate_add Thiago Jung Bauermann
2016-06-12  3:10   ` Thiago Jung Bauermann
2016-06-12  3:10 ` [PATCH 5/8] powerpc: Add functions to read ELF files of any endianness Thiago Jung Bauermann
2016-06-12  3:10   ` Thiago Jung Bauermann
2016-06-12  3:10 ` [PATCH 6/8] powerpc: Implement kexec_file_load Thiago Jung Bauermann
2016-06-12  3:10   ` Thiago Jung Bauermann
2016-06-12  3:10 ` [PATCH 7/8] powerpc: Add support for loading ELF kernels with kexec_file_load Thiago Jung Bauermann
2016-06-12  3:10   ` Thiago Jung Bauermann
2016-06-12  3:10 ` [PATCH 8/8] powerpc: Add purgatory for kexec_file_load implementation Thiago Jung Bauermann
2016-06-12  3:10   ` Thiago Jung Bauermann
2016-06-13  7:02 ` [PATCH 0/8] kexec_file_load implementation for PowerPC Dave Young
2016-06-13  7:02   ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465701022-11601-2-git-send-email-bauerman@linux.vnet.ibm.com \
    --to=bauerman@linux.vnet.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.