All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Tan Jui Nee <jui.nee.tan@intel.com>,
	heikki.krogerus@linux.intel.com, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
	ptyser@xes-inc.com, lee.jones@linaro.org,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	jonathan.yong@intel.com, ong.hock.yu@intel.com,
	weifeng.voon@intel.com, wan.ahmad.zainie.wan.mohamad@intel.com
Subject: Re: [PATCH v3 2/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's
Date: Mon, 13 Jun 2016 18:19:12 +0300	[thread overview]
Message-ID: <1465831152.30123.21.camel@linux.intel.com> (raw)
In-Reply-To: <20160613142514.GA1740@lahna.fi.intel.com>

On Mon, 2016-06-13 at 17:25 +0300, Mika Westerberg wrote:
> On Mon, Jun 13, 2016 at 04:54:31PM +0300, Andy Shevchenko wrote:
> > Would work to me, though still the same question: is it possible to
> > avoid building it on even most of Intel platforms, since there, I
> > assume, will be not many users of the module?
> 
> Well, even if you make it configurable via Kconfig, I guess distros
> will
> have to enable it in order to support as wide range of CPUs as
> possible
> in a single binary.

Good point.

Then perhaps the following we can do:
 - add a static boolean flag
 - add __init function where we check either PCI root bridge ID or CPU
ID (I don't know which one is better, I suppose second one, though it
will require an update of arch/x86/include/asm/intel-family.h)
 - add a check into the function.

What do you think?

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2016-06-13 15:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07  6:55 [PATCH v3 0/3] pinctrl/broxton: enable platform device in the absent of ACPI enumeration Tan Jui Nee
2016-06-07  6:55 ` [PATCH v3 1/3] " Tan Jui Nee
2016-06-09 14:01   ` Mika Westerberg
2016-06-14  7:08   ` Linus Walleij
2016-06-21  5:02     ` Tan, Jui Nee
2016-06-07  6:55 ` [PATCH v3 2/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's Tan Jui Nee
2016-06-09 14:05   ` Mika Westerberg
2016-06-13 13:54     ` Andy Shevchenko
2016-06-13 13:54       ` Andy Shevchenko
2016-06-13 14:25       ` Mika Westerberg
2016-06-13 15:19         ` Andy Shevchenko [this message]
2016-06-13 15:59           ` Mika Westerberg
2016-06-13 15:59             ` Mika Westerberg
2016-06-21  5:03             ` Tan, Jui Nee
2016-06-21  7:23               ` Mika Westerberg
2016-06-28  7:44                 ` Tan, Jui Nee
2016-06-07  6:55 ` [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system Tan Jui Nee
2016-06-09 15:55   ` Lee Jones
2016-06-21  5:02     ` Tan, Jui Nee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465831152.30123.21.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jonathan.yong@intel.com \
    --cc=jui.nee.tan@intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mingo@redhat.com \
    --cc=ong.hock.yu@intel.com \
    --cc=ptyser@xes-inc.com \
    --cc=tglx@linutronix.de \
    --cc=wan.ahmad.zainie.wan.mohamad@intel.com \
    --cc=weifeng.voon@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.