From: mcgrof@kernel.org (Luis R. Rodriguez)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v2 4/5] coccicheck: document how to pass extra options to coccinelle
Date: Tue, 14 Jun 2016 13:05:51 -0700 [thread overview]
Message-ID: <1465934752-13792-5-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1465934752-13792-1-git-send-email-mcgrof@kernel.org>
As an example show how to debug your coccinelle script.
While at it, fix the case when --profile is passed, when
--profile is used we need to ensure --very-quiet is not used.
For instance one can use:
$ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
$ make coccicheck MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
scripts/coccicheck | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index 6d75fd8580a6..c6440138c6ea 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -106,7 +106,26 @@ else
NPROC="$J"
fi
-FLAGS="$SPFLAGS --very-quiet"
+# You can use SPFLAGS to append extra arguments to coccicheck.
+# A good example is if you want to debug your cocci script, you can
+# for instance use the following:
+#
+# $ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
+# $ time make coccicheck MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
+#
+# "--show-trying" should show you what rule is being processed as it goes, if
+# you have issues with a rule getting stuck you can then inspect the file:
+#
+# ${DIR}/coccicheck.$$.err
+#
+# which will have the profile output.
+#
+# --profile will not output if --very-quiet is used, so avoid it.
+if [[ $SPFLAGS == *"--profile"* ]]; then
+ FLAGS="$SPFLAGS"
+else
+ FLAGS="$SPFLAGS --very-quiet"
+fi
# spatch only allows include directories with the syntax "-I include"
# while gcc also allows "-Iinclude" and "-include include"
--
2.8.2
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr,
nicolas.palix@imag.fr, mmarek@suse.com
Cc: linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v2 4/5] coccicheck: document how to pass extra options to coccinelle
Date: Tue, 14 Jun 2016 13:05:51 -0700 [thread overview]
Message-ID: <1465934752-13792-5-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1465934752-13792-1-git-send-email-mcgrof@kernel.org>
As an example show how to debug your coccinelle script.
While at it, fix the case when --profile is passed, when
--profile is used we need to ensure --very-quiet is not used.
For instance one can use:
$ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
$ make coccicheck MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
scripts/coccicheck | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index 6d75fd8580a6..c6440138c6ea 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -106,7 +106,26 @@ else
NPROC="$J"
fi
-FLAGS="$SPFLAGS --very-quiet"
+# You can use SPFLAGS to append extra arguments to coccicheck.
+# A good example is if you want to debug your cocci script, you can
+# for instance use the following:
+#
+# $ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
+# $ time make coccicheck MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
+#
+# "--show-trying" should show you what rule is being processed as it goes, if
+# you have issues with a rule getting stuck you can then inspect the file:
+#
+# ${DIR}/coccicheck.$$.err
+#
+# which will have the profile output.
+#
+# --profile will not output if --very-quiet is used, so avoid it.
+if [[ $SPFLAGS == *"--profile"* ]]; then
+ FLAGS="$SPFLAGS"
+else
+ FLAGS="$SPFLAGS --very-quiet"
+fi
# spatch only allows include directories with the syntax "-I include"
# while gcc also allows "-Iinclude" and "-include include"
--
2.8.2
next prev parent reply other threads:[~2016-06-14 20:05 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 20:05 [Cocci] [PATCH v2 0/5] coccicheck: extend with parmap and indexing heuristics Luis R. Rodriguez
2016-06-14 20:05 ` Luis R. Rodriguez
2016-06-14 20:05 ` [Cocci] [PATCH v2 1/5] coccicheck: enable parmap support Luis R. Rodriguez
2016-06-14 20:05 ` Luis R. Rodriguez
2016-06-14 20:05 ` [Cocci] [PATCH v2 2/5] scripts: add glimpse.sh for indexing the kernel Luis R. Rodriguez
2016-06-14 20:05 ` Luis R. Rodriguez
2016-06-14 20:05 ` [Cocci] [PATCH v2 3/5] coccicheck: add indexing enhancement options Luis R. Rodriguez
2016-06-14 20:05 ` Luis R. Rodriguez
2016-06-14 20:05 ` Luis R. Rodriguez [this message]
2016-06-14 20:05 ` [PATCH v2 4/5] coccicheck: document how to pass extra options to coccinelle Luis R. Rodriguez
2016-06-14 20:05 ` [Cocci] [PATCH v2 5/5] coccicheck: refer to coccicheck bottest wiki for documentation Luis R. Rodriguez
2016-06-14 20:05 ` Luis R. Rodriguez
2016-06-14 20:19 ` [Cocci] [PATCH v2 0/5] coccicheck: extend with parmap and indexing heuristics Luis R. Rodriguez
2016-06-14 20:19 ` Luis R. Rodriguez
2016-06-14 20:23 ` [Cocci] [PATCH v3 0/6] " Luis R. Rodriguez
2016-06-14 20:23 ` Luis R. Rodriguez
2016-06-14 20:23 ` [Cocci] [PATCH v3 1/6] coccicheck: move spatch binary check up Luis R. Rodriguez
2016-06-14 20:23 ` Luis R. Rodriguez
2016-06-14 20:23 ` [Cocci] [PATCH v3 2/6] coccicheck: enable parmap support Luis R. Rodriguez
2016-06-14 20:23 ` Luis R. Rodriguez
2016-06-14 20:23 ` [Cocci] [PATCH v3 3/6] scripts: add glimpse.sh for indexing the kernel Luis R. Rodriguez
2016-06-14 20:23 ` Luis R. Rodriguez
2016-06-15 10:26 ` [Cocci] " SF Markus Elfring
2016-06-15 10:26 ` Aw: " SF Markus Elfring
2016-06-15 18:00 ` Luis R. Rodriguez
2016-06-15 18:00 ` Luis R. Rodriguez
2016-06-15 18:24 ` [Cocci] " SF Markus Elfring
2016-06-15 18:24 ` SF Markus Elfring
2016-06-15 18:43 ` [Cocci] " Luis R. Rodriguez
2016-06-15 18:43 ` Luis R. Rodriguez
2016-06-17 16:05 ` [Cocci] " SF Markus Elfring
2016-06-17 16:05 ` SF Markus Elfring
2016-06-17 17:23 ` [Cocci] " Luis R. Rodriguez
2016-06-17 17:23 ` Luis R. Rodriguez
2016-06-14 20:23 ` [Cocci] [PATCH v3 4/6] coccicheck: add indexing enhancement options Luis R. Rodriguez
2016-06-14 20:23 ` Luis R. Rodriguez
2016-06-15 11:20 ` [Cocci] " SF Markus Elfring
2016-06-15 11:20 ` Aw: " SF Markus Elfring
2016-06-15 20:00 ` Luis R. Rodriguez
2016-06-15 20:00 ` Luis R. Rodriguez
2016-06-14 20:23 ` [Cocci] [PATCH v3 5/6] coccicheck: document how to pass extra options to coccinelle Luis R. Rodriguez
2016-06-14 20:23 ` Luis R. Rodriguez
2016-06-14 20:23 ` [Cocci] [PATCH v3 6/6] coccicheck: refer to coccicheck bottest wiki for documentation Luis R. Rodriguez
2016-06-14 20:23 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465934752-13792-5-git-send-email-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.